From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E39673A1A29 for ; Mon, 18 May 2026 22:03:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779141796; cv=none; b=UBf7zJP4xFg2/ENvz3u+RVDrJGn0GrKt7+U4XtbzcRcvpDZTcy1vNgeoKffCp+GGj8gwBm4GghXOTJJQi9M8LPTH4hRBFcvw+d6r9kFC9GTkU4RB+s9nfGLgvSB4VvDwJJIactFloSdL9xs8CsXC4a3GICDXDH4m+T9HABRGWd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779141796; c=relaxed/simple; bh=R9bwTFIJwq+fwIoSatBtXQNRjV3224ZU1kWtKpEQ9Qg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IIDrvxqRUK97Pq6qeoBCj9z/PWRm7hS3UxvpFXCoIntzyfONXJOXksyOZDdbpAXn7DMR64xth6z1OySPe76zGdN+My3cmQM5lREGhTthR0TH8RRjvd+4cjl9f29p4qmdGezhbaZHyUUKHwT39xZquWfzBNuwjN9uYZCmtsE6HPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WbXdtKU/; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WbXdtKU/" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-836ebdeb969so1238571b3a.3 for ; Mon, 18 May 2026 15:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779141794; x=1779746594; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yvUEwi2/32Pm+I7ySH9JgCFLggtG2+BEwjV7D+cKqy0=; b=WbXdtKU/eCEjZuKwBI7CdlHCVikh+9TI8m7nb2YVRmOmS+nE40OgOXIKXuIbfALRMQ +Yvv6KqZ2g5nuXDflz4hNH6o85IAfRlHT8m+1zK9cQythbltEplGt0qQuRPg1wHPcY3R PeuIZAR8BfKOLVkig+x3do1N1IF3+ok0k3YzQpFRyVo5C1Vj/9JmGPN9us5CWHXJxx8O V2vyR7Z/3ou0Lmon+IlDPP7sBg6rrRg5qlgS+i8PVa+oq2MauzJ2sF1PbDzb0G5ELtkh S2jJmFIZxm7XPhztWOAKv/APy5XKTvGH21ID8oHciVfULlAPbD1IQMTorIg2VwFhzkUq Nw7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779141794; x=1779746594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yvUEwi2/32Pm+I7ySH9JgCFLggtG2+BEwjV7D+cKqy0=; b=hrCgZY/MqJbne/k9eqtJTngzAkpM6VD+aaeMmPTx8EVVlkvp/y0J6DGYoqldh9jGfF X0c0+5UF0gd3lb2Q1NbdD4Q028WRW3UIXS8rBE0mmH24TQtqlqB76YTtcZ/yang6hnUo XJyQbAYUPEk+mVlMWuaKSanUbnY9SBK3DBah0xwg8A6P9JOyAYmGd39nH+a5Fs+MQjD9 OBu/a5TQaiAheGjBRzro56F9g8PkP0Y7rPjNzAcghoxNP8BjvYcPCrB5ms/GsVFq8LCs QVbwaE3oVWHuW9Ft2ImAjQk4/tWNJzjdEKxYcBS5L9b/mWB7ivOd0zK9+FMG1ki0lhN8 dDlg== X-Forwarded-Encrypted: i=1; AFNElJ/7ulPuBecCx3AmAfkNhv8wHhF2M8kdBvOxjEmKByONMjp11DMavBulF8SOIiF3p6jRD1Sgq4hAy/+Q/BU=@vger.kernel.org X-Gm-Message-State: AOJu0YzUdeVe6stn3euCEj780hbFMv67ZwuGaRw1m54Sb0TRX7wIZY/y q8Gz4PXh+SG7+JYAkIyzrqQdmSoNLSO2d4XDgdFCnV5AOBqGsYCimM+d X-Gm-Gg: Acq92OGZcK7sj+02DUcTyDEL6HIGN0Y+ZcE7Gzc3X0FZrUOyNSBQXvXpgca678d/bh0 v3+7VQ5WokgSF+vGmZaPd6K7+TGQXYtdf/9GNaoXjYk5wko4r9q7Nvd90zmS8MbG2Bf43Y/bgzE VTws5ZhjSMH+gODBZILDn/mBrDpP81eKKNowgvFop90BWHjxJhDbQMG1NA/YLao3MIvd5azvlau bB3L4PlZ1c2/MV7vXF8G9hZ3JaLmVCDhee38lOXweAIu39BPWkBNlSZLgwg/246hEOWn44yi/l0 cG781BfHf26BUHNlybxr0aWD4T3GivI93cMkIXHs35Q2wG+AF94JDMXbTqjtWv6cCg0gM+3usMq toe/AwDrrFBw6QdygPAOSqaHLca/QayVBhYfLUcJPaGF+lNLqcvqQFvb3DYI6eNjSwuhDa93kpN KaBZmi8H1nh4P/Ab2nvcDHVrfgAgKzr9ijb5GW32tKredgy8/zjuj7KIZ2QngyVm2pe1QnW8Cho gnzAWWL5LQU9Bt7wsJwV5IvpMudGpalLp1RdqxhZh13Em8I//Mzhx64FzLlXipjEdP//Tg= X-Received: by 2002:a05:6a00:12e7:b0:837:666f:8fcb with SMTP id d2e1a72fcca58-83f33ba1603mr16232568b3a.5.1779141794380; Mon, 18 May 2026 15:03:14 -0700 (PDT) Received: from lord-daniel-VivoBook-ASUSLaptop-K3502ZA-S3502ZA.www.tendawifi.com ([14.139.108.62]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f1977b128sm15772960b3a.22.2026.05.18.15.03.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 15:03:13 -0700 (PDT) From: Piyush Patle To: Jonathan Cameron Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Klinger , Andy Shevchenko , Conor Dooley , Krzysztof Kozlowski , Rob Herring Subject: [PATCH v9 09/11] iio: adc: hx711: localize loop iterators in hx711_read Date: Tue, 19 May 2026 03:32:25 +0530 Message-ID: <20260518220228.63322-10-piyushpatle228@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518220228.63322-1-piyushpatle228@gmail.com> References: <20260518220228.63322-1-piyushpatle228@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Tighten the scope of the loop variables in hx711_read() now that trailing-pulse selection is already handled by the callers. Also replace the 24-bit loop bound with a named constant while touching the same code. Suggested-by: Andy Shevchenko Signed-off-by: Piyush Patle Reviewed-by: Andy Shevchenko --- No change from v8. drivers/iio/adc/hx711.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c index 9e5cafa1e307..0db2d2db9242 100644 --- a/drivers/iio/adc/hx711.c +++ b/drivers/iio/adc/hx711.c @@ -23,6 +23,8 @@ #include #include +#define HX711_DATA_BITS 24 + /* gain to pulse and scale conversion */ #define HX711_GAIN_MAX 3 #define HX711_RESET_GAIN 128 @@ -157,16 +159,16 @@ static int hx711_cycle(struct hx711_data *hx711_data) static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) { - int i, ret; int value = 0; int val; + int ret; /* we double check if it's really down */ val = gpiod_get_value(hx711_data->gpiod_dout); if (val) return -EIO; - for (i = 0; i < 24; i++) { + for (int i = 0; i < HX711_DATA_BITS; i++) { value <<= 1; ret = hx711_cycle(hx711_data); if (ret) @@ -175,7 +177,7 @@ static int hx711_read(struct hx711_data *hx711_data, int trailing_pulses) value ^= 0x800000; - for (i = 0; i < trailing_pulses; i++) + for (int i = 0; i < trailing_pulses; i++) hx711_cycle(hx711_data); return value; -- 2.43.0