mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arpit Saini <arpit.saini@oss.qualcomm.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	 Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>,
	 Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	 Ayushi Makhija <ayushi.makhija@oss.qualcomm.com>,
	quic_rajeevny@quicinc.com, quic_vproddut@quicinc.com
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller
Date: Tue, 19 May 2026 12:32:46 +0200	[thread overview]
Message-ID: <20260519-curly-courageous-sturgeon-2facfe@quoll> (raw)
In-Reply-To: <20260518-ili7807s-panel-v1-1-d7b048163b1c@oss.qualcomm.com>

On Mon, May 18, 2026 at 04:34:12PM +0530, Arpit Saini wrote:
> ILI7807S is a DSI display controller used to drive MIPI-DSI panels.
> The DLC DLC0697 1080x1920 LCD panel is based on this controller.
> 
> The panel requires a reset GPIO, backlight enable GPIO, I/O voltage

If panel requires it, so should the binding.

...

> +  reg:
> +    maxItems: 1
> +    description: DSI virtual channel
> +
> +  reset-gpios: true
> +
> +  backlight-en-gpios:
> +    description: Backlight enable GPIO (active high)

What is the name of the pin in ili7807s device?

> +
> +  vddi-supply:
> +    description: I/O voltage supply (1.8V)
> +
> +  avdd-supply:
> +    description: Positive LCD bias supply (AVDD), typically +5.5V
> +      (range 4.5V to 6.3V)
> +
> +  avee-supply:
> +    description: Negative LCD bias supply (AVEE), typically -5.5V
> +      (range -6.3V to -4.5V)
> +
> +  port: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +  - vddi-supply
> +  - avdd-supply
> +  - avee-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "dlc,dlc0697", "ilitek,ili7807s";
> +            reg = <0>;
> +
> +            reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>;
> +            backlight-en-gpios = <&tlmm 91 GPIO_ACTIVE_HIGH>;
> +
> +            vddi-supply = <&pm4125_l15>;
> +            avdd-supply = <&avdd>;
> +            avee-supply = <&avee>;
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&dsi0_out>;
> +                };
> +            };
> +        };
> +    };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 26060e51c067..529aed669401 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7941,6 +7941,13 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
>  F:	drivers/gpu/drm/bridge/chipone-icn6211.c
>  
> +DRM DRIVER FOR ILITEK ILI7807S DSI PANEL
> +M:	Arpit Saini <arpit.saini@oss.qualcomm.com>
> +S:	Maintained
> +T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git

Drop, unless you handle patches for this driver.

> +F:	Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
> +F:	drivers/gpu/drm/panel/panel-ilitek-ili7807s.c

Drop, no such file at this point.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-05-19 10:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 11:04 [PATCH 0/2] drm/panel: Add driver for DLC DLC0697 DSI panel Arpit Saini
2026-05-18 11:04 ` [PATCH 1/2] dt-bindings: display: panel: add Ilitek ILI7807S panel controller Arpit Saini
2026-05-18 16:23   ` Dmitry Baryshkov
2026-05-20 12:54     ` Arpit Saini
2026-06-06 12:16       ` Dmitry Baryshkov
2026-05-19 10:32   ` Krzysztof Kozlowski [this message]
2026-05-20 12:40     ` Arpit Saini
2026-05-20 13:19       ` Krzysztof Kozlowski
2026-05-20 13:26       ` Dmitry Baryshkov
2026-05-26 10:32         ` Arpit Saini
2026-06-06 12:13           ` Dmitry Baryshkov
2026-06-08 10:24             ` Arpit Saini
2026-05-18 11:04 ` [PATCH 2/2] drm/panel: add Ilitek ILI7807S panel driver Arpit Saini
2026-05-18 13:50   ` Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519-curly-courageous-sturgeon-2facfe@quoll \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=arpit.saini@oss.qualcomm.com \
    --cc=ayushi.makhija@oss.qualcomm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_rajeevny@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®