From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C823CF698 for ; Tue, 19 May 2026 07:20:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175214; cv=none; b=rCq7JF4RtPGSN/bG7DEcndSC43JuJ5LPCQj6UXirQexHeOo4bH4ImwrIg41lcbOmaDlMy8KoqaQQzFoUdzAv/spjxqOVXGhSHn0KOhnoAiDDs4qT1qiK6H9heY/a1GbDHLaVYKnGzUyMjtfIYgoWz5cqVcOaDjIWHL4hOhe1BbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779175214; c=relaxed/simple; bh=15K5IP1vUFgQ5ahLz1o6QIvx9EGIvH4eeubXmdEOEjc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YqRvXuY3h3EPQhlGi49FSq0VOCjqIxK2JiIkLUgu5W7jcYXOYBK1MGrJ+SVijAhIR/XRZLBIz/JpZWywE42qN2E2NrGHpKsr/pDPmhsHV5icZ+Xc7TNKUl8mdBObJxbRNY8SxzmrECWkN3FdR6dDSa3YlmV5kOTv3imPYVpb0Rw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NDZTYHiw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=aMXEPoGy; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NDZTYHiw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="aMXEPoGy" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64J75srY352983 for ; Tue, 19 May 2026 07:20:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 181vtMHDizQN14Sm20ahawzl/5RDy+3nFLNw102hucc=; b=NDZTYHiwpj6J/gA0 WIIIBDpPK1iJujHaySfZEq3pTE4hy5D9QRTEadIS/Eqw15ZFB2WVRCeEChKJnsPh JIDe4pQ93Ny+mcLs0mTC3ERqUpJdML3/TGY+8jcIpdNkPkrIb+VfDbaeZSfNzR+B Z/tbHdWaEXcCaaFpF8T2eNcm5xKuihuhHrIU9obh9z5BznpwpLjCbd93JTQm6+VV 3MD/ankY4D3UyGKYN8bazCxcaGUbniHu/i8quiMstAw+A4R2Hi1vb+t3i/jYc/1M /k8nqQ73A2bktT8Noz/ZP6rVutRllh7lvszYkHyAbFU5YOQe2x30Kh+KqgDkK+We HQnFwQ== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e7xjamw2t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 07:20:12 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2bdd327d970so1609171eec.1 for ; Tue, 19 May 2026 00:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779175211; x=1779780011; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=181vtMHDizQN14Sm20ahawzl/5RDy+3nFLNw102hucc=; b=aMXEPoGy84sR92S02DnSJv5zuonYbKmOG6SPpn+rt6y8NHjHXc+xE8kZdkAn7eVsVe rmhlt4tFIyjFU4FgT93qA26//P1deWP7aPnpbK89ii5CEMPFEefDvEefiBvYcqHj0arF oDKxB6MFdlDVZ+YXy2JbiVjEWm630vvGI/49GvgAFYVIg6aM+Lru4r9v+LZ1HJujVVgj emSN5wYefYmdl6z2SgXL16ll3pRN/XOi5tiEdYfDa4dwwXbtSaZ7XxQP+ENNIQuv9aMQ i0gl21CEL31/KoQ6j+Vawt2xs3S44tZpFxrLa9g5Cp5UFP/iSviO3CCtLM5fGASCMAnQ mhvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779175211; x=1779780011; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=181vtMHDizQN14Sm20ahawzl/5RDy+3nFLNw102hucc=; b=nxTS29dVKuOl6EukemjklLfO0wLHd/886aRL70GrsKE7ukCl8YSJLAzuKC60bgFwal ushbksrBpSCVtCK/mrwgXfjYJ1PmbIYB6atNkOJBSE16xSClnLR/69qWEop7GBkrqRX/ 1GzJCktIZtXTBHQ2il5cdaolhYmHAJX0lkuR32M+1ATYnb/yYfPAGBob2oL12MCpST0u +AbqHuHLSkUCGeOm2JY2Ra3t5LLkYpEMJjvwJnaEsPbyhSOutNrRpy9F6omerDwGVbxy 5yERH0u8VLlGdM8ZSOgEMsQIq0wNcMavH4T0QUO+rRhdJXnGW7guUuuEs5TITiIeSPNu o+kA== X-Forwarded-Encrypted: i=1; AFNElJ/3fvIvyBEL0guYjB+fR1UdP9wEriIvPZ6z289pb85toVawI3fipV/wObQzN7ZSmXNaHGAJohcxy0ea79c=@vger.kernel.org X-Gm-Message-State: AOJu0YxJOHzp2JUk6gknXH7rx0hz4QFeYTyTcQW3OvA5VMGl+udv74k3 MkRO4YF8QQdqGTBxQ1ZnQI4R/vVLy+FEaIWMV8tB0mwBZ+BprBJpaLKTXsWAV/ELgftXOQHLxR+ P23CWHdfPlTXuLxB7J4gr13umLK/pC6BLDoOSgbESUNmvjgS3LDJWOaTIhKPkSGbF8VuVxLHuB4 jJlw== X-Gm-Gg: Acq92OFthizUFgwUueReByrO903OXwfENmY20I0GFAhTjfvtK8jQ9/MemVd4kjirAzz uAEURd4aZuGH5ja98j/6em3I3hrx975BsVis2zPnLRZ4pD2AhYXzXMko3kn0LE5/K8kfPUM6aKX 7lr+FpxPJ5TR0sFhz+XoeVb2QwIBtD4vX4ibM6oqKreHEwc/87d74H3F2Ddhrw13skIDeK3Ls0Z 51CGBptin4BUSQH0z0OuErKFE5bhbgOlsYn49rOjMCHVb6Nf1sQU6UdSIfpIXVvqfPQIco3Auuv A/RtVySuVGQGbo7q0sky0j58vEKkl1dUegpu9z7Kcpz6e8xyRxE1Qr61WizfcBdrqKCdmujy9fh vuS7O3a10m5RtQ9gxPZiiqpygBzH7xiSm/SJN6OeUK0zcELhgWsDUldcjZkNRjn5Z+klGepEn X-Received: by 2002:a05:7300:a897:b0:2ed:a58c:942 with SMTP id 5a478bee46e88-303978ad90cmr7498110eec.8.1779175211310; Tue, 19 May 2026 00:20:11 -0700 (PDT) X-Received: by 2002:a05:7300:a897:b0:2ed:a58c:942 with SMTP id 5a478bee46e88-303978ad90cmr7498094eec.8.1779175210849; Tue, 19 May 2026 00:20:10 -0700 (PDT) Received: from hu-jingyw-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-302973bcd0csm16438595eec.24.2026.05.19.00.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 00:20:10 -0700 (PDT) From: Jingyi Wang Date: Tue, 19 May 2026 00:20:04 -0700 Subject: [PATCH v2 3/3] remoteproc: core: cancel crash_handler work in rproc_add() error path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260519-rproc-attach-issue-v2-3-caa1eaf75081@oss.qualcomm.com> References: <20260519-rproc-attach-issue-v2-0-caa1eaf75081@oss.qualcomm.com> In-Reply-To: <20260519-rproc-attach-issue-v2-0-caa1eaf75081@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier Cc: aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Jingyi Wang X-Mailer: b4 0.15-dev-3d134 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779175207; l=703; i=jingyi.wang@oss.qualcomm.com; s=20250911; h=from:subject:message-id; bh=15K5IP1vUFgQ5ahLz1o6QIvx9EGIvH4eeubXmdEOEjc=; b=ObV/HZB+ATu9c6aifjNcY1ruOoBKe4q84+p52UJnIpBtDD4PFIFlf2u4BMa36ELP9qPJuBLtC 58MMCH9vtEaAvtaXvZiyrHtoUWswvIQrkooHxx5ZLfyiC4n8v8vhpDE X-Developer-Key: i=jingyi.wang@oss.qualcomm.com; a=ed25519; pk=PSoHZ6KbUss3IW8FPRVMHMK0Jkkr/jV347mBYJO3iLo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDA3MCBTYWx0ZWRfX+C2h+mf8M8e9 aBsje0miEwlQcwieG2LPhOXuus4U/nOQ7cgrdavz4dskdgVFzGYYG4rxfubTEzi5k6cLTvgXI8G xSrcoNIKEtxaeOmpeOGS0TdEPYoZnQMtl3gcBVpU1DFL2M8K1QMQGQdFV55j9JcKXpiahVggZ2U V3ajZuZLj9yZs+Qh3cgeNq0h6PRUZ2znJu6w3a2FjLs1G0OK/97bArFItqirjVxxVGqXbF1DTQ8 MbwzppSKn8xI3D46x75Lqvlymvem1IWYGM8B6pIztCgo+2x3oQNKRNgI+I+9EgNsmeTU+F9Ai4A v/E7DwTvy4n9+En67V01wFEAz6inAlcC/gmWnp/63ycaITJLjOQLW2b74UJzlfkFnO/PcJ6avqQ QP+msF/RR8pQp6qgDt/ieZK2sqOEH73s3ezsdcyQJMVOQg0IyUNnofnH4+x5gfKjaMb3eA0cQGa 9Qot0nnTxGjC4Qr6hxQ== X-Authority-Analysis: v=2.4 cv=BYHoFLt2 c=1 sm=1 tr=0 ts=6a0c0f2c cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=VRyQhUk9NtpfCekB4XAA:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-ORIG-GUID: mhz0K2UN3CUc7wDP8GQTfIrQF-56-_UB X-Proofpoint-GUID: mhz0K2UN3CUc7wDP8GQTfIrQF-56-_UB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 spamscore=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190070 Ensure crash_handler work is cancelled before tearing down rproc resources to avoid accessing freed memory. Signed-off-by: Jingyi Wang --- drivers/remoteproc/remoteproc_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 6e23cb11e515..abaa3786731b 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -2327,6 +2327,7 @@ int rproc_add(struct rproc *rproc) return 0; rproc_remove_dev: + cancel_work_sync(&rproc->crash_handler); rproc_delete_debug_dir(rproc); device_del(dev); rproc_remove_cdev: -- 2.34.1