From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4F23DDCD for ; Tue, 19 May 2026 00:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779150785; cv=none; b=MT+7CLK93N6Qy2pUVZ4Rbb+xohFQK2vamUo+8CfRwMjfTlqUNvmffU8JGNufGVbSa1czFstzFNhElBA2zCpoN2pYDSQEHvIZkuVB8pvYwPnwxzs14PvQiYWjD557O2ZVGDqdUafgxM+awR2jxmA6TKVgYwB/ULh2tfOqQ0uayHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779150785; c=relaxed/simple; bh=FuErmdxHsxg6/7/1IgVUv0uGSQ6Zm1dWU+tQAbt3MKw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e72DbWUduIlZZE3YqhYYFJrRc2CWH9iwYczrPBve63Q3Ol/xpm2bZU2QTEB0kt+DocKDmNHLvQDOEDHzACZUC6tw710sPDjwQABuAq0OcBDij6UP9xBce/QWRw/oyP+pHV9E1BcOAX+/Dszr+xGx19ciWAK1n36+yA5zVlrb1is= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vLEVVK5R; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vLEVVK5R" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38C2BC2BCB7; Tue, 19 May 2026 00:33:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779150785; bh=FuErmdxHsxg6/7/1IgVUv0uGSQ6Zm1dWU+tQAbt3MKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vLEVVK5RwKB62dfACFV9CdQRz90aVyGW4NNfOaBD+Cyqj2t8oFVRhT8z6csmuG+I8 nkxwkL7LchPTE1L4AoTL8x0o7MHldmi96EOn2sQfKkB2rnpvIF/7S1LlIiUjnkPCWg bwxgBTK5HBjVIC9R4rj1vLFui9p/1hG+MLFdeSWnFKt/q8ho2lTjRGxNlN+Rwj+LgH YDv4DmRpYzgY3cyuu70kp+y+++BgfUm46xwjimQNK5wrKx7Q0fyIp6mkRxcajyXuLm Xi/73f0o+fRYNn0EyX6ICyc/IdJSCQzCLO98p3hzZaNFAdv0nIUpF++2qO/ecOEV8L 8gV981wfoXl/w== From: SeongJae Park To: Xuewen Wang Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] tools/mm/slabinfo: remove dead assignment in get_obj_and_str() Date: Mon, 18 May 2026 17:32:56 -0700 Message-ID: <20260519003257.99650-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260518062159.80664-3-wangxuewen@kylinos.cn> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 18 May 2026 14:21:58 +0800 Xuewen Wang wrote: > The assignment `x = NULL` sets the local parameter variable instead of > `*x`, which is a no-op since `*x` was already set to NULL on the line > above. Remove the dead assignment. > > Signed-off-by: Xuewen Wang Reviewed-by: SeongJae Park Thanks, SJ [...]