From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43B352D7DCF for ; Tue, 19 May 2026 01:33:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779154421; cv=none; b=BQ0QWhXVZUpbecn9SCrJaNv5PGSCm6wIZpx9Y0MHT945B8V5m32UwcajHf3Ph4pwXJ4mhlV3yJfCG4bi2YhSenYxqFqOUpy+pLe2e4MqsrV0/YMdljRnl9psMtPaYLnBTGszWD7jsBKRWUSlm/My7zml3+jUYO5QyOk+bc3jfwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779154421; c=relaxed/simple; bh=oO9rfzgD0i52SfOvIc9QVYCB//UoPdVcUA7wcbwKLNk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lSVDKFtBl67OIEuHH5tDf32v4PnOaXlmDMOrpj7Yl6rRQQfVqxOtG+CH/oMmpnwBmmhLFqJo3SDDJiW9BekuAj6BOt/qJ1Mz8MoPhAgBOblTer7RxCYNW4GB9McjJNr0yrhY5c22/Xz1HRaudN6gJBvCS3wOzNphDlRyXeeE/O8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nHkOM7ei; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nHkOM7ei" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77D97C2BCB7; Tue, 19 May 2026 01:33:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779154420; bh=oO9rfzgD0i52SfOvIc9QVYCB//UoPdVcUA7wcbwKLNk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nHkOM7eiYDB731zItDYMVhyw6LPz/p4X5HD+dTFN2F3kFpBcJruV7mtaqQRskiZue J//5oFKSRd0Ml7EVOoDP1PUk/BqBo3d9yKNFAygZgEwzm0vf860xt0Ttsp3uOUtxcQ T2clRMy5K9Gp1nKHJrUkPZXwzJUlglKKaPI6ks5LByZM1XaeVeZYlAGEv3pG5etVpC dEBqA09oPVg4H4BVOtJWMLvH79QkuJ3+hjW6tIRBK18/0o2IR8hHQZkx+uqaPXzrW2 74MtSJ50q+NEySjPH6yLJJgcykUAV/dZqG/ZXnnBxZtP1Un7ai0+xPeU69rIGYw4T6 L/Gn1uGh44x7A== From: SeongJae Park To: Brendan Jackman Cc: SeongJae Park , Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: drop a misleading __always_inline Date: Mon, 18 May 2026 18:33:33 -0700 Message-ID: <20260519013333.102801-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260517-b4-drop-always-inline-v1-1-97b90930e8b8@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sun, 17 May 2026 23:37:05 +0000 Brendan Jackman wrote: > get_pfnblock_migratetype() is called from outside page_alloc.c, so it > cannot always be inlined. Remove the annotation to avoid misleading > readers. Makes sense. > > At least in my minimal config, with GCC, this doesn't change > mm/page_alloc.o at all. Same on my setup. > > Suggested-by: Vlastimil Babka > Link: https://lore.kernel.org/all/016c8bef-57ef-44ef-bf60-86dbfd368dcd@kernel.org/ > Signed-off-by: Brendan Jackman Reviewed-by: SeongJae Park Thanks, SJ [...]