mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@kernel.org>
Subject: [PATCH] irqchip/dw-apb-ictl: fix compilation on x86
Date: Mon, 18 May 2026 19:57:03 -0700	[thread overview]
Message-ID: <20260519025703.817197-1-rosenp@gmail.com> (raw)

__irq_entry belongs nowhere in irqchip drivers as it is an
architecture specific annotation. There's no specific architecture
depends for DW_APB_ICTL and there probably shouldn't be.

Fixes:

drivers/irqchip/irq-dw-apb-ictl.c:33:13: error: variable has incomplete type 'void'
   33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
      |             ^
./arch/x86/include/asm/irq.h:19:21: note: expanded from macro '__irq_entry'
   19 | #define __irq_entry __invalid_section
      |                     ^
drivers/irqchip/irq-dw-apb-ictl.c:33:24: error: expected ';' after top level declarator
   33 | static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
      |                        ^
      |                        ;
  CC      drivers/bus/fsl-mc/dpcon.o
drivers/irqchip/irq-dw-apb-ictl.c:205:18: error: use of undeclared identifier 'dw_apb_ictl_handle_irq'
  205 |                 set_handle_irq(dw_apb_ictl_handle_irq);
      |                                ^~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/irqchip/irq-dw-apb-ictl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-dw-apb-ictl.c b/drivers/irqchip/irq-dw-apb-ictl.c
index 4240a0dbf627..2cf82bdd720f 100644
--- a/drivers/irqchip/irq-dw-apb-ictl.c
+++ b/drivers/irqchip/irq-dw-apb-ictl.c
@@ -30,7 +30,7 @@
 /* irq domain of the primary interrupt controller. */
 static struct irq_domain *dw_apb_ictl_irq_domain;
 
-static void __irq_entry dw_apb_ictl_handle_irq(struct pt_regs *regs)
+static void dw_apb_ictl_handle_irq(struct pt_regs *regs)
 {
 	struct irq_domain *d = dw_apb_ictl_irq_domain;
 	int n;
-- 
2.54.0


             reply	other threads:[~2026-05-19  2:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  2:57 Rosen Penev [this message]
2026-05-19 17:16 ` Thomas Gleixner
2026-05-19 21:22   ` Rosen Penev
2026-05-20  9:01     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260519025703.817197-1-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®