From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C8843E170F for ; Tue, 19 May 2026 08:24:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779179078; cv=none; b=Os2+ScjMoomtqIipyUW0hkrLJFhKSnaWc1wdMYSFebOCUbToSDo8Tho8fcrju+Pf6C0qKdAb1ccb9C9Cyzgi4RyVZXyufUXKJcWCWQHR5zxPVNDSChCDiEZEgMT4NpHoQHydCyXSYxOILeY+h6Lb0SDpoPDoSuKwwi+QxleHgg4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779179078; c=relaxed/simple; bh=CkstdbjcyxCbFYACRa+dH3E6m7IV7Z9T7BiW3Y+DXR8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XDNItWAH6KlS9Iv7dGwrMtcm8SO+mYhZVtxSg05jVrr4W8aBTTx16n++CZDIbwlmsyv3bMZSJb9NN4Rri3ESpe6CV93rWiPC+mkMa9YGDRX9hpSD+xWHxMbSg3jIFU45Jbt9s/UeMqUDpHq6o5KF1MEqppOyZXD8HqYd2Z+BSbs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AGM9D64J; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AGM9D64J" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-82f8b60e485so1247546b3a.0 for ; Tue, 19 May 2026 01:24:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779179077; x=1779783877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hWIfLWdmt/c7x4yuYJlj2y5vCVFFJpw5Nml3m5vGj7s=; b=AGM9D64JwCdhNey+DtCqHFGFqxD5qKbcA8ihhB/rvkL1oirEoxRSMXQoIO5WEil7ge lpf1d+BNRtErbrp8II3ryx3sSY188aDOY7/0+Z0oSxRbtUf1ZTNYq2Q9+TVk5sda1IBS ihAuuRqaVsqihhmifeGtNWCwqHOjiQQbbMerNndmP+U8TUdxEvd5pVe9lFwqqdP9DYsp DV+l4levYqbOV1IodpffFYv0EOdv1L6fzwlhAIzvRhKwlKEZsDYe9Al58NulG5GmgpWF pXa33PuiLqtC19lCZGNoVhiVD1HYkrlofPu0h3MKitV3Ah940uS0DDqCVyXD0NY0TkB/ uWqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779179077; x=1779783877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hWIfLWdmt/c7x4yuYJlj2y5vCVFFJpw5Nml3m5vGj7s=; b=Lx/5w9gyZEnoADH6M9Ne+yGxy2CRPJs9heWeZXFb1ha7RGasBGraRzSLUuzYIACzXM hD120jhdJqERahoK2UYNPaHcP1iiGSOAUPuCnZQhoHQ5vRuoEXHNHqS5qUJlRGeJOu+Y qdSdmhzgX9VsfXkdjTf0IitxXqSaDEFzJC/ZFMUAoZ+BiX4K3Lld1fg3sBri9PF9FRlR RpxHkFJBVrxDKWjGjRNRphyfsb1GHEL5WoDAD3DKJLDzc+U5f7UJf1vxTmMWC8dM17sX 5Hkn0tHl8vM4wFRnUwinGy8JtdiBVcXlDrvrMHcmDzDHb8hUvUmrvOaOfo+8Rm9eX6wg dxFQ== X-Forwarded-Encrypted: i=1; AFNElJ+JQ4K7yH+NKiF1s5RoIWQ1jka4rPxgvQx6uWcW/htkb7uKn+fTG5d6MiqkcLxYdIyuRDibdrGukRz+jPI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4G1A0yoP88Hn6CEtqA9kk1GT0b9XhDofz/P0QBjK8kIXRYdyZ hNUDxi87QwNRgbRPeB0epLKYsjFRHSlvyjumlooxYTxMSqh+Jyl1coFb X-Gm-Gg: Acq92OEFvlJxgURA/mb43KIp1fyhUnPgdfTCawFqPBJTs+Ki7ph609XYVpIW6SUj9FS EWsYvM7P3WX8ed7dynKRH8dogRqa+J8MW1RvWIPE8LNhBZ2wAH5bYiGAtAGlHSw2FBvPyKdSO+B aSvgegX67jhmP3Ng9iT9MM4+BYIAb0wMPSSFEDgZakuSbAWBTbloUIqTrlIMw/m287kUus0MAs2 n5wZEp9XivqqKfg5SIv/hxxR66Z7L1Uj2Oe0T5H4QdEedEJ6rPfGD1M16E4/jp7kfP8rmtjmH++ sdxzICV1vIQXWL3Pamj+c84K1Ym6EuoxoWXvFCNdsn5mO0Duij2+Gxa0HA5yzOGFtfBb0jIZxrM bqwTlZvHk7VFJWd4Qmk056liEvd7IrP3V9AxpGnn4rQa6H5T71GzfSq1d99XTWehAKsmIULZMjy C5BdhIU8UAgoLvoRq8X7FLQNqLMCirANwqYBnFRUFLMFwsTp43 X-Received: by 2002:a05:6a00:9094:b0:82f:5726:be23 with SMTP id d2e1a72fcca58-83f33ddaab4mr19553785b3a.49.1779179076711; Tue, 19 May 2026 01:24:36 -0700 (PDT) Received: from intel.company.local ([210.184.73.204]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c5b4bfsm17822898b3a.28.2026.05.19.01.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 01:24:36 -0700 (PDT) From: Wandun Chen X-Google-Original-From: Wandun Chen To: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, zhaomeijing@lixiang.com Cc: robh@kernel.org, saravanak@kernel.org Subject: [PATCH v2 1/3] of: reserved_mem: avoid unnecessary memory allocation when __reserved_mem_check_root() fails Date: Tue, 19 May 2026 16:24:25 +0800 Message-ID: <20260519082427.4181476-2-chenwandun@lixiang.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260519082427.4181476-1-chenwandun@lixiang.com> References: <20260519082427.4181476-1-chenwandun@lixiang.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit total_reserved_mem_cnt will keep the init value (MAX_RESERVED_REGIONS) in fdt_scan_reserved_mem() if __reserved_mem_check_root() fails. fdt_scan_reserved_mem_late() calls alloc_reserved_mem_array() to allocate memory according to total_reserved_mem_cnt before __reserved_mem_check_root(), so if __reserved_mem_check_root() fails, the allocated array has nowhere to be used, so no need to allocate memory. Move alloc_reserved_mem_array() after __reserved_mem_check_root() to avoid potential memory waste. Signed-off-by: Wandun Chen Tested-by: Meijing Zhao --- drivers/of/of_reserved_mem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 8d5777cb5d1b..7856dc857d65 100644 --- a/drivers/of/of_reserved_mem.c +++ b/drivers/of/of_reserved_mem.c @@ -265,14 +265,14 @@ void __init fdt_scan_reserved_mem_late(void) return; } - /* Attempt dynamic allocation of a new reserved_mem array */ - alloc_reserved_mem_array(); - if (__reserved_mem_check_root(node)) { pr_err("Reserved memory: unsupported node format, ignoring\n"); return; } + /* Attempt dynamic allocation of a new reserved_mem array */ + alloc_reserved_mem_array(); + fdt_for_each_subnode(child, fdt, node) { const char *uname; u64 b, s; -- 2.43.0