From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C8047ECE1 for ; Tue, 19 May 2026 10:03:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779185005; cv=none; b=WTWwO5dxsWXYQW1KOBUcmj6aetqyNpqDzcmTX7Z6E3He4p1glsypPVtwmEgDNcape50X0f/ZJWwNqmRAbE+HrGitj4NeH+6kqM22Y4ILUnS67EQPs1z1ROdIq8KMevastn8L5Ipecd5E6ZbkAcs0CzBvIjAXbn0be+iDty5PQxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779185005; c=relaxed/simple; bh=C2QIuZ/OvwmLfa9aJYHOYJCGwO834n4/XVzIE+p7+d0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iPz68d3AiaSxCwI/Z76ojH9Ald6Fc4EH3e0wKGXSP0QlZ9jqL9s7l0RXCXLr6zN0bWOP+8olLHQsUx41JJuZNsj8SpqM5MX34gr/U7jjpgwuAeghuruOvd88rQDez7MJlzDemw798kZ1HLMZ8FV0F9DVClt/U1NtaS1olJjWs3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=nlxpmuQR; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="nlxpmuQR" Received: from killaraus.ideasonboard.com (unknown [IPv6:2a01:cb1d:8f2:800:42d6:38fa:3bdf:70df]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7D81F296; Tue, 19 May 2026 12:03:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1779184988; bh=C2QIuZ/OvwmLfa9aJYHOYJCGwO834n4/XVzIE+p7+d0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nlxpmuQRFCG2bvFHaIp5sDoImul28fg9XtN6JP5HZrTGorJVs17GedWO6GvJ16KTu pK+1eZsOPTXDV3yFVGv+bSHkEPbBYxxAENVBvwbOIT+/8s4SFDAoqX+helIjrWNdi/ 8IuAL+rGBjXA/lzJVI0WMSreXnHo8of5S9y36jBY= Date: Tue, 19 May 2026 12:03:19 +0200 From: Laurent Pinchart To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: Liam Girdwood , Mark Brown , Woodrow Douglass , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] regulator: Drop unused i2c driver data Message-ID: <20260519100319.GB45952@killaraus.ideasonboard.com> References: <5ec4275c52015051f492b3e18e05a4db8a6d4741.1779184320.git.u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5ec4275c52015051f492b3e18e05a4db8a6d4741.1779184320.git.u.kleine-koenig@baylibre.com> On Tue, May 19, 2026 at 11:57:50AM +0200, Uwe Kleine-König (The Capable Hub) wrote: > The two drivers explicitly set .driver_data to zero but don't use this > value. So drop the explicit assignment. > > While touching these arrays, unify usage of whitespace and commas. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) Reviewed-by: Laurent Pinchart > --- > drivers/regulator/max77675-regulator.c | 2 +- > drivers/regulator/pf530x-regulator.c | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/regulator/max77675-regulator.c b/drivers/regulator/max77675-regulator.c > index af3eb7174875..57350526afd7 100644 > --- a/drivers/regulator/max77675-regulator.c > +++ b/drivers/regulator/max77675-regulator.c > @@ -1029,7 +1029,7 @@ static int max77675_regulator_probe(struct i2c_client *client) > } > > static const struct i2c_device_id max77675_i2c_id[] = { > - { "max77675", 0 }, > + { "max77675" }, > { } > }; > MODULE_DEVICE_TABLE(i2c, max77675_i2c_id); > diff --git a/drivers/regulator/pf530x-regulator.c b/drivers/regulator/pf530x-regulator.c > index f789c4b6a499..ef3d5bb784cd 100644 > --- a/drivers/regulator/pf530x-regulator.c > +++ b/drivers/regulator/pf530x-regulator.c > @@ -353,10 +353,10 @@ static const struct of_device_id pf530x_dt_ids[] = { > MODULE_DEVICE_TABLE(of, pf530x_dt_ids); > > static const struct i2c_device_id pf530x_i2c_id[] = { > - { "pf5300", 0 }, > - { "pf5301", 0 }, > - { "pf5302", 0 }, > - {}, > + { "pf5300" }, > + { "pf5301" }, > + { "pf5302" }, > + { } > }; > MODULE_DEVICE_TABLE(i2c, pf530x_i2c_id); > -- Regards, Laurent Pinchart