From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A69A13769E0 for ; Tue, 19 May 2026 14:47:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202054; cv=none; b=Ip4b4HTQuxBxQjwmKlQhnTDu6ttcWCQ1ezq4InYt/OwrJXT2bWX0fWUSL0J3z4pniWtbDI/WkeJD6FyW4VfvpG1lC0rmbbeEoiShFPIccZVsK+FuKphKT6s+usRZff76q8VdH4SwagHJ+d8Kxfn5g/ljVmpSBInyijRjRUSjc1I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202054; c=relaxed/simple; bh=yP560d1t52HZeKj2l1zFFVEa59NMCb7eLPRgS8DMLcQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nc+wXjz7qvIMPfYjVajEsOCEJoR7ljpircdyhDvtJi4JUFWv3HN1awXctnPFVt54JHlmrMiNTTuYmmYMGaMJf0u6aAmC7xAh/AQIkwnJB2aGNHayDHar5PHDWHMFcCV7t1BbLYo9YhoXKi8cS2a3o/RB+JpPIFGl26aHzMG2sf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OHKQNgoo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NPtAZC6B; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OHKQNgoo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NPtAZC6B" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wmO8Wr7tsXS06zFtg7IPRTUeza9gF/FNLRuBRJpr0Ck=; b=OHKQNgooah5hXEtqAaN78j2rvgLSo6fdTLQi53ICr+6jZKD8wPWAQVe4P7xttWzn0W08Cf MsX0WQA8Fzi9y/zrUv5lmqQ5ANbgvXDqoFLjqs57kYkw9BJnWUZHPmL4AeLSftTc2A7tI7 HzezQl7DlGIzWOK7B2nwjDCbO406KGU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-7hYHjrlwMjG4Kg-EWBFzDw-1; Tue, 19 May 2026 10:47:29 -0400 X-MC-Unique: 7hYHjrlwMjG4Kg-EWBFzDw-1 X-Mimecast-MFC-AGG-ID: 7hYHjrlwMjG4Kg-EWBFzDw_1779202049 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45e7c7289c3so2137331f8f.1 for ; Tue, 19 May 2026 07:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202048; x=1779806848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wmO8Wr7tsXS06zFtg7IPRTUeza9gF/FNLRuBRJpr0Ck=; b=NPtAZC6Bc1a2bZa9QKuKljIi6jZQdHfC47KpWZ0sumcWDKN90K7Tkhrylv72hMgjZi FtRM0NcNuVapqhU56FaqglWum/L/ScNLn3hPbzlO2v80SbcEGNNV2EdEoKcfrAJ1nWXd G7bceEdyP1kOFspfoycmvLaI3evUxuAXC8kyU4ucMIA1x4a0Em/LtWxEfWEtDODt3Mzv 8q0SI37+mc5Jk1Rso3GSDcwwwu1FjR9IGzfrRP7CZmuAbojThNP8D5ProcC/oR7rYc6U yj4oXHD62+7fDIuN1SMVoI0T3d45rb6l1s+ptWeOq49Hsc6zW3KELDwbOF/UXLpffb7o 32yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202048; x=1779806848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wmO8Wr7tsXS06zFtg7IPRTUeza9gF/FNLRuBRJpr0Ck=; b=jISQgNh5Z6xgyp2sZDRyXhrnfrYXNXVVAmo8w4pd3c7h+AT+IYNG0UtcHjjC4NJ5V+ 27q6hNW0WP6ZVnPdAyGPHNzEfo7fC4TgS68LohTTpTEsSIPK1MuFKQqRI6wE6IDOH2+r nRGS0258tqx/qmgauzYBujQbsmITHOrQoz0eu1GEskuZoZATvEz5ADyZK51BV6TA3nXc EUv6IoiUJBwWnl11aT2aM0fNffw4BXHMmKqO1d1wHTP6CnpPCX38p5Pp9i0BYKI5Xvyg aS2sZjZLGPxBEStTIdVJ3qyhwI3dcK8t7rcFikcT4/8xBZig4Ks8tcBPWrp5QZiR1nt3 qCIQ== X-Gm-Message-State: AOJu0Ywomkan59tdC57Kyziwf9B7vhIcb6PUndbzZ7rw568jiuzxkgmj F0QlJz4xQnPjUWKiB2yjKte/dAFdHxdP9t4Vz1YZfC5PSLRDSeQXpaNKtD86/THgIkwLvEGxOhv LlKv3N3dyzyxU9w3qjFr5SjBGtFwC9ZGkCiuDC/LgvmyRt+ZANNHSSZBBjLZhYH1TyVW8g4fRFu KDVr94pSnqUCZQAu+nL6Y5A44dFnPUcK+Jotvc4uyPHOnrdcWG X-Gm-Gg: Acq92OH0D2UqHs2VU2yuH1YiPcHkap2UfPwElzF8zAgy1/IvKOfdafoYvq8bEBa2ofP hiieINcr1N17+AJqOX/vaYvLMDABjZG1I+m+vZVhJiQBvoTqyf5PIXjF7kLfM8TJnvr59x03K9t YocTSbBwMM16nQ4HXGqSjIdttDGXZgvc6fLeoOFp6bcrJPZNS98swc9Y94SsUKHtYTtfoz0ZKqK QEAoJRoN653gCx9xj5nM+mdiRbsQ8ivJF6bMY8802pGOj8v3b3KFaOtsXdG6BTYdIyqQx1PITSZ CSUl+PtTCKYRhmmI7aDXM1KBXXbWALxx4XFOVbr5xD5E7oiwMAKRH8cICHvEj4/QRo8KwiuPiOi AvtprY0PWkHDUmT7GslMTchpnZvMJfzVh4PZc+HHN3RyS1+9YM3N+53hQ+w== X-Received: by 2002:a05:6000:40cf:b0:441:29cd:a18e with SMTP id ffacd0b85a97d-45d941b19admr38673202f8f.23.1779202047981; Tue, 19 May 2026 07:47:27 -0700 (PDT) X-Received: by 2002:a05:6000:40cf:b0:441:29cd:a18e with SMTP id ffacd0b85a97d-45d941b19admr38673113f8f.23.1779202047191; Tue, 19 May 2026 07:47:27 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768acesm49336351f8f.7.2026.05.19.07.47.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:26 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Andrzej Hajda , Andy Yan , David Airlie , Dmitry Baryshkov , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Liu Ying , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Robert Foss , Shengjiu Wang , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:46:58 +0200 Message-ID: <20260519144712.1418302-3-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 41b3a9cfa2f5..d7c0a599aa42 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -51,8 +51,6 @@ /* DW-HDMI Controller >= 0x200a are at least compliant with SCDC version 1 */ #define SCDC_MIN_SOURCE_VERSION 0x1 -#define HDMI14_MAX_TMDSCLK 340000000 - static const u16 csc_coeff_default[3][4] = { { 0x2000, 0x0000, 0x0000, 0x0000 }, { 0x0000, 0x2000, 0x0000, 0x0000 }, @@ -1426,7 +1424,7 @@ void dw_hdmi_set_high_tmds_clock_ratio(struct dw_hdmi *hdmi, /* Control for TMDS Bit Period/TMDS Clock-Period Ratio */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 1); else drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 0); @@ -1671,7 +1669,7 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, } /* Wait for resuming transmission of TMDS clock and data */ - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) msleep(100); return dw_hdmi_phy_power_on(hdmi); @@ -2032,7 +2030,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* Set up HDMI_FC_INVIDCONF */ inv_val = (hdmi->hdmi_data.hdcp_enable || (dw_hdmi_support_scdc(hdmi, display) && - (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + (vmode->mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 || hdmi_info->scdc.scrambling.low_rates)) ? HDMI_FC_INVIDCONF_HDCP_KEEPOUT_ACTIVE : HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE); @@ -2100,7 +2098,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* Scrambling Control */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + if (vmode->mtmdsclock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 || hdmi_info->scdc.scrambling.low_rates) { /* * HDMI2.0 Specifies the following procedure: -- 2.54.0