From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5541831F991 for ; Tue, 19 May 2026 14:47:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202056; cv=none; b=ihtIb9ud3j1vfy1th5U+ngrg2mBsNaa002mX1rYjmtVgAjCvu15kItslJDcMYKqdk3D3XPiU781MQVaDQsxhDLEBkHBtdXVLsKNYCsUWZwWe2WObmRFuXSCaQA8yv7EloSI3UCJlZj4Ke6AYEBg55Sj4GgeWdcHQJJCEhe4O4AM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202056; c=relaxed/simple; bh=vL1GTbSKQ5S+0iYmLgnrX0ISDLezNcz2LNIEztFx1f0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PT5Hn7TbFrzWOtVZrxURyaC1cpnQmVqkAq++CRbWiKpkdCOggc00eYLCmD3q3QxgUGDJAWCM1YBIqCIQifET7fYcC+H4w4vko+NLSr9QBQYReMNELmzTzzyhJFS44szjM3xPWl63sdkACBdCG9WPvADy5iam5gsv7zPSE0zPx5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AZ6QnR9v; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=iMAq6k5K; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AZ6QnR9v"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="iMAq6k5K" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6xsSoTwiRNz90vOYxeUhQK/ys9WcE9kZjrgtjE9tN3g=; b=AZ6QnR9vJCSGgE6+X8sGPTG4v0tY5MiVck8jzkIO/KCtucnArmqUiryyooUT89M2qlNRP5 J9MB9fvUyM5HGzVkxBnW/M/y6PjlDXxcJxV1fn76YWAu5mqjdq9HFQn86CbMw7U7ZOVinN heBgwzBLNNdDzvV2AQIaQ0pppoROEdA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-yd6hnuR0P1eWZzbsrPE5SA-1; Tue, 19 May 2026 10:47:33 -0400 X-MC-Unique: yd6hnuR0P1eWZzbsrPE5SA-1 X-Mimecast-MFC-AGG-ID: yd6hnuR0P1eWZzbsrPE5SA_1779202051 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-45e7c7289c3so2137473f8f.1 for ; Tue, 19 May 2026 07:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202050; x=1779806850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6xsSoTwiRNz90vOYxeUhQK/ys9WcE9kZjrgtjE9tN3g=; b=iMAq6k5K3U5gKmz5CEbJ8zoCGd4+02UPygSFDoqgke1KXZkUK9+m9/0kj6coFU1rzA FSExmFubb/7cCvIHpSjoqqX7PPu/wc/mMvI6H+Tc+Re+D+ov/+9nsbe7i/McDYKWC8xb 7FhxFl3oy1yPIPehJ8Dlfjc0pwxX2cNmQZ+cWxhLf5lKl05jpf9JGHnZz6FCF3HMyDAq 6AvVVzxCAZ0EJUxBDHr4ntzS28JbQThKdf8DbFfJ41VN32VWa/5z8TgYgRuujJZ9lteW 3zqHaH2jDXZjb6nKnC5MAafHERFpnEG0Omu9havekNxjPuHLQC/V25dDrj1rRXY+KVeu fRyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202050; x=1779806850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6xsSoTwiRNz90vOYxeUhQK/ys9WcE9kZjrgtjE9tN3g=; b=iOL3d3PpyPPGrTHHk0LJRtKWhmtNKOUaImgyyUxMH2mDVXQP2PoRA2vE/shU8SdD7Y oVDfnysZNzovE//jH1eB5k977Er3AfEXt+SBM7+bsk5nULNYH18eFN775lRjaCnJk8JD lvJ0Vl6QiYA948JjcedCunZOS8l9b1pa0pNG1oBYMqaDU47EQygyVE5oVWw69UHlAinj TtXnQHBj75QENqDWTbjM4Uq98VGJkja3WkfAjtg29c1nj5fllA2sediQDlmlk13C1YKu p7RIWNE3v/ddac64vQiD2EQYCzXL0KwgxT9qOnVH5OiAwgVkA8dxaHPe5xdruGZ8nFmH jPQQ== X-Gm-Message-State: AOJu0YxxxKqFoKORDE1Guvxcgqdz9Ytfx29yfMIddSzY8vonbiFUyN6C s57xF1D9Ob3UvisiGNn3b+AYg5wDyivYCpxn3k3pGw8WzkdsBZTpVRDaorctzKea+1cXQuC1wE5 EKDfTIKOvyvlD65E6lsz2vDtt+ULzi40uIWzfGKIio40OG/IaH6Z65Qu+CKVPB+Nweg7XlDGhFL 96wbrW/Bx6MJRL2cyykYAE6bMoZNT7RwqksQQTBZLSD1v14hw0 X-Gm-Gg: Acq92OEmmmAwLt/fToGGFqprq1acAoaa8s/9vVZzSBkoj+rWY+C+t2VGfZkjOEQkIxN T+ulOAB2BTkjfWevr9sLgH0V8M3VqRW6oIrjbUmXkwfSu2IIxmk+7BVvXZUNQfc5bF9PCHierdS dM7jJmWqBCPxqCyEREdPpox4jcNYsXfIgnx+7ItfE2+HUmC8j2DKaBqTtQ4nwW9/AZYHyrk6tla 6XTJaiOpxRKThb/7yh3pBqNGxZI0BzNQKZOXU9g9ktBd3zE692rahQEgowrsCaBsuWz7H8GhY6A zBr66KV8rhsR8znzg4zAI7MUutUmBgu+0P1O6DAnBrAFlhT7OhtM+bR1cYPUBGPmBErIzRLGZct DWHBVifab/mpeKMOMClrOdrZUYcb8bQVDf0f/sMfm1rqO5e4= X-Received: by 2002:a05:6000:160f:b0:45e:8a9c:608c with SMTP id ffacd0b85a97d-45e8a9c6144mr3198450f8f.2.1779202050188; Tue, 19 May 2026 07:47:30 -0700 (PDT) X-Received: by 2002:a05:6000:160f:b0:45e:8a9c:608c with SMTP id ffacd0b85a97d-45e8a9c6144mr3198381f8f.2.1779202049410; Tue, 19 May 2026 07:47:29 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9e768c4fsm46647759f8f.8.2026.05.19.07.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:28 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Andrzej Hajda , Andy Yan , Chris Morgan , Cristian Ciocaltea , Daniel Stone , David Airlie , Dmitry Baryshkov , Heiko Stuebner , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Neil Armstrong , Robert Foss , Sebastian Reichel , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 3/8] drm/bridge: dw-hdmi-qp: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:46:59 +0200 Message-ID: <20260519144712.1418302-4-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index 0dbb12743609..37d8292b6f7f 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -38,8 +38,6 @@ #define DDC_CI_ADDR 0x37 #define DDC_SEGMENT_ADDR 0x30 -#define HDMI14_MAX_TMDSCLK 340000000 - #define SCRAMB_POLL_DELAY_MS 3000 /* @@ -835,9 +833,9 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge, /* * TODO: when hdmi->no_hpd is 1 we must not support modes that * require scrambling, including every mode with a clock above - * HDMI14_MAX_TMDSCLK. + * DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3. */ - if (rate > HDMI14_MAX_TMDSCLK) { + if (rate > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) { dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate); return MODE_CLOCK_HIGH; } -- 2.54.0