From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F061409608 for ; Tue, 19 May 2026 14:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202066; cv=none; b=hwh6vuka9Jo0UWqhSPBPz59qPa3MpTSgDEopLDjuSx67zMkgdcP+5WbfkdxBYoGfo6e4fz3zBcCOBq+gfOBfagpwcCeP1IAmZoIc7KdkSrXNyA2mUwo5LqaOUlwYVPkytPgb9C6oGQJmacvcQTGS/s5Lk8qpGuZQsyeskEO1xN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202066; c=relaxed/simple; bh=Zx2pQ/iF45ZSuo8/R4kpLZOJ9t4SmC/C+PyvOGFsAu4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hrHn71Mb5mDtGZRDkEmP7Cu0PGEtRP6K1TtN16AVTYHPWcj7JpEJ+sl3/U2hNy6l61feyg1InnSA1KONGPD1Vxycre6SX3tqpK4xl9TNILJWkqWa7BaacQ+gd3NNuCQKYXKccORlUZysdhfT6xYuC/H/Kg0O810Sj02ZxXQmUW8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=b5U41oAB; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=jg/1dFmG; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="b5U41oAB"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="jg/1dFmG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xGU7tCe8cxmqo3dopXR3nMSFVicCg4pj3EDoOkKJvvo=; b=b5U41oABvKEXDnhphgZ8Ia6yNZn8xymKodWLid1TGugZ2RPI6MEdIKGd2vSbdxvWGOrTqX ykLSnp9h5u5sqhXCS0rn+8rJX0lb7UnCcfiVsrG44BDIfhfz1YbqhCm/xvgftglFFIRK/X BtkWQnmWt6Csct3CSa07IsskFwL8+DE= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-aaj3UMLXOy6Q8GXoNjBsvg-1; Tue, 19 May 2026 10:47:37 -0400 X-MC-Unique: aaj3UMLXOy6Q8GXoNjBsvg-1 X-Mimecast-MFC-AGG-ID: aaj3UMLXOy6Q8GXoNjBsvg_1779202054 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43d789cebcfso3137534f8f.1 for ; Tue, 19 May 2026 07:47:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202054; x=1779806854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xGU7tCe8cxmqo3dopXR3nMSFVicCg4pj3EDoOkKJvvo=; b=jg/1dFmGBkXI8jsfrAWGGXG/CuVcHXkWAjfYfoq/82VACOSMeXlLiKYDssugd3zViG uVTqa9mfZZ2ReZ41X8IULZQv89IdGFre2rKkPqJJQWGq3XKtDdZdlg1O65QcXlZIR9cy bxj5UewITCaIXl78vd/Z68iQP31NENf8SwI0LxLfwxF1hDkl5ASIxFqHw2f/U747KJjY gjfZlxvlkxhr1lLNMTCyDI6pJlExr0caHeXNEk5MFa06RmN40UWSwnhGHRMM3m8jQNHs +NflwxgU/uGWYNaVNTyVi5Fr1iOoDAY1fer4AShuKofwIIe8mh+fxAr6y5M2FDbnnqmT yrcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202054; x=1779806854; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xGU7tCe8cxmqo3dopXR3nMSFVicCg4pj3EDoOkKJvvo=; b=O0EYV4Gz0hocHTd5iW9mKEpKxUzABwzFXRZG776n7n92D9Z1g6PV3mm8JFhKfjYjtU 7SqcqXmVytwr6mCdhbD/1tOH+QT2uaSW1bmml34ixK4WuUk3NbUqAgNPoDTr2sbJgWts QFnhTRwxHZGgcupkbFvbYNUsDZVbLvrDHucNIfJ9o2zKMhHlfbbv0lJnLUS2GpWA7r6W rH1aEh/U6THti6ciu/AXMG8w/nqOecoRWcv4uAeLuge5xC4XGrZXxs1+4YAka4vSLo0p /emwAh2LSp4LAuxhLtDT2xMSWzPUnBqNdkejfq33P0kEuu6mSom9GNMGXgxvsj2HZmfo szQQ== X-Gm-Message-State: AOJu0Yyr6x/CGgYJhsQ/jmNAZGVknvlKuS5LstukiMjtHuOBj5VrkujO rZ1gwtH4xI9oZvt+rR2hsk5bCGEM3H0JlDwHU95VZG79xWaJJiHJ/o3VALnCn/9XhkDM9Fr031o 2FCWflQtrmaOHXTrZ8TixC7zwDrAZPYZo8uB6NRrrQvP/f3Yv3iRDGUQp7UsD4BCVJLFC/tkYb3 LxJWoTQs3wQWXnHQnFAS/HJ4oX6hRboTNC+Hkd0iXcRF/DdQol X-Gm-Gg: Acq92OFIKoep3SiaoY2gep9XlCPRpzVYM18hG/xK8hJ2ByF0XVjsdVGBymPFrEaJGhA jlLnoWi0txFV+dE6oXXs8W8nH7Nc1pE9FA63NiAf23WFLEibv+VRNnuyUNDS/3zmGGks2jsCGOU anta3rPWgXCZcM83UyUwfAhcMzFI1uptCfhobH43yTD5RjX62U3PkwGK38RCrbnecH/kP53Yp1r NsWDGaf/705QlfyJjZYuIVxlgdF11r1z6sHKZ9YFCWI5XzaAYm6ar/mWignvmJDV75nJlGCy5wF yO1JGDXM6DfKYP506dmq4t/yWwI+0ZeeXLtqMb9chmRG6wXJJzEnZLkHf8CGGC+gibVGNo3iqkw LCFZhtue4Jp4PSYkh2i9Gyr9Xekn9wKszJU+LIkBUh2kGp00= X-Received: by 2002:a05:600c:4851:b0:48a:79d8:a8d6 with SMTP id 5b1f17b1804b1-48feea99dc7mr161602735e9.7.1779202053778; Tue, 19 May 2026 07:47:33 -0700 (PDT) X-Received: by 2002:a05:600c:4851:b0:48a:79d8:a8d6 with SMTP id 5b1f17b1804b1-48feea99dc7mr161602515e9.7.1779202053300; Tue, 19 May 2026 07:47:33 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fffb9aac4sm399895345e9.9.2026.05.19.07.47.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:32 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Alain Volmat , David Airlie , Maarten Lankhorst , Raphael Gallais-Pou , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 5/8] drm/sti: hdmi: Use the common TMDS char rate constants Date: Tue, 19 May 2026 16:47:01 +0200 Message-ID: <20260519144712.1418302-6-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the 340000000 and 165000000 magic numbers with the shared constants defined in the header. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c b/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c index d25ecd4f4b67..1c5a54cb999a 100644 --- a/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c +++ b/drivers/gpu/drm/sti/sti_hdmi_tx3g4c28phy.c @@ -4,6 +4,7 @@ * Author: Vincent Abriou for STMicroelectronics. */ +#include #include #include "sti_hdmi_tx3g4c28phy.h" @@ -102,7 +103,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi *hdmi) tmdsck = ckpxpll; pllctrl |= 40 << PLL_CFG_NDIV_SHIFT; - if (tmdsck > 340000000) { + if (tmdsck > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3) { DRM_ERROR("output TMDS clock (%d) out of range\n", tmdsck); goto err; } @@ -135,7 +136,7 @@ static bool sti_hdmi_tx3g4c28phy_start(struct sti_hdmi *hdmi) HDMI_SRZ_CFG_EN_BIASRES_DETECTION | HDMI_SRZ_CFG_EN_SINK_TERM_DETECTION); - if (tmdsck > 165000000) + if (tmdsck > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0) val |= HDMI_SRZ_CFG_EN_SRC_TERMINATION; /* -- 2.54.0