From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 307F0348C5C for ; Tue, 19 May 2026 14:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202062; cv=none; b=oGet8Ddj7G8LBSVcv4sM/Lh9CbcoxFeCrIwgLwZuCG7XZ8mJJg9U2CByM5kTwmxCT3nCBEmSplcZg4UgM49P2vcZ0msf6xChDhe/TiUBTydErrfjcnVFNMs7bgOViaOANknoU2U0Q6lPVYhw5LpHaUPSu3bTxPlzuMA7CVBt754= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779202062; c=relaxed/simple; bh=tYLDZyLDMsiJnrQuLxzYP38x7kZlanYxzwgaiO61vVw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OAeRuZl0qhO3NVFoZPWnOgJUpkXX2fSnvcpXr/a7WIdFrqxT/xV7GSp6xScLz437VtXQZnRn6XZRFxDdwP1XW/7SOYldD1WP/WOBRFD7fW2l1ouPloNi0xhpfgfJ6iblgWQE0CRu8lWUk/W/PifXU1g5qckmCPaehhRUwa7i2XA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=I9wivgt1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=sj2hoRGI; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="I9wivgt1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="sj2hoRGI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779202060; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZLSJynfj/SfMKra6MuoVzzg6ibW6tvdwMbY0XP2994w=; b=I9wivgt1zOT1erOrdUkCjet6AyESx+XKm9UZJfU1RLDGITf8IpKa+MJChwiUTsaY3rHUsW S6VcqQtIhSpWGIGWq7Z1gXR228pK2L6G+XZhV3zROK3i0IbsC4SXF7eFeW0ywSdXCgs9l/ IyJnO9hmMXqehogwJp7aXYja5D/aQL8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-198-NCsLrnVDPPWw1FPLdV-o1g-1; Tue, 19 May 2026 10:47:38 -0400 X-MC-Unique: NCsLrnVDPPWw1FPLdV-o1g-1 X-Mimecast-MFC-AGG-ID: NCsLrnVDPPWw1FPLdV-o1g_1779202057 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44d83e45febso3231583f8f.0 for ; Tue, 19 May 2026 07:47:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779202056; x=1779806856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZLSJynfj/SfMKra6MuoVzzg6ibW6tvdwMbY0XP2994w=; b=sj2hoRGIaWm9vIk0xtNMlDfIp6gyJjFcLFUQkQA5e/UNtB+YCU9qa//ix7wTwUcg3K S9m5kjT9q8VhahC8jE3qcyauqpRj1s+vW3TxXIGzsema0Stv8YQjnxpgKln7rTTHQ8Fv bzkPal3uEu6JvbeF11Q445LlbU0oeb78ynO9kIsjhBIyulEbwqW4Yhoh/7LKQdtoagFm /QDicNTwQQR5VLgY+nbAH/i5KOzJiwhc6ZHeGfI7NHAZh4OpL1cZdq3nCrCO4oKkXZAK pqgW7UghR9SVOm6Mj+ppzJvYX24okYmmRjJmVb7a2v3URPeqFgXp+cBtgf2ai7laG2iE oPgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779202056; x=1779806856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZLSJynfj/SfMKra6MuoVzzg6ibW6tvdwMbY0XP2994w=; b=amlID+D0NF2iktlSc9ekH+z8h58X2t4w9PWmHZHjl+cutB+CSzE7QV1lZSFSfWS++h 0KVYOpaZqExbXMYkAAwP8lH+ZD0Z6ZvpgMG2h2b6HavNZmjIOOtLrLuEBlb7YpSgsOCR 0NlAU4iQr6N5SPsKh/uTO+dWhYo+AV6b+aBhQDISAMdDEHHTO5r/TO5JG9e+rdwDrRjW uJtO5QmvdEKPBGdKzBjmz864ZZYd75kA9npJJ8aU9aTlwYZ5+eFVbPCYWZRo7oa3Yg65 2KmL9xk6FWyPnrMYKKvi+zguJHvKjLPUg6id0W3oWUBEMvTfIJH9FOqd3E7ePOH7lpyS tc6g== X-Gm-Message-State: AOJu0YyD8AtoD9qiVWCZli1W7mw10dke9t6/ZIwQ1kdrXD4l5R3Ei3V0 x6n2ZgOB0WYJOEDzWuL7E8F0CIYAlCc1jnUZkaWxghGpfO8iLsiEfJ0y1xWuIV0N82YzySWIqc4 lx/nlt2zu7hm2YGJUksHYnWcxhKHSTmmtxb7r1grxt1YLrB4TK/odqCgInGc6zzCrK5y+j9txEn 6cyx7daHSNpj+GrhxFryEsoRqcomE+0uv1B7HzMAGC+PKrpm7x X-Gm-Gg: Acq92OFV6uVcFyhcV/Ykm2sU0xSd+80uYVsiW1nXyGBDPKX0IrAEjPe8ixUtQ6QeA3D uv6eOFSxguFHNo0z9Mr2PxLRe6MoSIe24GSHNukeTa5ltbJdVIdK+ykHJ65so1B72Fo3jPZFi0v 1E919NZsgWT0etTWG0foSwbpEsEH2HtiRxzHO37lcTjYGHtBImvhp3H+50W21OM0F/e2LhCY9QS d2FXsq+yarLNP7u2ZaMRpDMivumpeW3SzDuXMk6KzjnWLpcqOYCKel+I5zlG6m9fSCURkHjuGxP bplafsCafp/x0rTSJ93cPPSsXAhpDliR9nyW3yA7grTtVdR4/1WnO0ELI/pRCwx0VvxkN11q8mI 1u5lTjsLjS09fVCyhhJuCmS2b95eJzDKvaou6GcAHGlvrPSQ= X-Received: by 2002:a5d:64c6:0:b0:446:708e:1e8d with SMTP id ffacd0b85a97d-45d955021f5mr37986718f8f.30.1779202056338; Tue, 19 May 2026 07:47:36 -0700 (PDT) X-Received: by 2002:a5d:64c6:0:b0:446:708e:1e8d with SMTP id ffacd0b85a97d-45d955021f5mr37986653f8f.30.1779202055797; Tue, 19 May 2026 07:47:35 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2f738sm45113118f8f.16.2026.05.19.07.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 07:47:34 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Chen-Yu Tsai , David Airlie , Jernej Skrabec , Maarten Lankhorst , Samuel Holland , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Date: Tue, 19 May 2026 16:47:02 +0200 Message-ID: <20260519144712.1418302-7-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519144712.1418302-1-javierm@redhat.com> References: <20260519144712.1418302-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the 165000000 magic number with the shared constant defined in the header. The old comment referenced "HDMI <= 1.2" but 165 MHz is actually the maximum TMDS character rate defined by the HDMI 1.0 spec. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 07e2afcb4f95..723a6a11c94e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -189,8 +189,8 @@ sun4i_hdmi_connector_clock_valid(const struct drm_connector *connector, if (mode->flags & DRM_MODE_FLAG_DBLCLK) return MODE_BAD; - /* 165 MHz is the typical max pixelclock frequency for HDMI <= 1.2 */ - if (clock > 165000000) + /* HDMI 1.0 max TMDS character rate */ + if (clock > DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0) return MODE_CLOCK_HIGH; rounded_rate = clk_round_rate(hdmi->tmds_clk, clock); -- 2.54.0