From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17A5C408010 for ; Tue, 19 May 2026 15:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779204465; cv=none; b=Lj1i5UCCj/EOiiI+ZpgvG4XaBvTNqwZTMZo/bS8AocUKGXl8iI/S3X7OaQP3wdzwN/5gcHbLfvWjUx7W5aHDxKn/WTR4kbTb0l9oGkbKxpzz1D/Idaul+IK2LUNhsXwtDEkdrZYIf9bXutEzL72Y0n43QVK31qU+YSERvTHkbMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779204465; c=relaxed/simple; bh=uW4Yk0igRBmfLaBkig6+ozw+XI5e0m0/JIVGZ2INarE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZpO9ZScOuQSuLwkr77Iuv5VnrD3BURYsiXa9DFF9dGjto/ClvOyLafqFiXCtHYYOMxwzYvU/tL4c4tiVaNXAs4kFHWMLGmjgoKxc3xSGqffBgKo9ijNGlS73A003Xy3EXGY8aelTcky+2QmYtT0fqzbnyi7bhpMmCW9157yVClc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=e4/A9DgA; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="e4/A9DgA" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-910bb291688so461073085a.1 for ; Tue, 19 May 2026 08:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1779204463; x=1779809263; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Kt+hX5KDw0Kh9RBmOyjzabH+WBL9dObDUAkuMZR7Klg=; b=e4/A9DgAhgdmpn86dYUZvT6UlTRIYuuxWftI8xvUoI2lNAbWxrLPg7CVVUhlDS80VP FYCsgHMkTSx90VisyM9paq2SH78ErveY+jkOWxu5wNWcVMaOWpCiVYhF7ocaYoGWqm80 SOmi8ExuP6TSP0CwHjhN417PtR8YTXARAW72lLRhIgE5/MgAzD524g8E4mLe5zgABIwO Tvm0AILaqJmJhhrL+ImZ+x1FMY39r/+L04SQaHn+N6OBDHCowCPteteOpje169a5UE3l 5ds0iSZTxvbvqo15i9MDRBbVjgz2ImGtoA7HlWyVJs8n/DYhddwmgZwBkPkTTwyt+Bic iRLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779204463; x=1779809263; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kt+hX5KDw0Kh9RBmOyjzabH+WBL9dObDUAkuMZR7Klg=; b=oSa249mQ4MDHMgmvuMHlpX5LFLE5JnrCY6OWpm27kARMCcF44Ie/XLWUmjzdr2NlbM OATQldcgec/MuimVsTbk6nwjAJYNkno2wOrq1yThyl4u8WTGD+rkwOtLgBz5MXbIiSJI BN/T9a0iNhCefQ8mNmCsJTqe2B9yGaFfQmh6tGUFNsR6svj4nuTanIMy01FFoegNpSmn PkEjGwehZ3ewe3Gr/S9SOZYRuvwQof20jSb//6ds9FB9RswYuqb1GJXzdP4s4JOhB+Ll MfuWt33C7bcJuJWSOhZC9qxU5QhMuESx3GeDf5cOWl4OL3/xU8IyXmxAkzmoO4y+AFar xDIw== X-Forwarded-Encrypted: i=1; AFNElJ81stNXyYo2ATwv3hNtg7TlPPksY9RSoO7GHsvqsMTLjaLq8Lkdo6iG8BdayO+RHWthCq+XVSwpsdHyXGI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7GOmzVD4wQ4+KB9z2CV+zdY3TIfUurGZ6lV3hcANJajNbpdB2 QX65CjvnATEBgRJ8VzfY8ePkdGcIMV41gOT4yVcbRvD8MPmwawqqy3E3JHR5tvvY/JM= X-Gm-Gg: Acq92OG9M5/ONMY6coySaCEcf25T2ZcMayoXAcip1Bh3f09n2S6U0eZgz26N325jziF 6xbgS069U4fjv+ByneSmCWT6e+hCs8JPrHZ5wo7GFaWB9hCGxhLXJwHSNdRtYnj+7lHZR/OqOD4 DGgopsDJkoOV9j2tggIrTBBPq/IgIRhhJjkJuxt4nFqrZk30EFkaItlxzXThowLVGzG29o83Pbq KHq5rcPrQAQegl4K93nB5fgSf9R3QsISZAfy0rLyew857rgae10AnqhfLNwlKQ/YPS0ewMsHC7J 75CCgT/teP0bnmZBpa2Br51vP0ote3QwRAMBszdu/aNpi4bsZnDGOjS/wOstBYnS4+7MB+mKzNG GocgWOjaSCnBV0wTMoRqE84LcQsSzVrv82FkAGJf7h5iQediLepi8I2+Ov1AVyZqPpkix8/kgD2 vsZsY6n1aO5PihA+wT7BRepPTCi3O2MTIH+UO1vu/YN/mPUqUhgyy+i2lSeCUI7j4xkIyNqsXKZ 3P3nOMAhYV5FGJ+ X-Received: by 2002:a05:620a:45a5:b0:912:671b:d098 with SMTP id af79cd13be357-912671bd4e8mr2727065785a.51.1779204462879; Tue, 19 May 2026 08:27:42 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910ba943761sm1881906785a.11.2026.05.19.08.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 08:27:42 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wPMM9-0000000FCKQ-2JCd; Tue, 19 May 2026 12:27:41 -0300 Date: Tue, 19 May 2026 12:27:41 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: Mostafa Saleh , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org Subject: Re: [PATCH v4 04/13] dma: swiotlb: track pool encryption state and honor DMA_ATTR_CC_SHARED Message-ID: <20260519152741.GM7702@ziepe.ca> References: <20260512090408.794195-5-aneesh.kumar@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 19, 2026 at 08:37:54PM +0530, Aneesh Kumar K.V wrote: > if we get force_dma_unencrypted(dev) correct, we won't need the above. > > for dma_direct_alloc and dma_direct_alloc_pages() we have > > if (force_dma_unencrypted(dev)) > attrs |= DMA_ATTR_CC_SHARED; > > > for dma_direct_map_phys(), if we have swiotlb bouncing forced, > > swiotlb_tbl_map_single(): > > if ((attrs & DMA_ATTR_CC_SHARED) || force_dma_unencrypted(dev)) > require_decrypted = true; IMHO I really do prefer the DMA_ATTR_CC_SHARED flows closer to the thing that did the decryption. While the above is possibly sound it is very obtuse to be guessing what kind of memory swiotlb decided to return.. Can we pass a pointer to the attrs into the swiotlb stuff and it can update it based on the kind of memory it has allocated? Jason