From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A2893EA971 for ; Tue, 19 May 2026 15:48:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779205718; cv=none; b=q+knMl6TZmH8xIfZHFX/BP74T4VKvvN5wZQffpgTCqPNY+MjyBBLCLfOLOgcIIGJa4aBEy7E5kdsfKOUwbEMJxzvWL32QejOnmfXKF9VW6kyuKEahpO7aiAwrzF0lphwFuSVoEdlEPRwBUlN2fXNnSPJIY4f8ZpBBJMLY6owQk4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779205718; c=relaxed/simple; bh=bwOkJU0hnzX7eZuulcdJN5TxwGn87n1uT6RolVHjgnM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rU0BU4zow+3XyI69wB+vmhmsCoVfkqFHTlVqIjmymEV9r/jmD4vr21HsWwVt6IIsyWhsl5g1rzwGmGASFxXJRcfr5oJvr93SxU0xz79LfiB2Lrm1bhpZMtztAnDjEiH8kZMNnewCy3MiIEZsPa4eMShyj6pbELyHDGzixnc7i1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=TCR4OoER; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="TCR4OoER" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB7F51682; Tue, 19 May 2026 08:48:30 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id F150B3F632; Tue, 19 May 2026 08:48:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1779205716; bh=bwOkJU0hnzX7eZuulcdJN5TxwGn87n1uT6RolVHjgnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TCR4OoERchKUwcQGKuiGnSy5kp0V0gww6einTudegkBQAbHfO37lzQAmDmu1zAUST 82ba85U5HhgA6TM49s/YHQ1YWIjePdKwLRdHGs8AvmWUw/+p1Ka4S2fAzmtoT0TBSU 61usk64Bx3XzdCgFBPIBd9dWDlLWftMnhk+X3A0Q= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v7 07/13] coresight: etm4x: fix leaked trace id Date: Tue, 19 May 2026 16:48:06 +0100 Message-Id: <20260519154812.254884-8-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260519154812.254884-1-yeoreum.yun@arm.com> References: <20260519154812.254884-1-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(), the trace ID may be leaked because it is not released. To address this, call etm4_release_trace_id() when etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(). Fixes: 7ebd0ec6cf94 ("coresight: configfs: Allow configfs to activate configuration") Reviewed-by: Jie Gan Reviewed-by: Leo Yan Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index 7783c97b53e8..9b477b36b432 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -929,8 +929,10 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa cscfg_config_sysfs_get_active_cfg(&cfg_hash, &preset); if (cfg_hash) { ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset); - if (ret) + if (ret) { + etm4_release_trace_id(drvdata); return ret; + } } raw_spin_lock(&drvdata->spinlock); -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}