From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f53.google.com (mail-yx1-f53.google.com [74.125.224.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3F8F34040F for ; Tue, 19 May 2026 16:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779207084; cv=none; b=URQMdNafx82QuYqz3IIxyWmL4xxSgHw4oVvqVqISQvUd5cbEmzWQgl3rKox0nK9LN9i2PX8u11+gVAVcHSQa2mj/RFRRp0ad0lgEKSfLHnyD9Iq3gsiy6smkjF765jOo1AX/WJFeOp56FuIbX/X59aE5KMPXXaxnJp58DQBH7tc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779207084; c=relaxed/simple; bh=Hz7s4YAFSInfsBqTFwj3w4O7Cn5r1Vqd8t9F59UC66Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iqNbI7rSHHgw7g415Sb0nX3p1X7aWnPcrC0EkZqyP/OQ4d/7LFc53EyE6iXa0xqxphWGkWgpzmCkFpL2abD5zEIcZXj3QcFaeaDGL4nmRpYfHbY6Y/4WRM3+0SbYLG07AnJw8WcuL//jMokjFO4yWOgMewUTUkMB8tZdtyepoto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=b6JIM2AN; arc=none smtp.client-ip=74.125.224.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="b6JIM2AN" Received: by mail-yx1-f53.google.com with SMTP id 956f58d0204a3-65c21049dafso3319131d50.2 for ; Tue, 19 May 2026 09:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1779207082; x=1779811882; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UcSuL4+fBcC8SeCa+tlTSs00pii8MZZ+rCZs+NXP3JM=; b=b6JIM2ANdBPVbb1/ra5qBtOaSj5JxN3N9C1jue518JwHCpPKYkVuFqkU7obTypbAt4 z8n13ceecy4hLBHsZ3LI7sCZrdY1FN7KDTsFPEXawdwl999mp3KmWh4NZpRNxk/j+0Uk vrGEjeuZIXD+rXoDi+bqP5zRCQQpG6PswaoSWSZIbZ+Ia9408qnX5kudVOwloaj75zcw E6cghLKyo9RWM0Ea42k102t2jsrl8qQAU5PQCjCz0k8QeBGsc/etDtHQEVpYONuplODl by60W7Zb0yyj2SAt6ZLzrhVnont3BI2MfYYtm17Y3tTmNmoPWdm9nApX6xFLzTgLtreB yV7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779207082; x=1779811882; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UcSuL4+fBcC8SeCa+tlTSs00pii8MZZ+rCZs+NXP3JM=; b=EiTldmWVlGbWSbumelzd4travE9QXU8nb85Uqu1tmUvydMJVWY2dxQS2Ng5Qz7ho1O F3ni49Slb01zUttgPzK4VdTaxDeD8NRO66S12Mfnzpmf966nKKXSMC2CJnsd1aI0umhI jB66oEhmk6fe9/80icmxM6lyOej20dtE7Z3HLSno6AI34wYqN/tUuGCUy4DJHNRyLLzD LjJ/kG2jMrLElh84FxELr0YATEJA4n4KWCxCNtw4yPJNNfLEj7M6Gt2ziA7KnFbh/Wwx JZS7WHa5151H6+XDVxBRlIoiquPpq8RDsj+xLYB7F9nMVWTl9np4hqLRtL9ZOKWpVogc xj5Q== X-Forwarded-Encrypted: i=1; AFNElJ+NULZ7ABSL5fFn2lXXxnKxwwNB94j5m3YSBgZy+t4fjC6VUObvaDDYlSpbKFa4/sidtUzCKupWsQNx2G8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0v7W4t19VN02TRbRolhJLExlfc68AUimTwsIza80gqG8XwgO6 HvnUYfuNKE5q/lqXJo6nBMqVru7C3DNIUPRrPhmvCL+h5ALHE0VC05++fnkXx+SJfPA= X-Gm-Gg: Acq92OFKgr2SaRKsb7eBCy4ViJC7pX7TKx4lWKvu2wiuS/z2Naf5ICY7hIUxHeyt79a pa8ixA1SUYnN1rVpceiQzsbxE+2EyP0SzCrHT5qrWt1G3klbCxagjBeUuvVuW0BpKKx8669oBoB SBKNcN4EOG2CafRSN0h+HaiHaiXa6XPUD58TKEL2BUYB1fXEIO1Y5m/avKdoun2BWtyEqTYpVNs W7fBDzu5TyDhBBvmOiI7ZysXYM5ypI8x9MksNEPLHy9p2SJhcaUtcBx0N2Fz2/8QlZqcLPOOV2o 83pDZxwRdckf1D8koBuWh1ZpTf1hJxj/ailmXNsOnSGndGQcJtheZk6IKDgtEg8e8aKuKDqY/dQ bQWAsgTXwr8VTvcvYJ1QC0xhfs+K2Mawe2zP1z1Zoep6aN418f887InYk1XwRhrS2Jflt6FDHu6 upuawIyEcFHogDMOxz5GZ9DO2xPUFc8449XaaU2uyVPIV7CoB/vm63uc0BbBUbtB/hArgB0+j/9 rV0MQ== X-Received: by 2002:a05:690e:148b:b0:65e:18a4:3021 with SMTP id 956f58d0204a3-65e22839e72mr21408719d50.52.1779207081601; Tue, 19 May 2026 09:11:21 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ca36086a61sm95500586d6.4.2026.05.19.09.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 09:11:20 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wPN2O-0000000FGo6-1YPM; Tue, 19 May 2026 13:11:20 -0300 Date: Tue, 19 May 2026 13:11:20 -0300 From: Jason Gunthorpe To: "Aneesh Kumar K.V" Cc: Mostafa Saleh , iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, Robin Murphy , Marek Szyprowski , Will Deacon , Marc Zyngier , Steven Price , Suzuki K Poulose , Catalin Marinas , Jiri Pirko , Petr Tesarik , Alexey Kardashevskiy , Dan Williams , Xu Yilun , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , x86@kernel.org Subject: Re: [PATCH v4 04/13] dma: swiotlb: track pool encryption state and honor DMA_ATTR_CC_SHARED Message-ID: <20260519161120.GO7702@ziepe.ca> References: <20260519152741.GM7702@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, May 19, 2026 at 09:35:30PM +0530, Aneesh Kumar K.V wrote: > Yes, that also resulted in simpler and cleaner code. > > swiotlb_tbl_map_single > /* > * If the physical address is encrypted but the device requires > * decrypted DMA, use a decrypted io_tlb_mem and update the > * attributes so the caller knows that a decrypted io_tlb_mem > * was used. > */ > if (!(*attrs & DMA_ATTR_CC_SHARED) && force_dma_unencrypted(dev)) > *attrs |= DMA_ATTR_CC_SHARED; > > if (mem->unencrypted != !!(*attrs & DMA_ATTR_CC_SHARED)) > return (phys_addr_t)DMA_MAPPING_ERROR; Yeah, exactly that is so much clearer now that the mem->unecrypted is tied directly. That logic is reversed though, the incoming ATTR_CC doesn't matter for swiotlb, that is just the source of the memcpy. /* swiotlb pool is incorrect for this device */ if (mem->unencrypted != force_dma_unencrypted(dev)) return (phys_addr_t)DMA_MAPPING_ERROR; /* Force attrs to match the kind of memory in the pool */ if (mem->unencrypted) *attrs |= DMA_ATTR_CC_SHARED; else *attrs &= ~DMA_ATTR_CC_SHARED; Attrs should be forced to whatever memory swiotlb selected. Jason