From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A59E48AE2B for ; Tue, 19 May 2026 17:15:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210948; cv=none; b=Yx8I127oziMIgmfd1RWtRZ71Si3i6mnTbvJChi2LmSu861M2z7kTIuoicvnZ6TsOtYTforx36IqzATlYiPxu9ruXMHtB3SNbKn2KzVQ5HcCMQLgR2i1WC6ieH1Uf6fS4neozCXIbrMa+wC91DsCwy7v0j12MMYJ+vaJyPgecLyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210948; c=relaxed/simple; bh=MCragVeqWGfwwLMtO1vbVTdRFf4q/FyUz9Na6DMFRdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RzmiarubGGJ7Ju7wyuXVxwGgQtichm06ZWX21BJTh6lytBEGK+EdMUPKKEuord2SO3KKdDgU01uELzvRxu1CB7KkqMkQi/IXHxtDoz4BXnLADFuhM9GvExBU0ZVktdyVsQlKX4tnYDBi2kBIjcKMRECQh+i9FvaI7ebjTr0IQhY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xma0Spst; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RyGFwMjC; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xma0Spst"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RyGFwMjC" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64JEwlfG1636897 for ; Tue, 19 May 2026 17:15:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=+J0UtrHxFLw 6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=Xma0SpstGs2h892VEZcl0EsuuZV /OqYjyqFPk5EsN1tTEe6H0kakTj+jmQgO3lCYMNONmC8kYpzM5xMuEN0u7EShU83 CI6qMr0xJcgadLKeTWFv3PWGy7qsl9PfA/ruVMmpUysdFwpYASBvyDi6Reo74v5J 7+wqZxXLgcZD1q0RdaY+fbsOckGdCj1WZ2GS3j/sUIYtL1OYoSd9lNE/tXS9fIiU fh2bzC0rSXnEnUkujFhzdi0oz2FguzqOK58lSDndmvaFmCWCPMc3UCs8/jXnUCv1 i7MOFHb7hPwq/Y2uzz1Zbj4rMQQxPSesZWuYhgTxjOyuD1zA0zCwaBksExQ== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e8t3s8nt1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 19 May 2026 17:15:43 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-835423c69ffso2047185b3a.1 for ; Tue, 19 May 2026 10:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779210942; x=1779815742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+J0UtrHxFLw6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=RyGFwMjCBbbDC5otKsyyGV7qvNxY1YK81VUEoJKdfVeIBmxdAPTEP9eTJO/yPcB5IN jnMg6Vxnb397197Qt04RcPvlCfRhgeBtbDMhdSWuZ/ZoB3/XGzloE41/zxcq35Uqlt6g as/9Jjyo6hJ/syBTNHTUXiDpZgZ1GriFSCZk1w52kH9zSPA1OomP0UDf26b1XvLNNjWU Q/WToghERbwyfVZZ17OgUPHS9LJnkrZLql2fOgR6aR2KHcp2RpeQ2ntNbNtooGa24b00 SCph2zZJTRyzq5VYkOt6oQc1ImwldoJg4Zf6Xl0bG5ezvvSiNwq9jaIb9wbGnYoLxBQ8 j1UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779210942; x=1779815742; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+J0UtrHxFLw6ZMOq5E+Alm1lz0ZEDn8wjg09ZAPN87Y=; b=IbHY+ymJLQr5QfP4qETLEegryyDJ6FqHfZKQeHsVVzqZ68sF0161Yn6bZq5Uw6JfC8 eurHDhl3uJKSWwXDu9b5bv6SEGsxpZ0Jo8SL5mcXUbyw1lPqURlY2p0G8oT5zU8ZcgLr p/SUX+sJUY1PElwKl8DuzO+cJvai5v/qS/SfpLtMv6fHtexRkLP32HanWDudeze1eqxg bj4X2S6bcQ61teRLel+/T7lkf/xpmc8JjIuH5cRtxkrOzvuPPp1vWPDwl8ZPX3645MLC Ab04Bmlc7vOKe+Vx6R6Dhg1iAfjNWzFhJHHM6n1zxY6+Z9ayydrJTlYrAKjTV7Au7Wok 0uAA== X-Forwarded-Encrypted: i=1; AFNElJ/iw07s7bZQfjwCJAU/7j5/LQtRTnMT2yrkV5zxS3JblaxfV2RoItSIHov7Z29JUq9lfu73QLhX0YAiZAU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzpeza28Y2vn7YOrZxWQyc/x+gUzO+daSiJYRtuE66gz9VQeaJ9 PNJezJCT1J3bu9ie6ECQkQesivczmJpy92skWcOx3S7IfTK1w+BdDI8DCRn1PmtfZyev8F7fJRb 6NxQrDQI63fbKGLl7G2nPkRjFZPyiuPVdlHT3YqXjIkeeJDADyG3Qc5hHGn0sZjhuivc= X-Gm-Gg: Acq92OEcR0gD3mz8IRinVYKl3MNgItOQyHmMiAr4wHY8tF5kBzHrNyEMQGQZN8Kvlai PEus6F38tfzz3C1fIlO0lbszXtes3SVmwXLRtzO+aratB9/xFP0TmsEP3jum0FwYCEvvYXM8Rtj W4SBWQiaL9FnowrmUKnmZSUY/nYVUiUVEbiJMKUfExRaj8L2d/I2cTNwYwMJQLnDeD6toF/139i ReXqZtJ2Qo6iYSDfd5F4w+eGP34rtwQ3IVh4pfC3jtWM6pSAYOpWoudp9tQD+b6x6OjO+lFug8b J7+woPwe7AmYR2glOZity5W37Cq41P2lu3YSFSbhbtDZ9aVc7qhWKcRrsEqEAYI05+bQsg9iktd iUZPscr59e8iPtYPNHNBeRUsBWk/9GcNzBJExlu1ITa/hiNMC X-Received: by 2002:a05:6a00:130f:b0:82f:abc8:ae0 with SMTP id d2e1a72fcca58-83f33b3385bmr20139496b3a.17.1779210942038; Tue, 19 May 2026 10:15:42 -0700 (PDT) X-Received: by 2002:a05:6a00:130f:b0:82f:abc8:ae0 with SMTP id d2e1a72fcca58-83f33b3385bmr20139371b3a.17.1779210940413; Tue, 19 May 2026 10:15:40 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19c77822sm18634720b3a.41.2026.05.19.10.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:15:40 -0700 (PDT) From: Mukesh Ojha To: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mukesh Ojha , Konrad Dybcio , Dmitry Baryshkov Subject: [PATCH v2 2/4] firmware: qcom: scm: use dev_err_probe() for dload address failure Date: Tue, 19 May 2026 22:44:40 +0530 Message-ID: <20260519171442.1582987-3-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> References: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE5MDE3MiBTYWx0ZWRfX6r1IH+OB71Ge uQooO+HkBHjm/RjCyaArT+wVSW/0oSo8ywdQ25j442J2ST+ghKo3xStikTTgtBNCXE0Lg8B/Vh/ +MO6eqBYP1EnxhtxMrm13GICmgWn8Shhgx1QUxzJ9SpRfVWkQMC10xW0ZoJlY6sSzrzfqAB26jX z+is4I5vOlkRoNaIL7UZlEL9wWuQ2y7ZzM1jIz3hhXTWf9qGp3n9oh904o43JlXFu0hHWOBFwR1 n0KyjReTC8feId4lNT7iB4ZlTw8Sy44gc68LNRDvl2ZCaIIqFPbkBH068a7hLOqWHKSX4hNvfhP EGE8rOp3T7QbZdB8SzXwhLoly7RDF+2AdlS84yTcSbx57TAIFqeByzSPR2jdvqbTHhhlrpjuu/q X/r+B2wH+GwIs24Q1SurDVxlukJ6BJ5WfguON1pYxaMlEyhjr5vyb4U5R4Vza8m7HI1gxbKNb8m x/2lc4KKW9d+9DraRig== X-Authority-Analysis: v=2.4 cv=Oc6oyBTY c=1 sm=1 tr=0 ts=6a0c9abf cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=GEQWD5Nhug1BhVu3dP8A:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: cU029KtUb7GXJMyANoMkbRR93pz8TVSr X-Proofpoint-ORIG-GUID: cU029KtUb7GXJMyANoMkbRR93pz8TVSr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-19_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 clxscore=1015 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605190172 Replace the bare `return ret` after qcom_scm_find_dload_address() with dev_err_probe() to produce a consistent, deferred-probe-aware error message when the download-mode address cannot be resolved. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Mukesh Ojha --- drivers/firmware/qcom/qcom_scm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c index 9b06a69d3a6d..52432469badc 100644 --- a/drivers/firmware/qcom/qcom_scm.c +++ b/drivers/firmware/qcom/qcom_scm.c @@ -2747,7 +2747,8 @@ static int qcom_scm_probe(struct platform_device *pdev) scm->dev = &pdev->dev; ret = qcom_scm_find_dload_address(&pdev->dev, &scm->dload_mode_addr); if (ret < 0) - return ret; + return dev_err_probe(&pdev->dev, ret, + "Failed to get download mode address\n"); mutex_init(&scm->scm_bw_lock); -- 2.53.0