From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C2673FC5BC for ; Tue, 19 May 2026 17:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210837; cv=none; b=r4K66H86O50g/q1f8LO7SqxtX0B8sAi13WfQvMHbeHZOhLjkGLD35DINn/bV8/IVhkWbDlyJfd9l2hb/q9VAg+xp8gKISeX8MsAfBsXGJHZwxV8qr40y6T48H9mr77grD2jwwo1AFeTbRFvZ8NyQOL5zZKVjanZ/UBYJLvbaMHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779210837; c=relaxed/simple; bh=hdghGDABYJZ7ehSJGpw06biVtJ0Re2YwfqESD4NDfqQ=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hMmrA/r8emsYziXlMj7uVbM75ynBryLVb+FdC43GO4i8P1SA0OsU/caLg96XEQC98QwFpwT7AuRP9NWuDs6WxnpuOnwSlvCSH5I0BtYqjkCUt1/hXU1+yQpxt66PyobrdAiYxD68XEqLN/5hISFecWJU1hoH4/87Vdau4Eb2Ex0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A54TsmB9; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A54TsmB9" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488af9fdaa7so19092605e9.1 for ; Tue, 19 May 2026 10:13:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779210831; x=1779815631; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YF0Gc/aWd6ni0YZ6OLz7XyAixJB1h3NVnu0bnzDB350=; b=A54TsmB9YMJoCSZm3OzylrlETZRF14saqRfkLBmx7xwkTfep/i2QetZ0EwaI4qcay9 PcAJ1NcJc1krQMFL6e/45pxlf1GiBHAm7891I1y9iKJZWysDtyo6qWkQMlbHYW0RFPo2 PhJpBODfP4LkeQ16g73mV8dWNfSI4q+y98Y1aTuogF2EANZXhlnig91o99fGTFx54Fcd Cwu9f2QMxii2YWjkyp2TxGOtSagMqo1a07ohbGQdf89CezLaRmg6Puo2fSiyOF+AjjFS 1tFMg4rYwPoLiz8Al1WdrVdCjpsJfPWj5F+NTqHFClz35/ya3koWK2+RmjsxNal+J/s0 6Wxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779210831; x=1779815631; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YF0Gc/aWd6ni0YZ6OLz7XyAixJB1h3NVnu0bnzDB350=; b=NVvsgQ0I+Cq2XQA4adOzmtzMW1pbrD/0jVX6fFlwL6tMFRuNuAdxMrP8D8g8CV4WKx /ulXVQZlzPFA1qRleeK6aNHosuha5DzaLmxIxbrxLuyDr2P2o1bkug7GsmzsIkGktaiN MnLMG/buk0zJyA2BfmAj+zDTJJIyNRUArF051AkBJpAl2EISeQoaYJnw+FxxpDoAjqgm Ml2NSJhp9UX9DlPzPWIhU0cV7bMgw0RBMzmnwst0Adz+8dNUiNkfJpN+8Dp+Kk7hGocR Z79NUNFRTbaUKsba92aj1Pe7gogpwBvNSRMezifn4jCY2fQTDWYR+y052d+hhF3hg1Di kWKA== X-Forwarded-Encrypted: i=1; AFNElJ/IcnWF83Eq00Yq1+1ZYwBzDICepHtnUi9iSBADygIWRBZ7L9ITI/zGE/QFHq1o9bvRlWwehh3R8d++njs=@vger.kernel.org X-Gm-Message-State: AOJu0YxMS5mlSaahtfH1QjwK0av+5wko5QPxukxtAKOFlDUVGzsbhKak Ctq7b1+E9DYba2wmCuJw/9/7rymYQylXoxrcB/wclowOklq4cWeggsZf X-Gm-Gg: Acq92OHUMdjsEdIxx74B5NRkpJd3XdKAi1bHGlNzRZd15oolFCdaUUU2A1Nb4h3F3+E 2giaLJ/yRCOwT1M1gc4A+4JKXAkt3RJGwCjzO3E6S8glswiWRYuSfANwp4CcoR6QD3PmwfFLOMg NkoS77uxzD/fLg7siJejjgHnZZ7WnmN7bxvxCvb+u3xK6DH/D7QujhDLeMVyNlXwcfV+jwjPhqK VbHErH18AIjR2jdD6fK54pwJ+Laz+/096cfu3rIJJDALbyndywqlEv5dhqJSmeyDlRPXek/W4Z9 JhM9D43ek3VJj3Q6HOQv6MJRmbiTHPWmwkun3iCkJCuXaHYpgJY/OsU2sZ72KuSq3Kw/Aqgctq0 sv/wd5iQYX6wbFGV2q9Hpnu3tz/YAjyaqaXHMBS8npMnVqgF1YuPAWv29+sGMCAp201dEUhWjmX ZHPuW//aFXAH8P2fOO6/Js8cyViEkJzVtHIkLcRrxfrBXj4JHAGGrNKCYVTYcSnoXQ X-Received: by 2002:a05:600c:4fd4:b0:48a:581c:ead with SMTP id 5b1f17b1804b1-48fe60ed7b7mr287651375e9.10.1779210830786; Tue, 19 May 2026 10:13:50 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45e7c22d8b7sm17989013f8f.6.2026.05.19.10.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:13:50 -0700 (PDT) Date: Tue, 19 May 2026 18:13:48 +0100 From: David Laight To: Mark Brown Cc: Chin-Ting Kuo , clg@kaod.org, joel@jms.id.au, andrew@codeconstruct.com.au, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, BMC-SW@aspeedtech.com, kernel test robot Subject: Re: [PATCH] spi: aspeed: Replace VLA parameter with flat pointer in calibration helper Message-ID: <20260519181348.777f7dc5@pumpkin> In-Reply-To: <659a6593-0223-4a26-830b-1390326b84e5@sirena.org.uk> References: <20260518095708.2502537-1-chin-ting_kuo@aspeedtech.com> <20260518095708.2502537-3-chin-ting_kuo@aspeedtech.com> <659a6593-0223-4a26-830b-1390326b84e5@sirena.org.uk> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 19 May 2026 12:03:51 +0100 Mark Brown wrote: > On Mon, May 18, 2026 at 05:57:08PM +0800, Chin-Ting Kuo wrote: > > > - while (k < cols && buf[i][k]) > > + while (k < cols && buf[i * cols + k]) > > This really needs () to make it clear what's going on; the precedence is > well defined but not everyone is going to know that off the top of their > head. Come on, it's multiply and add - everyone is going to get that right. -- David