From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D470136920D for ; Tue, 19 May 2026 18:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779216012; cv=none; b=cW+nO+oRKH96cinJTVQihaidNl+1vU1K4kA+im49UPisIeN8d7s7Ski+3DxEnk1VRucuXNFYuoUSMJzHgnJRi4UzimbXs2JK0QfEx57/F1Ec6HvHOW87XAZKn6WavTx/QlXPEdO9VQ3hWSSkLZe1WPoSQHBRqmoCxAlz199yV5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779216012; c=relaxed/simple; bh=d6rzr2YNGuS8x54Z2sIdFn40QZMIPF2jgLkO+AUn4eM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=By0BQBsWVDfucYcMWmOSf1yuGtgGsYyed5YrjIGWeHXV5WrO1GoeTciAqTf1QKuBokpzT00kO/7iLKo1FRLVQ1sTjGrQaifAlobKJEWoyF12v8ofyxx8YLMh4Njwr+gbe4thv9fS3yhDV+Up1GG4i+O8AQHgdAq4AEoTyPwVmfY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gotHQicx; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gotHQicx" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4889d0a9df0so3435765e9.3 for ; Tue, 19 May 2026 11:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779216009; x=1779820809; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gZRR5GiYso+3hYJHzSyklERXVlkOlpiy70ZAvGBjBOs=; b=gotHQicxlqdA3pVAa75UoI0q4IzP8xjyK5xqO8HvA++pfO3Vh8J+1sqRz1tbnKc1JL EX3edMTlO+ddOX7mgBOZtxh5iAOJvWtKcVF+IDHzuL6ZLQBdNIZ4FyANJX/gAyhPFpXE hCCEwlZCx+wZqu2kHsUFug7EtcSNv1Mdcf9QVAbFank0UD1yaCmg4tf6G5WNQ50Su6jo 7ZlM27OFZhQm3hfWAotyry6Jix29+r9rooUXHcyuNqeMTtoVNgL9oYzLONfLj2kDcPZV ro5xDIrCLkmJ9h/VnekfU72jSpqbkYnI53mUHoL9ftFg8f+5tttF8ustaoWPdtvxslM4 qRYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779216009; x=1779820809; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gZRR5GiYso+3hYJHzSyklERXVlkOlpiy70ZAvGBjBOs=; b=eykT65ey82kp+FXU5BBarWE3AvuaM2QAR9dxDqHMGRiYBYNXc0C5EPVUNXHZQMyh7t CjbcAuvzmWoc3y5QfCVDeQ6VmnCLfQ1y0UjPBqkUbdCAg6AxvX2aQ81WbTe3Ne4noa8S Tq8hM/QqJh7u2wdZQDU9fXngbOETr8SGwcxg06bLOe4Pa6XeXxE1BL9hzV5qtWhXf+y4 hSK+txaXnfpUjMhk2DYwnxI0htBq1sCxUctsf1YMZ8qCF/hs7am1sRkkEoUlaCPuVDy5 OBnfv93jwZIRulEAxjnmlOu7O0Y1yXANfZGsK+lmsVPCCdf2Tv0Amn/f/Gsa9Eh3+0lt V3pg== X-Forwarded-Encrypted: i=1; AFNElJ9Ic5aDUWdN5YPsEn1kLZufBlyBll+u0XegccIVTwhYSb+xAC9EI5/efPkd7LSamWfq/8qKHutSCbPxboc=@vger.kernel.org X-Gm-Message-State: AOJu0YxrhSRXnsLQcUq+fGs1UXHQp4vtUBkCvQ6ra7v62snfgyyJOSXo minXiwafLy5LwuFl+T6iOmaQh9CxzgaY8U0BiRBcVAaLn6TaWqnGc9ou X-Gm-Gg: Acq92OE2xDhnT1p6ZO6U5dii2W8nU9UCwN0Jsw7RQy9n0+uKu6kUDSCZsVahs/HZZwO lCp4Fx67br+QWgvPWXJMndsEzGnN3CU+EKDFJNactXPYEmhtqjs2zBtzRqLbS3rYSl48M7ihydC 9klsln871IoYbVf9Xr+zqOkLUSIDgM54r4lzMgC9j3QlDFcGul14S3SOlWDNeHwZHbHfVDgzjt3 +l4T2/uhof1uMfh/4fepmB/f+NUrCvuSwsy1E9nGEkVyID4s3xuWlV/jpkmI5pNnUN+zFjCRJ3S iLyw9PUPMNhASulss4f+ft3sPtHkHv1meT1RbzXkFdPGg81QD9jRCIOQYoaWGS8shxSDVGoMqc5 ApfKxUULA9ULAjRUUiHUV/TtGoOPc0Q7cF5hDT1JI4RX6C6ReXSUhKXW+GPCx3KAuA6nPsUe+fJ jvFxN7Nzdv6jTTv9RwvxUvM5IYfA== X-Received: by 2002:a05:600c:3b07:b0:48e:6db5:76e6 with SMTP id 5b1f17b1804b1-48fe63099c6mr170280415e9.2.1779216009072; Tue, 19 May 2026 11:40:09 -0700 (PDT) Received: from skbuf ([2a02:2f04:d507:6e00:6547:d81d:b8f8:e501]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48feab26ed9sm164943905e9.2.2026.05.19.11.40.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 11:40:08 -0700 (PDT) Date: Tue, 19 May 2026 21:40:05 +0300 From: Vladimir Oltean To: Daniel Golle Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 5/5] net: dsa: mxl862xx: add SerDes ethtool statistics Message-ID: <20260519184005.cx32dtj6v6wosb3s@skbuf> References: <5e8391488f4dbf23133d16ceaf1b168b39304c97.1779203863.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5e8391488f4dbf23133d16ceaf1b168b39304c97.1779203863.git.daniel@makrotopia.org> On Tue, May 19, 2026 at 06:39:29PM +0100, Daniel Golle wrote: > +/* --- SerDes ethtool statistics --- */ > + > +static const char mxl862xx_serdes_stats[][ETH_GSTRING_LEN] = { > + "serdes_tx_main", > + "serdes_tx_pre", > + "serdes_tx_post", > + "serdes_tx_iboost", > + "serdes_tx_vboost", > + "serdes_tx_vboost_en", > + "serdes_rx_att", > + "serdes_rx_vga1", > + "serdes_rx_vga2", > + "serdes_rx_ctle_boost", > + "serdes_rx_ctle_pole", > + "serdes_rx_dfe_tap1", > + "serdes_rx_dfe_bypass", > + "serdes_rx_adapt_mode", > + "serdes_rx_adapt_sel", > + "serdes_rx_signal", > + "serdes_pma_link", > + "serdes_link_fault", > + "serdes_in_reset", > +}; Which of these are statistics counters, and which of _those_ are Ethernet-specific (SerDes may be multiprotocol, also supporting PCIe etc, and the info above is all protocol-agnostic)? I'm trying to hint at the fact that ethtool is not the right interface for presenting such information. Intuitively, I would suggest we need to put head to head various SerDes designs and present to Vinod Koul a netlink UAPI for monitoring purposes.