From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB203C1992 for ; Tue, 19 May 2026 20:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779223698; cv=none; b=ZEgdKCY5pkJDNDNTqMaCHot0wkkAYdIwmH52KmXKh+XbUmqUlnpcNKBXgZO89p+IMDoZzjglS9HNl22UMi9T4+g6s+qwzqhV0DKpMAGdGpCVTyrFOw/lPL1tiODewxuYwppyYg7wEDSfwgxqiUOrk0XZSX6Jk5UXmHsrsT4RG10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779223698; c=relaxed/simple; bh=O3NBvPUeMpkKMsuqGi/aIGTrfqSqyPDWVkpHE4DBwqY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BXcHR2Jh8oZ6AyMeH406sx+GSgURc+UazPFMoYlOqS5hXGs9CHG3o6Hwhq4GcBIQ1B75M8YIRxzdiApQ7RjqambROuaTSlxBtHYFkLCKkWLAfCCxffzI0aUubL+pduFZm18pa2PHyN/Q0+me589DJRMNtaBeEjtTm4LWcSpbncE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c6aoOH3k; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c6aoOH3k" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-44b7e8b65faso207718f8f.1 for ; Tue, 19 May 2026 13:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779223695; x=1779828495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QtVvthz/7+lTeRk4aPj5gp54GNbJ7oJJBTGPkd/6zCs=; b=c6aoOH3kh21sVql4+E1+PXdnUuadNOFbX/oMVU4esAupUtam7FLVOf1TmO/BLAuCtR BQKE77VfzeH+EaQtTHPeFCrxFjNrfgNnh6fajIQVttFnkkzeFJyb03U6fUFEZYMRIWjI IaqeW61qofvqRsx09/lup7alZ6xIGSJpVZPDCsjpHL4gxbTQ3WEZVUqYxJQ7GhkDiP+3 s1q/aE573wlSA49TXMYmxOxqZ5RyobH4GWEftUmc6MHOSzpnhQOaC4tDAlbFFmbpe98Q 51FR23nPHr3BYFTvAbgfsFNRnN5NMVw1mGHRkK4oHBiSV/PP3BJT7m1KRqRXoWT/8n5e MyhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779223695; x=1779828495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=QtVvthz/7+lTeRk4aPj5gp54GNbJ7oJJBTGPkd/6zCs=; b=IxE/dbAaDXhr4oWzyRFv1/BlrNCxNIxrIinyFZTFoFhetterTooaOrzcr7YJhtAdbY gwCCkE74CpUumsGa730AtAX/40n7VAweF8K3x2AiRClp2OKu1/MItBFWfg096k0KqeQG PZKZQp6G+Ip7ZIYGak+yE8hSbOi/JnKPUO51KICSkXmt74RCOyDFz109wDQThWIrq0tS jO3DHkgjswFtl6E6o5LTngmDVAR9l+OJ2aJiQuaKEBkju60eLyG7W1QEa1ImUbw9kaTl mrDpxUpnNKzIx1iZ7XPqowg+4RbCsog+Bx9Tpece+gqd2LwIxfhF67REU4/3sn6Ckk68 IENQ== X-Forwarded-Encrypted: i=1; AFNElJ+tEb5zLfsFAGe1R0sLYb4lZxhCFYpJC5yb+0RQuowlYrg139nHn2TvE8oVyJpnKKadci0G1fBO4uVDO0k=@vger.kernel.org X-Gm-Message-State: AOJu0YyAIHMog+C3waipqSvBO8Akb8o2a6s3hGO1IL5/J6OoYD3l5Tp1 A8a97NIlKvMgbEJB42tdpK0iygQYWOXcct0+mN/qw791hVcfY7MU0pFD X-Gm-Gg: Acq92OH2E+qSzelb/cIaKttH6tp5rmqM/tqevUySTQ/Wkoq7htN3zh91ucUogTSsz7h XUwdFRRS+AuTy3J5CB8gZ38+sFhaOOpu5SPShgJ3gxIjqcgDi+q9eHsV1saC9uHfNnhVbWWpJou QRDTpWksqPaXmUpZPqbhFGGFcHQE7qFeMeyHIG3eQ89NJv6B72RJGmfJ0zp//cMuvk0jCxTGmQO xgiwJikE2536/DPg+HIp+MffGODGmG7gbY9gr8AsxE4LlkKTrxxMivivyXyK80xW++puqKfVmbz wXfyEQ4tn7gXfnZZ3hOqSNkumxI1YtTEv3A8u94DRWEN48p9AMad5SwD3qUX6H4vBMQTOKFmKcI f9nLb7N0sY6KmA8PIUEKNLLMiNvmaByyza77fHZ/q4GBVamC5MutNYkO7o5a1rN9jyL4BGJqBRM xuS0/DHQJl+A/wVqvRNN/Ao3o0ovQE+68RCstjjuJ8d85XICg4m0yWI9JlCLXb5BagrRljdjpEA 9LgDN8H0xOU X-Received: by 2002:a05:600c:310f:b0:48e:7a10:1f5e with SMTP id 5b1f17b1804b1-48fe5fd5b3amr150010695e9.2.1779223695175; Tue, 19 May 2026 13:48:15 -0700 (PDT) Received: from menon.v.cablecom.net (84-74-0-139.dclient.hispeed.ch. [84.74.0.139]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe4dac000sm356457755e9.0.2026.05.19.13.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 13:48:14 -0700 (PDT) From: Lothar Rubusch To: thorsten.blum@linux.dev, herbert@gondor.apana.org.au, davem@davemloft.net, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev Cc: linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, l.rubusch@gmail.com Subject: [PATCH v2 06/12] crypto: atmel-i2c - introduce shared teardown helpers and fix queue flush Date: Tue, 19 May 2026 20:47:57 +0000 Message-Id: <20260519204803.17034-7-l.rubusch@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260519204803.17034-1-l.rubusch@gmail.com> References: <20260519204803.17034-1-l.rubusch@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduce atmel_i2c_deactivate_client() and atmel_i2c_unregister_client() helpers in the atmel-i2c core library to modularize client teardown. This encapsulates common client state tracking and list manipulation operations. Convert the ECC driver's error recovery and device removal paths to utilize these new helpers, ensuring consistent execution ordering when modifying device-readiness states and deleting linked-list nodes. Inside the unregistration helper, use list_empty_careful() to safely validate the membership state of the individual node before triggering list_del_init(). Additionally, migrate the atmel_i2c_flush_queue() call out of the module exit path. It now runs inside the core unregistration helper under the protection of the management spinlock. This configuration ensures the shared workqueue is only flushed when the global client list becomes completely empty, enabling proper scaling for multi-driver setups. Export both new tracking symbols via EXPORT_SYMBOL_GPL() to match the existing core driver licensing standard. Signed-off-by: Lothar Rubusch --- drivers/crypto/atmel-ecc.c | 13 +++---------- drivers/crypto/atmel-i2c.c | 22 ++++++++++++++++++++++ drivers/crypto/atmel-i2c.h | 3 +++ 3 files changed, 28 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c index 33b90667c872..29706e4bfa04 100644 --- a/drivers/crypto/atmel-ecc.c +++ b/drivers/crypto/atmel-ecc.c @@ -336,9 +336,7 @@ static int atmel_ecc_probe(struct i2c_client *client) if (atmel_ecc_kpp_refcnt == 0) { ret = crypto_register_kpp(&atmel_ecdh_nist_p256); if (ret) { - spin_lock(&atmel_i2c_mgmt.i2c_list_lock); - list_del(&i2c_priv->i2c_client_list_node); - spin_unlock(&atmel_i2c_mgmt.i2c_list_lock); + atmel_i2c_unregister_client(i2c_priv); dev_err(&client->dev, "%s alg registration failed\n", atmel_ecdh_nist_p256.base.cra_driver_name); @@ -363,9 +361,7 @@ static void atmel_ecc_remove(struct i2c_client *client) { struct atmel_i2c_client_priv *i2c_priv = i2c_get_clientdata(client); - spin_lock(&atmel_i2c_mgmt.i2c_list_lock); - i2c_priv->ready = false; - spin_unlock(&atmel_i2c_mgmt.i2c_list_lock); + atmel_i2c_deactivate_client(i2c_priv); /* * Note, the Linux Crypto Core automatically blocks until all active @@ -378,9 +374,7 @@ static void atmel_ecc_remove(struct i2c_client *client) crypto_unregister_kpp(&atmel_ecdh_nist_p256); mutex_unlock(&atmel_ecc_kpp_lock); - spin_lock(&atmel_i2c_mgmt.i2c_list_lock); - list_del(&i2c_priv->i2c_client_list_node); - spin_unlock(&atmel_i2c_mgmt.i2c_list_lock); + atmel_i2c_unregister_client(i2c_priv); } static const struct of_device_id atmel_ecc_dt_ids[] = { @@ -414,7 +408,6 @@ static int __init atmel_ecc_init(void) static void __exit atmel_ecc_exit(void) { - atmel_i2c_flush_queue(); i2c_del_driver(&atmel_ecc_driver); } diff --git a/drivers/crypto/atmel-i2c.c b/drivers/crypto/atmel-i2c.c index db24f65ae90e..c73ef3cadf0e 100644 --- a/drivers/crypto/atmel-i2c.c +++ b/drivers/crypto/atmel-i2c.c @@ -354,6 +354,28 @@ static int device_sanity_check(struct i2c_client *client) return ret; } +void atmel_i2c_deactivate_client(struct atmel_i2c_client_priv *i2c_priv) +{ + spin_lock(&atmel_i2c_mgmt.i2c_list_lock); + i2c_priv->ready = false; + spin_unlock(&atmel_i2c_mgmt.i2c_list_lock); +} +EXPORT_SYMBOL_GPL(atmel_i2c_deactivate_client); + +void atmel_i2c_unregister_client(struct atmel_i2c_client_priv *i2c_priv) +{ + spin_lock(&atmel_i2c_mgmt.i2c_list_lock); + + if (!list_empty_careful(&i2c_priv->i2c_client_list_node)) + list_del_init(&i2c_priv->i2c_client_list_node); + + if (list_empty(&atmel_i2c_mgmt.i2c_client_list)) + atmel_i2c_flush_queue(); + + spin_unlock(&atmel_i2c_mgmt.i2c_list_lock); +} +EXPORT_SYMBOL_GPL(atmel_i2c_unregister_client); + int atmel_i2c_probe(struct i2c_client *client) { struct atmel_i2c_client_priv *i2c_priv; diff --git a/drivers/crypto/atmel-i2c.h b/drivers/crypto/atmel-i2c.h index d54bd836e0f5..351306c426aa 100644 --- a/drivers/crypto/atmel-i2c.h +++ b/drivers/crypto/atmel-i2c.h @@ -192,4 +192,7 @@ void atmel_i2c_init_genkey_cmd(struct atmel_i2c_cmd *cmd, u16 keyid); int atmel_i2c_init_ecdh_cmd(struct atmel_i2c_cmd *cmd, struct scatterlist *pubkey); +void atmel_i2c_deactivate_client(struct atmel_i2c_client_priv *i2c_priv); +void atmel_i2c_unregister_client(struct atmel_i2c_client_priv *i2c_priv); + #endif /* __ATMEL_I2C_H__ */ -- 2.39.5