From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE67C376462 for ; Wed, 20 May 2026 20:50:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779310243; cv=none; b=S4TNVOp+vdFq0yh82kiQ5DU/oJ6aEIi4D8q2uhHufi6EpIgu0wyDh5v6y8S3qpbytfnyNYVr8NJw3z7Kzi35gAoXGAk4TfJTRmdxREqp+20hxDjDUIraYOSfocpTCEJrWXqMXIJm2ZVk7QKASP9t+5DOKui7wXRINcGl2RBInEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779310243; c=relaxed/simple; bh=jJu/raWzDXHDrGY3OmHYJ5IRBMbRwIJjRLBSVuVduxw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sHANK79p5/Hprk9UytQJiMu0g+S+ac7ykjgPG3jJVqIrsPbQGX51E5Kuxpw3IZBw3yoPN+2mNe+lLYoJVs5UdFMy2ZNSzjfU8jiX+ABWZjr/GmpO30I6Yw2Zq2Uvt/Vngivgx5VXA8sG5tIHPYRKH5pv167bDX7ykY9YmZqrYYI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=B0T0AnEW; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="B0T0AnEW" Received: from pps.filterd (m0167068.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KKbg5a1685666 for ; Wed, 20 May 2026 16:50:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=sToO R/Pf9Se6n6q9d83MywFIBvA3eA1y47gZuXeAAaE=; b=B0T0AnEW8S1XAAxYRdDC Jd/njvke3xOxdIRYA722oTLR9w1rS83qi2Xp/XDadg2RZ+8QRAuRaruu3txhGiA3 WcAY2ChK5Axkc6i1dUYeDzaiPGtTmG6btqv4svi1AzfXKUxyfoU5EodM0i5uGh23 x2xzAkPIz87g6dPT0sjt9VI9w6jwiBO+VSPSwfPFtK9zKdtSPZ+yZ9vACywTq4JE YI48gAATuweguQyGWHYhDCRN2/puaW69TUVcCLHFylJ3q4EmA41rhDmy9uhUvA/M KwbYBh3TbT9t5d9IGqAdrbF3hRkt5T1kOdVsC2L5+Q0xHZz1vyoaL5P3LSXSqmpu 4g== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4e9m5n02fg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 16:50:40 -0400 (EDT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-90d02857cdfso1176532485a.2 for ; Wed, 20 May 2026 13:50:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779310239; x=1779915039; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sToOR/Pf9Se6n6q9d83MywFIBvA3eA1y47gZuXeAAaE=; b=SpAxW61aKHAQ/q0QpVPeY3bVX+vESqag0c5pIzNlO8XdspazkIuxnaQsbO09bENsuD +i9yASGwI9ql+Y+t4kRgW4/RK1xKxjGtiGNAc/E2tLw+XwuYm5MS2o7cn6erbQpPr/+D ytlz9jXorPFQ85YDYMbz7RhNpVr5b31wUjSPpJjqrpuw8iBMZCCY/TIjSr1pxLM0f5WV U/mnyKaycaAC9aUaI8YCM4IqWZQwh2TBrxwcWBqk3UBKrG7NJjDU2PGGUdRm5/SKO2hj 3tYMbsALtYA/iwBqhWvD0JlE9mdQIIbQ+zv7svJytOjC42gAJO2l2FyOovyV+uPf6ozC XNKA== X-Forwarded-Encrypted: i=1; AFNElJ+dr3FP2lai2npsJXOS0uxOUodrIIKahhNWzT6xyG2YmBwB7VTEBOQwtrO9BFVn+jjV2ImTZeIdYwXRCRI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyckgkh6YKZ+717YuQwz+OhXYbgSLkClQ1CVLjaoLQ+rug/kmKy ANJ9Xoqf0kFBmTm+IQmUdrtmR140Fxhfd3nlGoWB97aeCKCvtKsBRmSC9cjjz7HVJTRmV0K0xEP VjnOcqc5ECkbYemWf4L3w5bcm19Qy5kHMd1+ts9gnYHoSawefTl6pAjswuSRk+w== X-Gm-Gg: Acq92OGLVWqj/pplSCEzh5/kPWZIgGBgG4ViEa+/ZSUPKO66xRzhjEZ57+NZthjXvGR kk5RuF5wBx8RFG+TxvzgLu0NcIKIfwz9RZ1ybFJclu9GTNQAyFNeZhwx0FfM+Lc2wC9l5Z3SYn8 DUJdzgQ7HDHif2wMDF/0ZjT5Kp6VdCHyEpYTWqOc61DOPTZ/c8zmUx9rFVi0y8A3gdzRHiLiEpI /WYXaLfXBZ1HjgzN8kL4/jRb46NkKMPsE03ZQ6YPRsWAcIEo8jeO54guRPA2NBymYh8ypvqfW18 O2voWOZVJuhh9QOhmNbZZHSv8lH6pqNfIn5S61LNs+4/8S45iWL/bE18YdR776B5cINcY9bGPkp e0Ouu+p8hcvy3CjcOEGtnxtpzO2atHgRvVHEl2a1XL2L6WTao7/9pL8Ycz+y4AjcGHU8= X-Received: by 2002:a05:620a:f15:b0:913:e19b:2f56 with SMTP id af79cd13be357-913e19b63d0mr2524459385a.10.1779310239195; Wed, 20 May 2026 13:50:39 -0700 (PDT) X-Received: by 2002:a05:620a:f15:b0:913:e19b:2f56 with SMTP id af79cd13be357-913e19b63d0mr2524452485a.10.1779310238647; Wed, 20 May 2026 13:50:38 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bcf37274sm2232692085a.37.2026.05.20.13.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 13:50:38 -0700 (PDT) From: Tal Zussman Date: Wed, 20 May 2026 16:48:58 -0400 Subject: [PATCH RFC 07/11] folio_wait: convert VM_BUG_ON_FOLIO() to VM_WARN_ON_ONCE_FOLIO() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260520-filemap-split-v1-7-c36ddc2b6cf2@columbia.edu> References: <20260520-filemap-split-v1-0-c36ddc2b6cf2@columbia.edu> In-Reply-To: <20260520-filemap-split-v1-0-c36ddc2b6cf2@columbia.edu> To: "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Alexander Viro , Christian Brauner , Jens Axboe Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, io-uring@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779310229; l=1934; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=jJu/raWzDXHDrGY3OmHYJ5IRBMbRwIJjRLBSVuVduxw=; b=aWk4flyPY3yiLsLPfjIZ128cQrOIzopXW9sJDfGsMadODQh9UbsXyooxIwmWJlV2xXqudRhGw BU3URuIRQ6lDLnXcm0mJlBPdMp+Mm+NXsFS8CdLq15K50p/AHbAIbje X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-ORIG-GUID: PRC6qei3RIvR6imPuplsKQDCrNHXOF9P X-Authority-Analysis: v=2.4 cv=Pq6jqQM3 c=1 sm=1 tr=0 ts=6a0e1ea0 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=GaPK54s0Se3oFqK5NkZy0g==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=usPcmh10W0ubT8QP8_c3:22 a=VwQbUJbxAAAA:8 a=M6LSvAv_FjuMSCFMCIwA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: PRC6qei3RIvR6imPuplsKQDCrNHXOF9P X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDIwMyBTYWx0ZWRfX7L6LHg5pLeCI T6kAryXBr5aZxI531AOzgyzKhKDb/cSJczGjqj9xjBlljMwDmCNmkBSf51FOI+B4lJhX7TaU8TQ T0kNiEPf4vI3Jyt5n7jkoak6yCX+WaHNIypFyuJW88xbxBVjFQxiffDXK05dKEKRwHNfvmUwlCp fkJ9i3bw/I+7dkTeyyNmqMQJLYVVIAwtpnVURJyNcyYT1ZEtPQKE4Tz2XDDGsshZ2CQx1uye45+ z8PH/rmp6aOs5jAbHlZUjaSAYZmrBZU8gokfXATzH5tVbFEMN7QQSIzIYzybLe7e9KxB/Rn+LWX V8F7awC6OmZtoPOfA7apuZussB6qHUwUo4LXeMLl3Fe254lRpSOih3kSTrwib7B5GPWzTISsKNI 01ZtHtLg98ATPgvGbscy8WSbY2NTtxLSJQfLBl46uEGcCuD05Wj49kSkG4FIqHViPjph+Wky1SF ozeBZ48jDOGfV35PH0w== X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11792 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=10 lowpriorityscore=10 phishscore=0 adultscore=0 priorityscore=1501 impostorscore=10 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200203 BUG_ON() is deprecated [1]. The VM_BUG_ON_FOLIO() assertions in folio_unlock(), folio_end_read(), and folio_end_private_2() verify folio state invariants and are already debug checks. There is no additional benefit gained by crashing the system. Convert them to VM_WARN_ON_ONCE_FOLIO(), as is now preferred for such checks. [1] https://www.kernel.org/doc/html/latest/process/coding-style.html#use-warn-rather-than-bug Signed-off-by: Tal Zussman --- mm/folio_wait.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/folio_wait.c b/mm/folio_wait.c index 70f808729f9c..52d336bc7fe0 100644 --- a/mm/folio_wait.c +++ b/mm/folio_wait.c @@ -465,7 +465,7 @@ void folio_unlock(struct folio *folio) /* Bit 7 allows x86 to check the byte's sign bit */ BUILD_BUG_ON(PG_waiters != 7); BUILD_BUG_ON(PG_locked > 7); - VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); + VM_WARN_ON_ONCE_FOLIO(!folio_test_locked(folio), folio); if (folio_xor_flags_has_waiters(folio, 1 << PG_locked)) folio_wake_bit(folio, PG_locked); } @@ -490,8 +490,8 @@ void folio_end_read(struct folio *folio, bool success) /* Must be in bottom byte for x86 to work */ BUILD_BUG_ON(PG_uptodate > 7); - VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); - VM_BUG_ON_FOLIO(success && folio_test_uptodate(folio), folio); + VM_WARN_ON_ONCE_FOLIO(!folio_test_locked(folio), folio); + VM_WARN_ON_ONCE_FOLIO(success && folio_test_uptodate(folio), folio); if (likely(success)) mask |= 1 << PG_uptodate; @@ -513,7 +513,7 @@ EXPORT_SYMBOL(folio_end_read); */ void folio_end_private_2(struct folio *folio) { - VM_BUG_ON_FOLIO(!folio_test_private_2(folio), folio); + VM_WARN_ON_ONCE_FOLIO(!folio_test_private_2(folio), folio); clear_bit_unlock(PG_private_2, folio_flags(folio, 0)); folio_wake_bit(folio, PG_private_2); folio_put(folio); -- 2.39.5