From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88E4217BED0 for ; Wed, 20 May 2026 01:49:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779241769; cv=none; b=tH9Stj3etSqg+LpmFB8wBGjc8wKV60q3Zr+L8FlSXlCirB0EYkhchuuxHhTMtsBtJDn4zDADPau3Smt3Wq35Y+dxE6SfYwcXqzB1RDhsqacMCWccjAn4SbzJhjEZu3gYOD3kySZiHo1jn2nONycyCHhMh2fI/n/plA9FYeiljEk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779241769; c=relaxed/simple; bh=7EM+JfkwMRjx4vKgzSPCXPtP8Hs4LizMJhdeXnEWxgs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jKPKONh5ngOxNJZpvOQQyjGvax4E0cqMuHMWOTa1jbecnbw6GRPa5w5UA9FR8I94+pUASv0XPK6w30pXuh5rv5JPj2nXlGsjP78IXcovBwJqeKbq+aYZb4X8o5irpza59NCIvq8TfaOy7b4tYYazDQAJTge8WsUm4aaUrDAercc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kusVFY8P; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kusVFY8P" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-bd3d7c29b4dso641523766b.2 for ; Tue, 19 May 2026 18:49:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779241766; x=1779846566; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=GbAWmpIeWrmIKRd0AiWx+CX2tvOghhIGhH7OVpuTfyA=; b=kusVFY8PKQLvTB+KtmwXcmVcvfP+4Fe81ZMcHgpevoSvG0kRoNwibFUVwE1xIul09X 1IlbCu35Ubtx7eNA8d9Ql26vvl+SRefZRSCN7pX2i3gLdB+nVpWcsBVBxTYGCgcbViL8 cqDS7Vi21fuzkHVc8MRMh3ymFoGeULI9hetGfMAd5mtUt73AVvzAvXOvmruiv0x1vWkp xsrOOCJz86IqeVngqILyWlAAUWmLrV9Yq2lEqyPZuALcAbIRdYpTu4FkGLid0If2aK01 iyHFHZEn/mTOO7LbbUo4YCv0upaLswCR0O6nbl36aGll8Tjlea2Q91kJPjRO/qJtfbAG 41XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779241766; x=1779846566; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GbAWmpIeWrmIKRd0AiWx+CX2tvOghhIGhH7OVpuTfyA=; b=qOkBqlyLXDIFb9aDiPWX1xekoBUtqH25KsmZu6dahWlCsTyPbzjKPw0/iEqXyNOJxk B/EKDNqlVLbN2wvRmVeHJvshuzxHPzn2CZs3ah18jlnU/i3mfyavR2jTsPIG/0ThoaIy IkNNdr7kI5nzRewIOX12/71biTtYpsnCBPLKiNqKfqzArC+oNrzJoaMfDCESRkEbmFPk LE86GNDEt8hXyW8g/OPblS5YlsvffWs7Eh5Vp/gozS59T0kfobHoieJy0W/0RmpRyv0e QgabGedwGzwxtDMU5iIdbR8ZiZM4qdKI23KgFmAPJzpdKiKUQ4UWb3Er41lE1MJNdB08 ubvQ== X-Forwarded-Encrypted: i=1; AFNElJ/9pjpnQPMbHO+zJuc5QEo4Km69MZcWgmZjEHgQ2EsRzQCzBazsw+4fe03nidujowS7CrSu6bXgJkUjj74=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2OChb3r4KvoXyKacr0zWU44SvlAo4GdU0Rh2K1wl/IbSXblhO Wp71ik1PWJtXyFCUA/FmvwXRyHFe3Omb1/nw1f9MkwK6uTIF7z7ZJMST X-Gm-Gg: Acq92OGo5D1AkPItrBSWDwAv0HsWyXrIa0Vnye7A/iTPaxVX95aw1YaA4W4egMg4lTK h3Sz/KzK4zLfLtp15KNmeUxPEhEnk9hVQ+h0p93vYJ4coKjjC4EUKWQoGhPyKcgD6Ww1qEczhyf LW6SIiPlnnotBsyXBNYj1kmhNCmtv6P1E6xboVRyINuxVPeURSo6bL8TNZrccn86QSuuktkkkQg XxRSKGhVdN4n0K4WBDmvJ/jyEwx35P2zD3pbL2FmkfDPYVflCMMJpcsi/SVJC25GOPtk/qm5S6z xW6kzAWJUZ3dnhIizhPx9JhnRtBth0NKv4Cq5VjdMA7EoCyENTSNkxYYNahSwEN2S9t/ZoxY2Dm 4ePFY29aij/LH2A7SlZHDNKhUuAVp7G2W6XG8Wff4irkkQ+VYW5uaiklEvNeWKEQpY+6b6CtSZG 29PZHo2hhVrPqdDlwRPIPw7Fc8rUoclB0i X-Received: by 2002:a17:907:8dcf:b0:bd1:2c29:a6ac with SMTP id a640c23a62f3a-bd517992f0emr1317114866b.44.1779241765510; Tue, 19 May 2026 18:49:25 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4ded99dsm770246766b.30.2026.05.19.18.49.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 19 May 2026 18:49:24 -0700 (PDT) Date: Wed, 20 May 2026 01:49:23 +0000 From: Wei Yang To: Andrew Morton Cc: Wei Yang , Vineet Agarwal , david@kernel.org, ljs@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests/mm: check file initialization writes in split_huge_page_test Message-ID: <20260520014923.zowt3fimptgzgju2@master> Reply-To: Wei Yang References: <20260512074924.27721-1-agarwal.vineet2006@gmail.com> <20260515092211.qkmaxcofxwfdexld@master> <20260518163553.447a45c54a3d419b9bb916ca@linux-foundation.org> <20260519025141.lguv7mrtvqgqpltc@master> <20260519121813.4b188b21f7280d6e1d9a55e1@linux-foundation.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519121813.4b188b21f7280d6e1d9a55e1@linux-foundation.org> User-Agent: NeoMutt/20170113 (1.7.2) On Tue, May 19, 2026 at 12:18:13PM -0700, Andrew Morton wrote: >On Tue, 19 May 2026 02:51:41 +0000 Wei Yang wrote: > >> >Not understanding - cab you please describe more completely? >> > >> >> I mean do this below. >> >> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c >> index 460fa1f606fd..f30402ece608 100644 >> --- a/tools/testing/selftests/mm/split_huge_page_test.c >> +++ b/tools/testing/selftests/mm/split_huge_page_test.c >> @@ -469,7 +469,7 @@ static int create_pagecache_thp_and_fd(const char *testfile, size_t fd_size, >> } >> if (write(*fd, "3", 1) != 1) { >> ksft_perror("write to drop_caches"); >> - goto err_out_unlink; >> + goto err_out_close; >> } >> close(*fd); >> >> On error writing this fd, /proc/sys/vm/drop_caches, we forget to close it. > >Oh, OK, that's a buglet. Please send a formal fix sometime? Sure, I am glad to. -- Wei Yang Help you, Help me