From: AkaLuiz <luizcarlosmdea@gmail.com>
To: David Lin <dtwlin@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, AkaLuiz <luizcarlosmdea@gmail.com>
Subject: [PATCH] staging: greybus: uart: document locking and fix indentation
Date: Tue, 19 May 2026 23:41:28 -0300 [thread overview]
Message-ID: <20260520024128.68942-1-luizcarlosmdea@gmail.com> (raw)
Add comments describing what the lock fields in struct gb_tty
protect, and fix the indentation of the
wait_for_completion_timeout() call.
Signed-off-by: AkaLuiz <luizcarlosmdea@gmail.com>
---
drivers/staging/greybus/uart.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 7d060b4cd33d..85586e9a4341 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -50,12 +50,12 @@ struct gb_tty {
unsigned int minor;
unsigned char clocal;
bool disconnected;
- spinlock_t read_lock;
- spinlock_t write_lock;
+ spinlock_t read_lock; /* protects iocount and oldcount for TIOCMIWAIT */
+ spinlock_t write_lock; /* protects write_fifo and credits */
struct async_icount iocount;
struct async_icount oldcount;
wait_queue_head_t wioctl;
- struct mutex mutex;
+ struct mutex mutex; /* protects disconnected during lookup and removal */
u8 ctrlin; /* input control lines */
u8 ctrlout; /* output control lines */
struct gb_uart_set_line_coding_request line_coding;
@@ -318,7 +318,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *gb_tty)
return 0;
ret = wait_for_completion_timeout(&gb_tty->credits_complete,
- msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC));
+ msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC));
if (!ret) {
dev_err(&gb_tty->gbphy_dev->dev,
"time out waiting for credits\n");
--
2.54.0
next reply other threads:[~2026-05-20 2:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 2:41 AkaLuiz [this message]
2026-05-21 8:37 ` Greg Kroah-Hartman
2026-05-21 10:12 ` [PATCH v2] " Luiz Carlos
2026-05-21 10:46 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260520024128.68942-1-luizcarlosmdea@gmail.com \
--to=luizcarlosmdea@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®