From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com [209.85.167.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B27D2C3266 for ; Wed, 20 May 2026 04:53:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779252819; cv=none; b=Ngk4JrNnshNojDt9fKFNA0R/1p2ZbXtIRfN2lpfz/yiLq4E/M8t39q/QKkY5dx3aS87AINun0ORJPeWysvLGSKVFtr3yiysfPXrPowqb3tt+JmF8k1saeqmJjG4Jf1IqPB5kNmud44MBV9H75MNldDN9XHJ8PqGvmimn5sIQ44Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779252819; c=relaxed/simple; bh=A/70exiy/2K0mj3HP4s+WYIp+vMhVWnDct3Z3acCb54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lhIB2iI1obGrNWLfkpLH6kgPRYc1zqNyORCJfbLE15Dw/iQTNYBNOyeryZhS6hR8dvu7IjOhSgEJXYR9l9Xf8GVEoS9MBP76UL4sT3PCNC9TTQ10e7npjPw+ONKJvmY0wev5sIO7FA4VDWRxwr2DEc7fe2Iedv29CyCtw03FrZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ss78Q8On; arc=none smtp.client-ip=209.85.167.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ss78Q8On" Received: by mail-oi1-f180.google.com with SMTP id 5614622812f47-484d3c0855aso1560278b6e.3 for ; Tue, 19 May 2026 21:53:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779252817; x=1779857617; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Mg26S8t/TkGRXzhhdHCmgve0tBcd/dsW907d4GgRAv4=; b=Ss78Q8OnvijQPwdBH8OmOkhzKmMpYFRgkcX6h7VazKYQaQCacY2FY2eB4fpf5G91QU 3EZ7hPuvHmEONDSWATaNey3CI+mwEAPLlHafZ3/R3VwzULT9eCEjS0AJKZ2Gc5Vzf0GQ Sa0CT4t1fkuj1tC8f7C/eN2Qa/YC7UXAlkBSbcOjWANFqnqkV/CwFTOqpkBD/sulSLJE m8BUldMkBt4AqGcl3qP8+6F2oL5/jx42XwWMMCNZEagnJ6oon/sLD0VUj4JLRrraGBvg CDSjifZPghdoJlxnwL/lnnmsQ9siGgeD+ONogeNX3dOwayIExUWPTdlDCTxlTX8UOjAf nkxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779252817; x=1779857617; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Mg26S8t/TkGRXzhhdHCmgve0tBcd/dsW907d4GgRAv4=; b=RMES024zYrMXRaqgQQWvtWRgiEM08Uw2lz0KgFSwn6Fm0qBMi923woB2/N030g7BpV EcGalCYrXzHmitNQKtYK8vIF4zV32tIIFDs9FcIndgPkWMhgVq/aBXj6PLrPlXFwfmhY h3HeqcZVydcM/5G4GV9koTlV0hdDIzHLfxVq0s+aEHzFBFq4UMgSPB7qJaBT4620/r7A 5+POu43wRHRRoSyuO3Vx5ajgdiULJIiLhr4dFbVNwaambYDrFXkabDCh6swWJlwlCKAR Iuwf05IAV1sMvxUs/Xo4ipS61eOqf8tBETzPADO5L6KMQIzZf8yqN/U01kPc5VT+EEqM eFTQ== X-Forwarded-Encrypted: i=1; AFNElJ9i46r0APj9PCdWl50xkYBe04FOhAWLz5qBZAPCEVqdBBcCUpPbgIrbr1BoKV61HDTxqcP28tywy28xVQM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1cJXwPRs0KvAlOfLSLjrOfQdke6byYw+S8vzO6Sw8ZoUt9e9r 5SyiSv+HqdhuC17xMgYWMsBkBIrhPnB+XLdjCNYkbRP5x8a1S6VaF01q X-Gm-Gg: Acq92OHciZbkKpQDZiVA9ezDvHUxVpDFXerb2x1HIkVaFUsYarkVGVxH5QtWKoMBW4t E5aRyFZdYtkM+USUFvAH8uKSLDdDVG4+vBG611jk6Bypv02g4HD4hZl6xolSQPT+igBiv5SOyd2 3RcKhBFOEaJ/ctXeMX1YNZd2UpgZZ2Mkr7HtraleUtUKpnYA6XUTlf4RUKusB2STC9B00oh/5kk eUMtjws/ZQsbNGkGn1fLTk24PQy1A7hrWkaIjGqmT0+9Xy88lXt0FrEcNOwZC8yTF/ivWvCcK7k kSarzCH4F7KQLP8fKjcYG7cwjmpS7MJT0GoXwzrUcg02EAWZmiuirkEaNPt99M+qTFfpxlfaRZO RQtUN8IF4/6DY6iDL6xSxa7L7JvRRCZmUeV0hQ0LqIiFkNbOw7vnso2jfSH7Z8dSe1xtxLyBN8b c3/jsldAX46RRSXZUz4ceROTk7Fr5oagyhSa6vMMbsRQ5a6mqOsA== X-Received: by 2002:a05:6808:c1f7:b0:479:dcb1:dce3 with SMTP id 5614622812f47-482e53affd3mr14763463b6e.0.1779252817466; Tue, 19 May 2026 21:53:37 -0700 (PDT) Received: from Dell.attlocal.net ([108.243.219.47]) by smtp.gmail.com with ESMTPSA id 5614622812f47-482ee0999f3sm7592870b6e.0.2026.05.19.21.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 21:53:36 -0700 (PDT) From: Akash Sukhavasi To: krzk@kernel.org Cc: akash.sukhavasi@gmail.com, conor+dt@kernel.org, devicetree@vger.kernel.org, gene_chen@richtek.com, gregkh@linuxfoundation.org, krzk+dt@kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, robh@kernel.org Subject: Re: [PATCH v2 2/2] dt-bindings: usb: richtek,rt1711h: add missing 'port' property Date: Tue, 19 May 2026 23:53:31 -0500 Message-ID: <20260520045334.159097-1-akash.sukhavasi@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260519-quixotic-lobster-of-experience-b894cb@quoll> References: <20260519-quixotic-lobster-of-experience-b894cb@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, May 19, 2026 at 3:08 AM Krzysztof Kozlowski wrote: > > On Mon, May 18, 2026 at 11:20:14AM -0500, Akash Sukhavasi wrote: > > The schema declares 'additionalProperties: false' but omits the > > top-level 'port' property, which hi3660-hikey960.dts uses to > > describe the role-switch graph endpoint. This causes dtbs_check > > to emit: > > > > hi3660-hikey960.dtb: rt1711h@4e (richtek,rt1711h): 'port' does > > not match any of the regexes: '^pinctrl-[0-9]+$' > > > > Add the missing property using /schemas/graph.yaml#/properties/port, > > following the pattern used by realtek,rts5411.yaml and other USB > > controller bindings. > > > > Update the example accordingly. > > > > Signed-off-by: Akash Sukhavasi > > --- > > .../devicetree/bindings/usb/richtek,rt1711h.yaml | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > > index 7ded36384..05ffc33a2 100644 > > --- a/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > > +++ b/Documentation/devicetree/bindings/usb/richtek,rt1711h.yaml > > @@ -52,6 +52,13 @@ properties: > > description: > > Properties for usb c connector. > > > > + port: > > + $ref: /schemas/graph.yaml#/properties/port > > + description: > > + OF graph port describing the connection to the USB role switch > > + consumer (e.g., a dwc3 controller with usb-role-switch), used to > > + convey type-C data-role changes signaled by the TCPC. > > I don't think this is right. There is no such data link for "role > switch", so this should be part of standard connector ports. > > And the only other binding (I found) having these two is > qcom,pmic-typec, which in practice only uses connector in all of DTS > files. Hi Krzysztof, Makes sense. I'll take a look at hi3660-hikey960.dts itself since it also has the port@0 required property warning on the same node. Will send a separate patch. Dropping patch 2/2 from this series. Can patch 1/2 (.txt removal) be applied independently with your Reviewed-by? Thanks, Akash