From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92F3B3D1CA2 for ; Wed, 20 May 2026 12:19:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779279597; cv=none; b=hG03mbHuHofCQ5j3CAFTsD64RFu9eMwkhshXKdxWFkv0f3wRc91f+FfM9p0F+crHZo5x2Gf2n4cEVUPaT7wpK8jDIOClsDzv1Ebo6SEdqg3kPfcw1zD693XffgImBsBg3hSRtSMc1LNIZ8ZbaAX1V6pp1G7uRCtY+XnnMJmxez0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779279597; c=relaxed/simple; bh=8xoGBygncwwy/m/+1rldwBNVyFERbPABvdymmXhWtwQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fgOfMva/z0CsdtSMjmm8yPvdpgVXC1S2p/Swo9zo8QouDQF5tnnxpsfOT6ekZQyf8tzEILW8fc1AusbAHMSZ85sonEDszROCUt6uhvl5d2q76tOgNKcui+ANW+nrq0RUHlfZVVvExYGCuwPxOL5n8BarVet9QZ5dQ3yHYJXtHGY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MBeqjOdb; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MBeqjOdb" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-5a8b18efe47so382629e87.0 for ; Wed, 20 May 2026 05:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779279595; x=1779884395; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8xoGBygncwwy/m/+1rldwBNVyFERbPABvdymmXhWtwQ=; b=MBeqjOdbNnUEZDN9wqp4P2C18o1rPhrIV1GPwuflbgC/4HdGslwOeNAQODNAv+nb8J 733weu0XnBxG6uA9IxjXC2liKMKPj5bQMDBThfz54Vf3hTVQsnIpnzjDEYetlONsK2pZ P4UX9VlutpDeV6HBDukSZkHusMzcs5Hil+4jVaYEP/R1T2sBa5jwrPGihEpaBgdGFJmr 0R9x2ioFRi86Uc+HpDL8qjD9u6IyahcVZZ+rwg1ly8jIHfekonr8yMJmzrphMBCvamsI PmALB167V3V1sQjitBRKqkbllDv+7wZ8yl7MqpC9NLyljPwB18b5Gk89B+21InBHOUIo 6pKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779279595; x=1779884395; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8xoGBygncwwy/m/+1rldwBNVyFERbPABvdymmXhWtwQ=; b=d+MJGs+VYyrqxIrJtnBj4Y2XIW6zlWStjZ2wrf7CEs0kS4mTfx1IqMyYRq5pOQONy2 30l1VdrmPorDRwasWQLs7Gr4eV0zASDrmMAd9+7v1B4GiIMMMyPPCz8BPGvx30+rAyxn euFzS3JEpswGpd4RBsVUiauHl9Jra3EtnXMM6sx3PqFB1A99sWj0XWqPczW+AJ/a9W22 fzXIzNAfb+m8iE2/SEGHxNyQGDsTR3h1iSJpfjCtky9sQAO2SStel0DKlxdqpYgu6WZg V0nQ2i3ZwoSuCZDXxC8fiwHxVwDooikJA6POjy5bPBWcAWYanQFA56AgKNQ5JCPzF/CB boXg== X-Forwarded-Encrypted: i=1; AFNElJ+r725r1OiLJDUxFlz5ZM+vvI29u/a7YqfB8eoic6PRy6d1hD1kfgCaLtMMNxK4yJvP3+xzpvMk3lUQHjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwSVOG4AryJtUjbRLdD8+9++Iub6ddumeoS9V+k9AOgzCQt/KQ/ zxdb/fMcUyb5POCAtakwSr32hMeaGLQAd7DJlv/+x8FHDb26cnq3iCJ5 X-Gm-Gg: Acq92OH7FWhpLTaKTbT0Nz9XBpqqPeRkOw3mJuI2NgXy3JYYlfl+Ax97bqd+AyTD8zA /O6A8Ye0AoHLf+A05NU7dmgQMoxJmcQGHhT2j6d4Xs18fo6O9kYE28TR2PRTIoVe6ZV07U3+x+i kpLT2ssgPQdTO9zxTmUYRq9AS9he9sthSa1MaPxuv+HF0cQ/5V3HJ1UU1R2HWkuJy8ayVB26n3k EBmhz5epCkt0gerBMEZWKZ/UxwGd+5W9C+Xn0bwoRfnyNBY7DUUHijRWL9wQ98OnvaH9nlaxJbD kzS7z+MYPZSFHI8usah8uCmg6aX4zX3C50oBfSKcPXoxNjCPG47wVETkcMSJ73d4SaR08piN4R4 nV5jhOaIHkI+cnJwxKANf43BnHIGaZ81n0kmRwdJBJ+x3FIuFfDzT8EUThlnC7lW3hBEId0dNrA ylr4dY1RaTQY1OhwAWoghzAnZCaClqpG8+mIXXzRK/b1YXQ+zewuHQ/GIuwQ== X-Received: by 2002:a05:6512:1195:b0:5a8:6f01:e1a0 with SMTP id 2adb3069b0e04-5aa0e745878mr2562854e87.3.1779279594625; Wed, 20 May 2026 05:19:54 -0700 (PDT) Received: from localhost.localdomain ([213.230.116.218]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a90f11a619sm4904867e87.27.2026.05.20.05.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 05:19:54 -0700 (PDT) From: Stepan Ionichev To: m32285159@gmail.com Cc: jic23@kernel.org, tomasz.duszynski@octakon.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Stepan Ionichev Subject: Re: [PATCH v2] iio: chemical: scd30: Replace manual locking with RAII locking Date: Wed, 20 May 2026 17:19:39 +0500 Message-Id: <20260520121939.15266-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <20260519131944.25174-1-m32285159@gmail.com> References: <20260519131944.25174-1-m32285159@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The "_locked" suffix in scd30_trigger_handler_helper_locked() reads as "caller holds the lock" by the usual kernel convention, but the helper takes state->lock itself via guard(mutex). Dropping the suffix (or renaming to e.g. scd30_read_meas_data()) would match the actual ownership. Also, the int arr_size argument is forwarded straight to memcpy() so it is really a byte count, not an array length -- size_t bytes would describe it more accurately and avoid a future caller passing ARRAY_SIZE(). Stepan