From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3EEA3EC2FB for ; Wed, 20 May 2026 14:44:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288282; cv=none; b=JKV7DWv7rjySWOYGnh1B6u99LV9LG7LzrvzZIb2TjrxMRcAfvr61HYzgvDfEvPCrg77O9PnZtjNBiMqozWDm/8O0Pxqkr6kyiDfRWtc2M2q9Q+yEwqR+KDZrOyPAEMZJyDrGPpYGg3uxy5gp0wok6zCy4s2DiGmXV30pRdOmTEE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288282; c=relaxed/simple; bh=DkzllpKWjnd26gBnyQF7wWmb8cVdPFyb/a5Eng97BA0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g3JpMZ6uxrAL/Hva5A19hymZWgkYTIpQ3Pyy1itOK9VwLMK/4pD/F8w9KcZMS5Bo0W23lc316+gYBuL7HGYFo6sBL+V+X/9FXRLrNOZlxI0HQVscWu8Jzq24XqufeTqP6MrnU8WcFTN1+3uapflutLmaQJWpiWq2h8nEs6AKIHo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=AgKnEJuy; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=PS7B9HsO; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AgKnEJuy"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="PS7B9HsO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yg6ugDawgWn5QsRCnVPpHRqRu0HM07HRxwmRFu7Ahbk=; b=AgKnEJuyH6xGJZBInH3fIHN78TYO9HCUcgLDSiKHfFv2AQUvbD4qmao5hO9HiA/MhU0C3m AGD4ESY130t/KE/L+qALnv2GM42mJFe87PkEuy56tAxpDU/9MhabGA+9EY01+SDq3Lpt1K +8TLvKB5kH/HhHz/2q/vdNJ+B+AuHnk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-474-OknMES8gMSuPtzlCk1CgMA-1; Wed, 20 May 2026 10:44:38 -0400 X-MC-Unique: OknMES8gMSuPtzlCk1CgMA-1 X-Mimecast-MFC-AGG-ID: OknMES8gMSuPtzlCk1CgMA_1779288276 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4900f69197fso17742835e9.2 for ; Wed, 20 May 2026 07:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288275; x=1779893075; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yg6ugDawgWn5QsRCnVPpHRqRu0HM07HRxwmRFu7Ahbk=; b=PS7B9HsO9dr9JvAbPKMDrnHPc+kyzVFh4xkWLg1MUYcxSHaEfS/CycNE6PyHVHrcjT 9gPcqqoenRDcSxP8J/GlsM71AEn/Dk5qqXNRnTwkRAUAnaTlp44nzkvUSgya01Pw4TXf 0veYFxWfjtSaA52PFG9SAtBpCCCnPuGnufl9Hj90FPqRCCXfT75h3mgdMZwpiXxhc68W GdUqch4cmkqPyWLhe+4iGaLIZ4iaBEP+A83/iTGvH65dJge8tNrj48nwxd+7t8CA3mOZ gH6GyrITNMoeXWjRPLXlvYXibHS72d7cz+VXwWz8o0F4NIIVf3LioGZtFiO5hbxGDtlS vv+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288275; x=1779893075; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=yg6ugDawgWn5QsRCnVPpHRqRu0HM07HRxwmRFu7Ahbk=; b=Cy4ShoCYapZnl8BSrQh2M4aL8IXBAEEy8vMyp6Kf3eW2jx1oUDl/1MEvBrc8grG/50 TY0RsH7WuKmMzQmqfXyoor3eyQEdLpEf/LUHxW+g1VEi1hyzlNwneU1aOmc1jF4eBbdX RtZnhpBsEPxuj/plCvYZJPhRK4NVO+RSPgEkFmja5wY+fMmyWJY0+wL+mEXJR8fUXMja MkfraJI4zavsrfNExO5SN8yfWxgOcmMiZL5WnI/Itcnqw7BoJK2m+0hFBCsA16RhPrnV 4wzQ0+HycXAXHjbtIcVMM7nLvU2912858c754bD91ZuqNXBPqgiDTj/xEgvMKrfwgmE8 ++2w== X-Gm-Message-State: AOJu0YxAbmF9vHPvXjAr4k8yZZKgIFofazQ+Tff1amy2HGyI0/MsDYQf JkbBbNDy1Hmm1ORahruzDX2rA0JJf7vCRcQy/kac1ubDiI/V8RjpMQbq6ojYBSJgvukcYgAsADQ vCHlk7WOAMpcO+lBnuWMIo9ohMc/cXs3mJytRkPDTC4UiQ2Nf0Xx4JQc3RxvCoTFz5wP7K1Af+6 4dOPrPSSdE+GNDtRn6EDM34sjT8wTyfNDUL9yDLeGNc3fpNRbe X-Gm-Gg: Acq92OGviEeQYGtXuDcmgJhQRYanZaGTRzbXOMFKm/8jOHXJXf5EDBu0RvosLF+v61K pbwO9hiOHtHOOwFRVIVLhfeIS1fD1UhbGmMn6zSGFXadmEv+2yJJ5pMuY8PpctSaG5CsMk/03f/ VxhNtwce5U/y04lJKVn3kljIHzO0eVSWtQLp5sH8uck86WRz9umyO1lQWs5DLCGXdIHChCAbjOB j4J4adD4MdgwVHcs4wE3s/0nuJUrPO2iCl+4B8NpMDGOb0wJrZIfJ6eqmeLN1haGm5mu+O63B8N fzsqVAaHJEprRATLi2VfB2ZsPbmXks7tNBX/cTk1CMWeX7mU2MftiM1qD36Ovb4BesFUfy+pvgu bX+piCfzZrsFjm2vqs+mJABdmuw+JaN2i8EtNLmyoZ1qH1NQ= X-Received: by 2002:a05:600c:848c:b0:48a:563c:c8c0 with SMTP id 5b1f17b1804b1-48fe60e51c6mr377331065e9.7.1779288274931; Wed, 20 May 2026 07:44:34 -0700 (PDT) X-Received: by 2002:a05:600c:848c:b0:48a:563c:c8c0 with SMTP id 5b1f17b1804b1-48fe60e51c6mr377330385e9.7.1779288274397; Wed, 20 May 2026 07:44:34 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53ab6aasm432985425e9.2.2026.05.20.07.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:31 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Heiko Stuebner , Neil Armstrong , Andrzej Hajda , David Airlie , Dmitry Baryshkov , Jani Nikula , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Liu Ying , Luca Ceresoli , Maarten Lankhorst , Robert Foss , Shengjiu Wang , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/8] drm/bridge: dw-hdmi: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:38 +0200 Message-ID: <20260520144424.1633354-3-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Heiko Stuebner Reviewed-by: Neil Armstrong --- (no changes since v1) drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 41b3a9cfa2f5..17d5caedb32e 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -51,8 +51,6 @@ /* DW-HDMI Controller >= 0x200a are at least compliant with SCDC version 1 */ #define SCDC_MIN_SOURCE_VERSION 0x1 -#define HDMI14_MAX_TMDSCLK 340000000 - static const u16 csc_coeff_default[3][4] = { { 0x2000, 0x0000, 0x0000, 0x0000 }, { 0x0000, 0x2000, 0x0000, 0x0000 }, @@ -1426,7 +1424,7 @@ void dw_hdmi_set_high_tmds_clock_ratio(struct dw_hdmi *hdmi, /* Control for TMDS Bit Period/TMDS Clock-Period Ratio */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 1); else drm_scdc_set_high_tmds_clock_ratio(hdmi->curr_conn, 0); @@ -1671,7 +1669,7 @@ static int hdmi_phy_configure(struct dw_hdmi *hdmi, } /* Wait for resuming transmission of TMDS clock and data */ - if (mtmdsclock > HDMI14_MAX_TMDSCLK) + if (mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) msleep(100); return dw_hdmi_phy_power_on(hdmi); @@ -2032,7 +2030,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* Set up HDMI_FC_INVIDCONF */ inv_val = (hdmi->hdmi_data.hdcp_enable || (dw_hdmi_support_scdc(hdmi, display) && - (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + (vmode->mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ || hdmi_info->scdc.scrambling.low_rates)) ? HDMI_FC_INVIDCONF_HDCP_KEEPOUT_ACTIVE : HDMI_FC_INVIDCONF_HDCP_KEEPOUT_INACTIVE); @@ -2100,7 +2098,7 @@ static void hdmi_av_composer(struct dw_hdmi *hdmi, /* Scrambling Control */ if (dw_hdmi_support_scdc(hdmi, display)) { - if (vmode->mtmdsclock > HDMI14_MAX_TMDSCLK || + if (vmode->mtmdsclock > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ || hdmi_info->scdc.scrambling.low_rates) { /* * HDMI2.0 Specifies the following procedure: -- 2.54.0