From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979B93EEACD for ; Wed, 20 May 2026 14:44:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288285; cv=none; b=R5TTtFtnHyJ+9Tnfzyb5jWl+q1bDY26Fj2aS82G1vQPHe/8F+yMyBVX8+JhzA/rdYL8mtJV6IApNZ3QlRdVPcpz7Dj6410oau35NkI8uhgKnl+MknBljSpPhWSO8VuiE0ksGtLOHjvbpwD9smCvUGbHmNYy5hwZMLgrZCJerZfA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288285; c=relaxed/simple; bh=fE+igeL/j/LsOzA/g5PlS4vH35q42svJOZSnbALq3V0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B37xi1V3eqRBRZpOEwUQZ+kxHCjUd21GCJJrizuHa2yU1Al1MjNCcwnkyeq4Yod+N3N4iL+XlV/Qkr1J7uuInHdvibkVi7ABfmrDLI/8EmzAf5t9Dks2yMR4rQeHnt5s508TN9grj8xjubFK68glu+/9ROGJxN9DxRdg7JK/Dto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HcR/Rvgx; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=toHvXTsV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HcR/Rvgx"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="toHvXTsV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288282; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JrxzAdgBYytRoIJpGeZZBDTthna9I+jFkH7rD3Jxpxs=; b=HcR/RvgxLKOHL6zl6bJjSiCZNx8+abiqQvSs5zH/lPS/rnP9MIG/vfKP3MIzpkv0gw1IHs zhnSnENdDpgihdseKyedwpLiQ/pULv8neG7tDVrnhmNHvWazj7eZW1qDbbPCGRg7BqviMC ywLrJ1NLeFNirGJUgqXsKA/OV/x7udo= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-530-6hBrAYoCNbafc561JdTpwQ-1; Wed, 20 May 2026 10:44:40 -0400 X-MC-Unique: 6hBrAYoCNbafc561JdTpwQ-1 X-Mimecast-MFC-AGG-ID: 6hBrAYoCNbafc561JdTpwQ_1779288278 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48fe3e73da6so24744095e9.2 for ; Wed, 20 May 2026 07:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288277; x=1779893077; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JrxzAdgBYytRoIJpGeZZBDTthna9I+jFkH7rD3Jxpxs=; b=toHvXTsVNgbClZRQmgBewbFx3m6ETtDI9J6rAlORxRERp4+BPdMWqRU8pEgLVanuRU o1nbFkF30a0bVwWGJhq7XM48uyIu65KQmjIqXdJa4OTHYZ88SI9mjKcmGmG+aoZfJmCl nRjaE4WG8lI8En8xNtXagBQYaMW16HHPmzxDwpjvgnDoA2kHnwXUh5NMOhu+VymjvfwF KeYAzO7oVouLLR/80ukCvOhHovxa68wx3POC07/oaaD1xhmUXCNE1FReTIQ1abg+1hKq F1rzXo3MdA6EbsSkGFM++DqfxFdZ4RfiTekrRjTFDaQcM00BHfCyicW3FAqObGt5pFwV fHHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288277; x=1779893077; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JrxzAdgBYytRoIJpGeZZBDTthna9I+jFkH7rD3Jxpxs=; b=LoAZt16U6bqw2gwIpJAqgFdBVnX5Rk8FLmyZ4Irr5laWmyRHAIh4FGeS7GJdI5n0w7 W5vtAT3wpLM12DxVwYAEJe4Ixrxwse4aQYz8jLlLdY7tGoLvEsGkIM1sV6YJJg7q1FAp QqGeNG3GKAuiT9EzVUmZeLH4x4ir2D2DZPmIADwjoBIa5Ok8+9SNr8cL/LMP5LEzML5M ea1njWw7GbNSbqL155E96YUKBpCJV0DcyWwqznfr8WaFM+smN/DgA1nCPFRvnF7aHbC7 EAz+cdJm4WVBSOfwDHZrSoULBqWRV1UF+TED7GUFZcIlCQ6WvmEnvU7G9wBJQ60blaQ0 x/mg== X-Gm-Message-State: AOJu0YwkE7C3AEaGi/T4Z+kmod3dIV/p8h2eovBQ2Rh9izEybqggVPtm BFBSVKd+v/ob22LPXZV9dd5Zx8vXsO+IqgNa8TMBNJgOtRZCeQgBwbXl9a4hTwzgHER+fqHnyYF hbRGWnk23A5mtlIXRGw8pzyD6ZPsXxJ0n/AI3AlSO0Hq537XpoFbyi1tv0J9s/bf5lzYgqVB7er rrUWyU4c2ig+QF16g1ExxfvyBGWxG/KJA6lCq8470RXRuni3Q2 X-Gm-Gg: Acq92OGz8iWQBcY9dP7s41G3YByTsTkwlpBU6I+5Mzf5RDgW0Yc3mqNHjja5xnfYBAK ZCHN65PcRsvUZQ2zHL2cFJqz+BL2c86qCO9xmluvwPXq+dMORWqS95DlcyO/CO2WzSsGwCaNJ9j vRrvRVyJvTznOm5D7lKWSSGGeq8P/ShGcaLhbclJvKWcXZ1h0Oi0aTcjw1gVnGtQ/GZUlu/IwNc Jsxu+D4NQOUJS8xOAmGI80YuvuddHvK3o8gD8QYkpqYTjnjE1iMWC7ULrQvYcGXgTGxsItzsGa3 NOulYNJS+blJrEJM8eK9BMhCApy9FDnPpBV5sNdgLKuo+e9vkr+pk3k/FnL0703VJdwG1xNjZhZ lX+bYdrboEPp2d8bpDlRaOrgakWBBJZrbH0TgFMB3RcJu+w0= X-Received: by 2002:a05:600c:350b:b0:48a:58ae:9938 with SMTP id 5b1f17b1804b1-48ff3346102mr294157685e9.19.1779288276982; Wed, 20 May 2026 07:44:36 -0700 (PDT) X-Received: by 2002:a05:600c:350b:b0:48a:58ae:9938 with SMTP id 5b1f17b1804b1-48ff3346102mr294156915e9.19.1779288276391; Wed, 20 May 2026 07:44:36 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec3acf7sm55247030f8f.12.2026.05.20.07.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:35 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Neil Armstrong , Andrzej Hajda , Andy Yan , Chris Morgan , Cristian Ciocaltea , Daniel Stone , David Airlie , Dmitry Baryshkov , Heiko Stuebner , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH v2 3/8] drm/bridge: dw-hdmi-qp: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:39 +0200 Message-ID: <20260520144424.1633354-4-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the driver local HDMI14_MAX_TMDSCLK define with the shared constant defined in the header. The local define incorrectly referenced HDMI 1.4, but the 340 MHz maximum TMDS character rate was actually introduced in HDMI 1.3. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Neil Armstrong --- (no changes since v1) drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index 0dbb12743609..1c214a8e6dc2 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -38,8 +38,6 @@ #define DDC_CI_ADDR 0x37 #define DDC_SEGMENT_ADDR 0x30 -#define HDMI14_MAX_TMDSCLK 340000000 - #define SCRAMB_POLL_DELAY_MS 3000 /* @@ -835,9 +833,9 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge, /* * TODO: when hdmi->no_hpd is 1 we must not support modes that * require scrambling, including every mode with a clock above - * HDMI14_MAX_TMDSCLK. + * HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ. */ - if (rate > HDMI14_MAX_TMDSCLK) { + if (rate > HDMI_1_3_TMDS_CHAR_RATE_MAX_HZ) { dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate); return MODE_CLOCK_HIGH; } -- 2.54.0