From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E36B23ED5C5 for ; Wed, 20 May 2026 14:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288290; cv=none; b=XlTjNpZjDotgTHcGP1qmv8E79i4RIK5Ew6phvY/z3rzrjMPsA1mK43XUsm6hXungokiBMDuGUt4JB6rhdQU90h2+mfKJ24Ptoh9WBMu1qws3QsYKEq9pYjBp1zEfJWwj+4L5dxduJSv6WIt0hm9D4oag1FGvtwdIwQdChokRsOU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779288290; c=relaxed/simple; bh=QCHcVbwq0371QGOnwI+lDNZxJI2XqC1NlU75KLnG7Ps=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uu82O9cjTON+AUTSxY9MEqiXx7dx3Bz2mvdLjJnXDuO2L1rSrXkm4Qpa3fz4VE403+sn3MIhp/XAZ1HPY+XpIdezFcTU1Z/10nQ3+dVwVbEF5dn0B0EP8npM/cUgBzHhTyqktOyT23rSuzIWDGXLqkY7rHIHhPn8KSDIhUphk5A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=HdNVbuW2; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=k9dncQhe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="HdNVbuW2"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="k9dncQhe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779288288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1tSo1G68Ra9imzMIPMx7cCxGvcqmHD7eyQZ4RzsS9c=; b=HdNVbuW2lb2rNkHZPDRRRjOuylqst+qHyXvDoYjR8fqpQF1DiKzct5F8ss9XIYRbfZB5Mi jlNq5Q/6/MN7ikhk6nBM1Py4n86BLVcSvHO2zwP5UEiHV6zazzprTSv5VBt/jqgB/vHGcO sTfJkDZaAVCr4bxt7SHqvYGrEVZelbs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-ftqO0mIVMUCXUnuyJaGfIw-1; Wed, 20 May 2026 10:44:45 -0400 X-MC-Unique: ftqO0mIVMUCXUnuyJaGfIw-1 X-Mimecast-MFC-AGG-ID: ftqO0mIVMUCXUnuyJaGfIw_1779288285 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-44ffa15dc8cso3046452f8f.1 for ; Wed, 20 May 2026 07:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779288284; x=1779893084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U1tSo1G68Ra9imzMIPMx7cCxGvcqmHD7eyQZ4RzsS9c=; b=k9dncQheIDcj8WOJUYGlzaDqpt7f1cQa/Lt5pqNENOjpLzzFCel5zhMW1nQpdPHuzU tmG+eVDxJTDyE30DAgQzVN4igmKro2FuWrFzYFHCNik7DOGBz2ktxsseFUzT338NIdV2 GRdPlf8Tel8w2KiIjOHRsHm07WyN0RfCwhGGn9sR8lTy+i/2nZ10KrawvDqjAyh9D45+ LNMkayLvqEaZfbux3/CtBmCGA4mEGZ8x6rdQSwNby/oJPV1jvlC34TY87eMB01Lumhds Sa6zXAEDunwkNNJeSg8Ot84soT+T2nuNVHL1SctHugfVqjiArqcP+ZfB3QT0TeUrOOlo Pe9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779288284; x=1779893084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U1tSo1G68Ra9imzMIPMx7cCxGvcqmHD7eyQZ4RzsS9c=; b=MnXwfwhrIPTKCYhCzOx1SdxxRO6sK5aV1ElHrip70T87gsHlpoTXsU18xU+yHtkksX +Y89X5+bEi5t0eBGn69FPMwqXc+6lzS+wZdb/SI3Eusi4gMVj4WNX6TGNcYpffe0Zpvq ooqVwwMZ55nLnq8aFMuMy7IfBuBGCAp/Jbq8FvR2RMTpQ3+vWxRSn8wI6+A5DFftoZYb UComR5K+Nn4XsrVzwluY5Sqx0h8xhCWF9sgyJn68J/4tkCn9+Z+xSI4cqKvXkWcXXDLd LrFRAyX8pU8xnHPOyzcfA1RV5TIPz2YSrXSwNgbfhu7tWNyVJMD6NnOyY9DM4yozMmI4 36Tg== X-Gm-Message-State: AOJu0YyVs81BYPutHQ/EDaox3jOv0oEFYAY/23NaxFpLtCL4B/cP6CMq QtJiVbGObs/Cr1rKTi6zV2aB0P6QemuL+hazjqwQEBlTJYofJjrtH204B8Wv0lv3KA29ODWIj9h tqAtWJaCa6/SbWT5Hm/MXMweYhBMP+oswPcGjKdEyU/vB5W6RoIsKDEvM2FTavC1SdSsIJKxhCo 5PBFKZ0769BJgvfV/MW5BB6Fb9b4BddFoY7uoml6Zs0BDlJR0E X-Gm-Gg: Acq92OGsQkn/gxGcq2HN9dKVqOacbrpT1P1Bs6YPf4qLpIoCxtQrTWYQwWTHlnYfJsl mCY8U3lcIAbgWSTTkaH1fQ1KPDWbimQzK2ufTPefwo3zM2s2uIWLh7/b121wyMq4RWZJvkbB0ct bOv/Zh34pkHYr0ZzBrGGQhhDRwb15DQyI1GkFjFu4MWhdPsH0kspm8d0+XfYDoP/Rucj9ETzQ2c iXHhdert8droWzntmLwlgOzSOf3URgawNBJ8LHkb+QqoGnSf42qOHPhbwIi/n/nQrlY/8X/mecG W/dGUtURQwyoUYzHWs7uTnrxgadvtJlq9ZiwKMaGdZw9lj88YLh2l6r8A8PII39Do1nbZMXsWV3 GzOKQiW84V2BdgNNL4vFZlrUDxAVR1Eckw/dspifJ/yThOPE= X-Received: by 2002:a05:6000:4301:b0:45e:93d5:7bf2 with SMTP id ffacd0b85a97d-45e93d57c00mr5545596f8f.15.1779288283733; Wed, 20 May 2026 07:44:43 -0700 (PDT) X-Received: by 2002:a05:6000:4301:b0:45e:93d5:7bf2 with SMTP id ffacd0b85a97d-45e93d57c00mr5545510f8f.15.1779288283160; Wed, 20 May 2026 07:44:43 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ec3b18fsm50145145f8f.11.2026.05.20.07.44.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 07:44:41 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Maxime Ripard , Chen-Yu Tsai , David Airlie , Jernej Skrabec , Maarten Lankhorst , Samuel Holland , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v2 6/8] drm/sun4i: hdmi: Use the common TMDS char rate constant Date: Wed, 20 May 2026 16:43:42 +0200 Message-ID: <20260520144424.1633354-7-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520144424.1633354-1-javierm@redhat.com> References: <20260520144424.1633354-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace the 165000000 magic number with the shared constant defined in the header. The old comment referenced "HDMI <= 1.2" but 165 MHz is actually the maximum TMDS character rate defined by the HDMI 1.0 spec. Suggested-by: Maxime Ripard Signed-off-by: Javier Martinez Canillas Reviewed-by: Chen-Yu Tsai --- (no changes since v1) drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index 07e2afcb4f95..74c7c3720ba8 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c @@ -189,8 +189,8 @@ sun4i_hdmi_connector_clock_valid(const struct drm_connector *connector, if (mode->flags & DRM_MODE_FLAG_DBLCLK) return MODE_BAD; - /* 165 MHz is the typical max pixelclock frequency for HDMI <= 1.2 */ - if (clock > 165000000) + /* HDMI 1.0 max TMDS character rate */ + if (clock > HDMI_1_0_TMDS_CHAR_RATE_MAX_HZ) return MODE_CLOCK_HIGH; rounded_rate = clk_round_rate(hdmi->tmds_clk, clock); -- 2.54.0