From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B7E336B059 for ; Wed, 20 May 2026 16:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779294317; cv=none; b=C8QoDe0meKecnAXYicpn4kLN64NklLK6rQYSg8Il89xFZ4rNGjR+xeCZG83iBm0wExVej5IOzdBcLbWRauhcTNd87v8abKqpYUGbzXMm435VxMUoB67ruT8+t4TpOs6LiJDSQrzoA7K+m9Ckzo5OMjR3NzIIIDLD72345WDNhls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779294317; c=relaxed/simple; bh=8VWbdGkuGsTTTwEXrzMET+OwRMV8Bxyp9scuxw0paE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f3tnr/QT7vPTD7/NU+A5/Wi6Gq8tGsSOikhSR3hHTcyh63KYmmP3jcnjH+ne/PdqNNjewIU0UYJPHmDyOAplxc+Eme2IrzK6M4j3zG2kWPDxuyPEIyO/O3eY5D9R2T13d9ph67RqqZBmRG1YqeZ5kmjdi6UcgwFBV5XdJ1j+YKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=e5vmkpD3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DOMppeBZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="e5vmkpD3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DOMppeBZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KFMUHH4115171 for ; Wed, 20 May 2026 16:25:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=uZWxbq16V5d ge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=e5vmkpD3ip1sUgb70a2Le9d6llb VQUA6OScKKmhdyq69OzkO9ba8UoJMBakH2J7V1kbk4g5dbWNUstKfq0RvtsKbuux wmffrNMGIm2ncR8iQ7S2/KKuy6DPFbT8e830RHXthlhALeywM0asQgNOZ/0FlfLl kW1+0m7POayTK3TzRBFGBWdOU183QbXDAKAO3uJPtm5RUnMU8mvjp8f3G3oUTNx+ yELyTAyqt/uw+AyblFYZLtAa4HfVE69dG6bkT9/6lLlcvijhETgwQofZwQWD26wB CXPRFC0+vWLNPoWVGS+859a84Fi5izsu/kNKlCBilHsboMawPF3k6V/wRgg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e99w0hr9d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 20 May 2026 16:25:15 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b458add85aso53122415ad.2 for ; Wed, 20 May 2026 09:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779294315; x=1779899115; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uZWxbq16V5dge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=DOMppeBZA3aCqgVh926Gp9DxFS1AkonmiBCNkjUFUTFAyKO5ZzzMzhZKfcnzmllZOM 4+OooRgMrfBeDklNCV2CoR+vfnyKjxjpm6slsWzIryeAU78QSNKXB/GynN1QkIrjEiSo 6Trh8WpgQTbgz5HwV8R7SpIpOMBozDsdOTCHJdMdxwHUJC30erMLBx1mlGR4be7ss9xY kaZOv+lE7YnOv75jQz5XYX4A55rtYBg41F+iJ8fSERJfyGD2y5+1uMpuCDPCFFhteWqC VECTG59z/9kkEpd8cM1nsbw8kAeLc2Q7mNAnZnPWil+ydG5gLIbA4CQXrN8M8CnuadN0 FwIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779294315; x=1779899115; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uZWxbq16V5dge8U1KgQgWh7So4/tb8nUVOkQSVzqIs4=; b=pYdBuBi8phatSQDIeHymcQQwb/Xf2ZiWeySONTDlYsnwdqB6w6HJhbgA/IvKG5Kc58 RZAGIMyES9J/WwqbzRsSalU/T7UvaNb4v4no8ABpB5df55qERd37X3ellD2TX6OSa2hG DhmpJVkZTHyShUHEBfEz3hoIyY/sofrl0NShGhb66v3SkOKyVXsJJSwYwP/Jpwt6Y5BG 32nuKaM42EuE8aHIG2Ec21133qd295q21Gyx5Dop08w4igXSvEkmWFoal7i99kzIyC+n A1U0oYixd0DZSODjZRQ/14E71OjIVn48OPWPjDuakz5+rcpx6KdLsNwDtl8HtMViGfWP x4eQ== X-Forwarded-Encrypted: i=1; AFNElJ9vQQ2GH1ZNZuWxEjwOYnrdZH+LMz+a2G003+wWbz/7VMOUTqH9AlvGXEU8mGyg0qE5u/NuCuWctjMz56E=@vger.kernel.org X-Gm-Message-State: AOJu0YwIXt04Ry4Phz1WCK44uISANgmF7ooHx0KPH/1tjvJim0l6D1m2 ePf6zmTKJd+iah3i0qRFuylz2SM/8VtJWN3JwyuGiLL/eKwaNoi42cXhMFDuGjlLEerwwGYUOve CV80eSneqcWxy80jNuneju6r6Kqjsto5OFHz/KmK7n1Oy9cZRmqMwC9CARXTIEQcBGyA= X-Gm-Gg: Acq92OFKVJCPm8KOwcCik5KlaYMM9K4b1T7JebNa+W/8PqI6TyE9Oov8oUemZGxNIrj lIoLVoE0UwLcdr5MFS6cnmNBYyBpoyk27w4An7IR0Tmbzl6cVLVD9HJ9hYmb7Q08HGRWqNNEKoE TylawCWHBqNas7wSdZbhS1hWbDNe/QRmyUSvRdlJYrY+h3mkPbfuvtqMY217biICz/WpTiIBxTL /fRyrqbbtCsR+QBgbOxLHQ5KYekXREJ74RKxD7dzWB489FxU0vjJofh3u+gETHFZRPgZFh/Lqku Dy3Zw+aY76AxMgk11KWsVsfboFsjh8UfIo8LQJ8F8mU2C7jcnRWPcWyxdkKBJvork4+wI7qMYTS 9MbjfLBil3kxSrDN8inZTFOYuy+++CqLi X-Received: by 2002:a17:903:1b45:b0:2bc:ffe1:c380 with SMTP id d9443c01a7336-2bd7e86c179mr244498955ad.8.1779294314126; Wed, 20 May 2026 09:25:14 -0700 (PDT) X-Received: by 2002:a17:903:1b45:b0:2bc:ffe1:c380 with SMTP id d9443c01a7336-2bd7e86c179mr244498675ad.8.1779294313543; Wed, 20 May 2026 09:25:13 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d0fcb10sm223508635ad.60.2026.05.20.09.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 09:25:13 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Dmitry Baryshkov , Anna Maniscalco , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v8 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Date: Wed, 20 May 2026 09:23:49 -0700 Message-ID: <20260520162454.18391-3-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260520162454.18391-1-robin.clark@oss.qualcomm.com> References: <20260520162454.18391-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: mLWmb9KWKxmKpIdVkveL-tQZ2BN8j1hU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIwMDE1OSBTYWx0ZWRfXxV7wI2xvlfQ3 4EdFc+BNzVGVWcSJSN7kTHPyxgnR+nKSrorIxO1Xci7OVH7rdSmkfV8pF7FJ6bAlRaKbIE+qu+d mwBOWu6NFDwG5mq+bp5f27Y03xnpgPOuB8YB56o4zYOVxg2q3EjUsmZK12pny8jit/voCDOiQmY FWfpOod+NNlyGsTwflDqrYwwzfQKb3VbCRQ+/VC14gYKci/T0uLqJVfCJLHIVtrTw/w9Tivu8pm ucGG2XGGA/y9x5Czvl8aD4nvNG1NfhQkCmwV5jo8BA/tM6WPscVnwujV8Z/btanHPPcX+wRY5pr uIaLtQxVyjuu+FFE85rt+sLGRmOG9HoxajeTptA7yTfSE9i2JW0ERJDe+iDWU46TDgp4kS4eJGw LgCeins+8+v3fTENKar+Ns7FC8nFC+ZZOWoP9vsvFnFoBjYk/kplHMKk6PY7H6DW89DcS9VA4Fl Zr3ncj1tVhXVayKZSLA== X-Authority-Analysis: v=2.4 cv=RZigzVtv c=1 sm=1 tr=0 ts=6a0de06b cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=RIk3oTIWcAeXYnX0VHsA:9 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: mLWmb9KWKxmKpIdVkveL-tQZ2BN8j1hU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 impostorscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605200159 Use perfmon_capable() which checks both CAP_SYS_ADMIN and CAP_PERFMON. This matches what i915 and xe do, and seems more appropriate. Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov Reviewed-by: Anna Maniscalco Reviewed-by: Akhil P Oommen --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 66f80f2d12f9..72b71e9e44f0 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -494,7 +494,7 @@ int adreno_set_param(struct msm_gpu *gpu, struct msm_context *ctx, return 0; } case MSM_PARAM_SYSPROF: - if (!capable(CAP_SYS_ADMIN)) + if (!perfmon_capable()) return UERR(EPERM, drm, "invalid permissions"); return msm_context_set_sysprof(ctx, gpu, value); case MSM_PARAM_EN_VM_BIND: -- 2.54.0