From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5A373ED5C8 for ; Wed, 20 May 2026 17:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297821; cv=none; b=NuoJhJ3D/72l3G72Hv/9ivCq2LZbMHKjCPjr8B2by2Nikr9Sd6X5uAsVCLzGiuWx51RtyN1RtVBoBmDK7lDRLKVR5we73QnriWMfITR6w2BdvvPZAtztUfjb+gEyhxPzoQ7JS+lz49LjgcDAKAPpg/ZDf9+XkchW/E67RcaWQO0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779297821; c=relaxed/simple; bh=pq5ewNPh6QbkE7tEQm34DFGGF2XP2Fga+Ldca3aZ7pk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UmwrlVzM4eGGGbnGILLMEDQGqyrIjnBQMqK+R8J4RO66l1+0o0G8M1eVnhGRpEeBxO9Iw5pdHC31TiAchvBXtgjWqFEsx0MnSG89ZlLNJuhzkwPaJnEwm+Zh/h/YwdVXZ4peiSEED4qU2XBCJfcPY9ypKEsBZCQtPNnyhd+AWvw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ovn.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-43d76dd4ee8so2073662f8f.2 for ; Wed, 20 May 2026 10:23:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779297818; x=1779902618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z0yVai+Va2zy8HPA5HXIs74P3GZW6aeEN+twxmzuGU4=; b=ZgHmLdWQlN6YRTIL1O5kOKHMiEFY+eTtXs2wGkOf2DVb0fe2QRZnc1N7OaZWgAgOC/ JvXZbnr38kEXlWSaaYDOFt9RH8txzIdK0u8T9Itb8VXF8zU2HfI2D/hpHUW4C32RKreB skwf95chnSQau+4YqMasNLmFWPuAyjsWwI8yHTCXcSy3b1zEPI268OnZAdm/h/TqTDxw sI79jSpmp4szo9t2sR2WUOI3rsb/tzrRCHrJGjeD0IIF4GJKEmk7UtQSrS6e7DsC4YoY uhNsoHO3oF1Y0wgkzt/oezgC1cH9N00pyIRxxqQnI98n+xQXT9j5Z7YX/+SY/LL+Fp5a NcRw== X-Forwarded-Encrypted: i=1; AFNElJ+tnhQvmIZ5nyywUZ+kEDsH1fQJZCNfuSK+BambvlMZiaajvBCaOrWviPcnncxu4fFhBA9OCBRmhCDWLew=@vger.kernel.org X-Gm-Message-State: AOJu0YyJBcOlwQyMlvW+SJqLGSQ8TcKHXr8U0SSjk7Ct28CYF2WrqhZu 179UzSD0piXHZqLlb6BAQBYfa6NCWdr1DY8aYUDsULJGe/2P49HIz8q3 X-Gm-Gg: Acq92OGWDgzFCmrId0Zg4eUrUeQo8R6FexJz8b+QH6R9Qz9bP0ucKSUmAGa+ntqYX3a BG3atDjD9yex0AEYXW9j1VNas58211t46VFvf+OmsyEOZ/ZzNWgxNWRKGDsOGopR8SAVyqVsrSA i74CijIy67z0UMFRypQ1rM4ZPWJiJhsRZ7SzAlcpN/vxhnenC1NxMzLbwrbuBbEcqz2ApnvQoId BLDIQNoxi05+aie2xw03lpkcvmSHmwKWsBW7Leeo0X8Oo1JMSDO5IcS89//h2GPNgnwnu8DmXRB 1MK1MNg4u+qMS0yKvwEuMnRjzKZWf35jwXTx2lYlrIdnbbsU4TBgS1Q8I69Uwtl1YMhVEUQEV+f liy1kQP6Ddq4y04/5doVN+0bp41hymcjBUV50qBp9ra3KSVDpNoMExlXsfKP7byAkXQRCLswjWh NxlmezSEzGghW6tpIhJynrJdfsBZ+QfNcODkvX5JrrMPCPcqX98RRew8MZooM= X-Received: by 2002:a5d:584c:0:b0:439:b8b2:fabc with SMTP id ffacd0b85a97d-45e5c587396mr38222091f8f.21.1779297818305; Wed, 20 May 2026 10:23:38 -0700 (PDT) Received: from im-t490s.redhat.com (89-24-32-159.nat.epc.tmcz.cz. [89.24.32.159]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe0fecsm51125580f8f.26.2026.05.20.10.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 10:23:37 -0700 (PDT) From: Ilya Maximets To: netdev@vger.kernel.org Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Donald Hunter , Shuah Khan , Kuniyuki Iwashima , Kees Cook , Adrian Moreno , Jiri Benc , Nicolas Dichtel , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Matteo Perin , Ilya Maximets Subject: [PATCH net v2 1/4] net: netlink: fix sending unassigned nsid after assigned one Date: Wed, 20 May 2026 19:22:35 +0200 Message-ID: <20260520172317.175168-2-i.maximets@ovn.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260520172317.175168-1-i.maximets@ovn.org> References: <20260520172317.175168-1-i.maximets@ovn.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If the current skb is not shared, it is re-used directly for all the sockets subscribed to the notification. If we have remote all-nsid socket receiving a message first, then the 'nsid_is_set' will be set to 'true'. If the nsid is NOT_ASSIGNED for the next socket in the list, the 'nsid_is_set' will remain 'true' and the negative value is be delivered to the user space. All subsequent nsid values will be delivered as well, since there is no code path that sets the flag back to 'false'. Fix that by always dropping the flag to 'false' first. Fixes: 7212462fa6fd ("netlink: don't send unknown nsid") Signed-off-by: Ilya Maximets --- net/netlink/af_netlink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c index 2aeb0680807d6..0742e97f256e4 100644 --- a/net/netlink/af_netlink.c +++ b/net/netlink/af_netlink.c @@ -1482,6 +1482,7 @@ static void do_one_broadcast(struct sock *sk, p->skb2 = NULL; goto out; } + NETLINK_CB(p->skb2).nsid_is_set = false; NETLINK_CB(p->skb2).nsid = peernet2id(sock_net(sk), p->net); if (NETLINK_CB(p->skb2).nsid != NETNSA_NSID_NOT_ASSIGNED) NETLINK_CB(p->skb2).nsid_is_set = true; -- 2.53.0