From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 488F13603FC for ; Wed, 20 May 2026 20:49:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779310196; cv=none; b=PIGmrj0Czru5qbVlWWP+7pRdhJ+YApjHbJnrWhOA9F0V5HqikQKKxrhK9wwAHvMdGoWg/njvo+GZOm0WgKOYFvCmdOTXGNjnBmuwT0CTcm3/X0GMGpPpzqMGhx4PtCuUlM1Iv9PT2ChPr63UmdFD0E+K6wAycUNFvtFCtkjAdyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779310196; c=relaxed/simple; bh=9CAsfM7KLu52yrdWqJdHkcolcfG9V6vCGTohj393onM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=fgzv7XXGNuZ94X7iJxYlu/xqNPAJooR0hW6xOWqetdu7K6DeitA35UwMqamCvKCIbb1rJx5JFQsa3xZG1Eg7sw5d/U+xwKfUCVnNkcApUhSrbN7cw18knkgA7EN6l3XYDzmIpQ+DKXPnGipTdE1pNXGIWDsa+xK+T0iikdnwOzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=bH0ipUbE; arc=none smtp.client-ip=209.85.128.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="bH0ipUbE" Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-48fed2519daso28301985e9.0 for ; Wed, 20 May 2026 13:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1779310194; x=1779914994; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=mkaEL0dtEh5vLkhnum12HiGQZEgLNqcEhlclJBj/jfs=; b=bH0ipUbEP1akSdNWWiWgNoc/OGi6DcgFbSNJlEkDz4Kmgr59ZAh+K4ejMQKY+lqTI8 +qFsVTpSMaUeqjaOnOLx+XVcmD5UqaKGL5mF6SB5UuiDzcG0iTUlTso7PnLozCvpkOV1 deu3WCtPev5A3id+TrH35dwe9+Wf95lJPmovXSO35WSGvxpUecbkMJzplj3nI/OdkyCH mqsBxQUVCT3RMz7imJOf/fkWvcQIxAF6RJR+pVaJijvNt2MwMk8y5lf7lvKJq4BtUtHx ZzVkKkVuOBZSozfZHlJLBVBqrt/stbFIqsuSGbwSN7+CE8vOAemH5giqiCwP7d6qPm4G xssg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779310194; x=1779914994; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mkaEL0dtEh5vLkhnum12HiGQZEgLNqcEhlclJBj/jfs=; b=WZT2MqzfpTNlV1xjGJqR/eA62q9WCu1bij/R4lYSbPeZbSuAw9EMsFxGODuCG/6V9e 1m1sqjOB0FtmUie/whdp4yVJgAhQaiOz1TAgB2SrxQ6xCoKg1x3tQ/nlaU/ceQdvfjjU arc8iy9yvPtz4WYgYS2h6zahqhEJJH4Kjp4MXUD/qnHd9VJYWkGSNGyuREbloe2X8Tji UH5K1l9+NCg8vbclZUkoeW748iy3Hi/XfNN95Og+Zycxns6tJr+iQRq9rlw4a54rh6z5 3Y/PjiVUAGwa7/6/Mfa67YreNUm7FFlIqM3OF3cU8x463jWwe/e421af6t/ZG70Re8Rf xeDQ== X-Forwarded-Encrypted: i=1; AFNElJ9QmOQINZw3daIDA9BsukmTLBmazqikWlxygO5vw4yeay2IiFynT5B8WHt0DB2hYJr7oxG59/JepOyhxTI=@vger.kernel.org X-Gm-Message-State: AOJu0YwHrzgbtMraC5uwj3wZbro69Nu98xmX0Z3DbgmKapPAwDWj+SEm FaOIyj/ALPpI6RaHOY5dhbT0Qhm1SUY2VNbFtRRL/XvX3W5nJQTCBePLVRF6uu2iXztzBFf/KRh n3l/dV0DxDt4Tzw== X-Received: from wmoj17.prod.google.com ([2002:a05:600c:4851:b0:488:af7f:772a]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:a00f:b0:48a:5301:bb5c with SMTP id 5b1f17b1804b1-48fe63263dfmr421319785e9.16.1779310193872; Wed, 20 May 2026 13:49:53 -0700 (PDT) Date: Wed, 20 May 2026 20:49:44 +0000 In-Reply-To: <20260520204948.2440882-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260520204948.2440882-1-smostafa@google.com> X-Mailer: git-send-email 2.54.0.669.g59709faab0-goog Message-ID: <20260520204948.2440882-2-smostafa@google.com> Subject: [PATCH v4 1/5] optee: ffa: Add NULL check in optee_ffa_lend_protmem From: Mostafa Saleh To: op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org Cc: maz@kernel.org, oupton@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, jens.wiklander@linaro.org, sumit.garg@kernel.org, sebastianene@google.com, vdonnefort@google.com, sudeep.holla@kernel.org, Mostafa Saleh Content-Type: text/plain; charset="UTF-8" Sashiko (locally) reports a possible null dereference under memory pressure due to the lack of validation of the allocated pointer. Fix that by adding the missing check. Signed-off-by: Mostafa Saleh --- drivers/tee/optee/ffa_abi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tee/optee/ffa_abi.c b/drivers/tee/optee/ffa_abi.c index b4372fa268d0..633715b98625 100644 --- a/drivers/tee/optee/ffa_abi.c +++ b/drivers/tee/optee/ffa_abi.c @@ -698,6 +698,9 @@ static int optee_ffa_lend_protmem(struct optee *optee, struct tee_shm *protmem, int rc; mem_attr = kzalloc_objs(*mem_attr, ma_count); + if (!mem_attr) + return -ENOMEM; + for (n = 0; n < ma_count; n++) { mem_attr[n].receiver = mem_attrs[n] & U16_MAX; mem_attr[n].attrs = mem_attrs[n] >> 16; -- 2.54.0.669.g59709faab0-goog