mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Changhuang Liang <changhuang.liang@starfivetech.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	 Brian Masney <bmasney@redhat.com>,
	Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	 Emil Renner Berthing <kernel@esmil.dk>,
	Chen Wang <unicorn_wang@outlook.com>,
	 Inochi Amaoto <inochiama@gmail.com>,
	Alexey Charkov <alchark@gmail.com>,
	 Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	Keguang Zhang <keguang.zhang@gmail.com>,
	 linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org,  linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 1/8] dt-bindings: soc: starfive: Add StarFive JHB100 syscon modules
Date: Thu, 21 May 2026 09:50:54 +0200	[thread overview]
Message-ID: <20260521-awesome-tidy-tench-eeee8b@quoll> (raw)
In-Reply-To: <20260521012932.24163-2-changhuang.liang@starfivetech.com>

On Wed, May 20, 2026 at 06:29:25PM -0700, Changhuang Liang wrote:
> Add documentation to describe StarFive JHB100 SoC System Controller
> Registers.
> 
> Add the PLL clocks for the sys0, per0, and per1 domains under syscon,
> as well as the PCIe RP reset.
> 
> Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
>  .../soc/starfive/starfive,jhb100-syscon.yaml  | 114 ++++++++++++++++++
>  MAINTAINERS                                   |   5 +
>  .../dt-bindings/clock/starfive,jhb100-crg.h   |  12 ++
>  .../dt-bindings/reset/starfive,jhb100-crg.h   |   3 +

Probably you should have own headers, instead of reusing CRG - CRG does
not sound like syscon, so these look like difference devices.

Anyway, if you decide to keep them in one, don't change your mind later.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof


  reply	other threads:[~2026-05-21  7:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  1:29 [PATCH v3 0/8] " Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 1/8] dt-bindings: soc: starfive: " Changhuang Liang
2026-05-21  7:50   ` Krzysztof Kozlowski [this message]
2026-05-21  1:29 ` [PATCH v3 2/8] clk: starfive: Add system-0 domain PLL clock driver Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 3/8] clk: starfive: Add peripheral-0 " Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 4/8] clk: starfive: Add Peripheral-1 " Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 5/8] reset: starfive: Introduce active_low Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 6/8] reset: starfive: Add syscon reset driver support Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 7/8] soc: starfive: Add socinfo driver for JHB100 SoC Changhuang Liang
2026-05-21  1:29 ` [PATCH v3 8/8] riscv: dts: starfive: jhb100: Add syscon nodes Changhuang Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260521-awesome-tidy-tench-eeee8b@quoll \
    --to=krzk@kernel.org \
    --cc=alchark@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=bmasney@redhat.com \
    --cc=changhuang.liang@starfivetech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=inochiama@gmail.com \
    --cc=keguang.zhang@gmail.com \
    --cc=kernel@esmil.dk \
    --cc=krzk+dt@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tsbogend@alpha.franken.de \
    --cc=unicorn_wang@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®