From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFFB23DD860 for ; Thu, 21 May 2026 14:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373562; cv=none; b=kLDQI5UrZiyohdm0Rcgx06bUU7UWtZXyaLFCHmruhASmHel4jZStiJ+9HvuKQjpkzBbPby9f8+ES66QPXxHySjuXyjCZ8O/6wNbWkxTqGhG7go3tN3+FNLNyR/IbAm3UzG5avBT1euCk0zAIjuFiRqhE5qoEZnXvMCN93wbmRTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373562; c=relaxed/simple; bh=QqJ2lXGWEweh2aOOuwI59KOnCuRsg1zkqXgi+9+Hm0I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Diup94wzIajMHY4zt7+vvVmVNP25SHDc2ZmR7ERYnPBuNc/UisAoGHieZCRZczwvYJQiMM0uCipqcUyVXYVxl5wS58o7vDP6TEimeRug2fbHpKr+C8Z88ZaoEtPqSgkvSEvl3uqqsxKwJZpdRw1EYIE9MAcmsote0QFNOVmIXhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=E+P3BQK7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=KBk7iqmx; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="E+P3BQK7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="KBk7iqmx" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L9A6553452608 for ; Thu, 21 May 2026 14:26:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j//l8LhIXKiuUsuQE/OLOg9z4wTTm077JUqHJYnpL9k=; b=E+P3BQK7pKztyq1B VgonQSRkTCq9hnqi7tjyhZyrO8nrGaSoGptnfMrfwMiq4AGsQOzSF4xyQYejzspA H9xhzuoRjeTapbuTh6KKhyJ2Ku0iDn4e37ucbZCRNdMyXMcRqxaCrhrRrijtgkOs YdZj4hOfJUOVXpnDzaA9EfMUs9jtxPyulxlGn3ojhLTsEgHVS01rf1Meez3Waxna InRtLThUsiJgW/j2oaQOkgGYzHBwN0QwNHYQBR/YJyQFmdWljU3LAWe5SqTO9dxh +mjVxJyrIdzU5gfEQ7bQ6nteWoBFWxIQtwEO2QvNKhafe3o6FfeP22sOf9qgqggD OLc7/A== Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9y1h99er-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 14:25:59 +0000 (GMT) Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-69d77a8f5caso466654eaf.3 for ; Thu, 21 May 2026 07:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779373559; x=1779978359; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j//l8LhIXKiuUsuQE/OLOg9z4wTTm077JUqHJYnpL9k=; b=KBk7iqmxk60ecL6vMuLZ/lRwmMpB3RorYsBWvdQf51nC6jVmL2GHlKfOGeJ7nlF3i3 L10akg7f+q4gPD2QN/yXo3ozO8Jzw1sYXqLmMKLUxWtrJCsgHzmxLkYtfeki4PR8XXsm jROFHwgT58lY3QJphlbRHi0B9trsgICw8uJVjZBxv26aZ/g0rOAmbnrt/8HcsSIjNvqe oLxVfwEHgykpYKHVqDLqjyCK6Yu5C+BFRsgWVNJ8r2DGW6ZykKMK8v1fpJ1ol4h5YFaN d+ZuKznx/6jvo/QZEhb2G8WvnDgKC+uihTtlSBY3C5sb4iY+NyatZ14pWlW0zzqA6QSN bm+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779373559; x=1779978359; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j//l8LhIXKiuUsuQE/OLOg9z4wTTm077JUqHJYnpL9k=; b=U2EFJcaIcFwHWRiHmrOYYxqeXiskiuDlh7pMehGsR1wGAD2IFHG8DJTx6WaBLY7qXs hkRlqU5yK9RRtRQXFIhEAHHxFoVd74i4EM6rexHYycvDzZYeo5QgGefU07iUayh+eHLE n3p5c1g3qktkfeujyYilsNvM5dd08kH5oa5WBxSzVOnJ94KgxldSfecgsVn4ZQukOdgA 4dSS2Mym+wqfRuI6O/lFdTomxPpvr2zxnSjFPc+O6Il1hKGIG0XzLJnbZP0HkIpy0rf4 VWXRs/1G4t5E/4rjO9zqYtWyHm0Z80QoyGOoMqeLmqeHYGLfUuMnWCBQlpSkveYesWub KiXQ== X-Gm-Message-State: AOJu0Yz7eoY6aWQW6UHihrPHUnLh4FiZHuHOjBzDkv6frit0NynPxEue hh8kga1K+uJIvcAu/7+yhABMN0U7NkConcWmI+2WjdBatZvgLEijH2dKikJ+G4VTulKfeLVbKcB c0WMf3S9KpfhOiCL/DC1WoIjdmQMZOoZdSl/SVdJjaL7ReZRoJ2RXwlO2ywZg5GHXe0s= X-Gm-Gg: Acq92OGaIUeT5k48ra5HXts5JDw5jRvDaCZhyx3yH2BlexhrGfyom/tkXp18Wx9d13m Sc08ez4mlFhHihcQB7fSIHG8m1yPWZJ8o3/NSJCDrrGG72SHDHdVHP/3lrMREYIcvPQWSIg/Zm0 xw4l66wOKSeWRMHkBu85WIKAGqXdpDLBAfDgIgFQuovuVuP1Y13L3ayjZVad+CxvEtMq5CqEwhf oN4sA0pz+I3IPXHYwkwHWTBQPkRwEOsU0VHlTyTEB917aPBsEFk61JYrrZenBqllX+r+Y4sqb+K 6nMDz+VvgtWRbe2pfTmfDT+4Q6paIRJH5lBNVCxK9IZiOekAonXn7hGLxGmEaqUgUqe7q58QK47 otuSj7jGtN6l0YEkLCR8Co+4asSw6xi36yOR5shsTPgz+XnYwPvI= X-Received: by 2002:a05:6820:81c8:b0:694:980c:9610 with SMTP id 006d021491bc7-69d6ee42b8amr1518148eaf.21.1779373559121; Thu, 21 May 2026 07:25:59 -0700 (PDT) X-Received: by 2002:a05:6820:81c8:b0:694:980c:9610 with SMTP id 006d021491bc7-69d6ee42b8amr1518130eaf.21.1779373558746; Thu, 21 May 2026 07:25:58 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903c9abbadsm30441925e9.8.2026.05.21.07.25.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 07:25:57 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 16:25:37 +0200 Subject: [PATCH v4 04/10] nvmem: check the return value of gpiod_set_value_cansleep() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-nvmem-unbind-v4-4-7fa136759491@oss.qualcomm.com> References: <20260521-nvmem-unbind-v4-0-7fa136759491@oss.qualcomm.com> In-Reply-To: <20260521-nvmem-unbind-v4-0-7fa136759491@oss.qualcomm.com> To: Srinivas Kandagatla , Bartosz Golaszewski , Johan Hovold , Loic Poulain Cc: linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1426; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=QqJ2lXGWEweh2aOOuwI59KOnCuRsg1zkqXgi+9+Hm0I=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDxXnqEOW7hTB0ALywllcpwysG0t7ch9/Kqt+D 61U0Uqf+6eJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag8V5wAKCRAFnS7L/zaE w74UD/4xF5B9JkK7TxoMFKbgEprddLaJqfudi+7wEXKtOEprGTQRbi/3vgLBHxn0IjI6fhaZK8Z D6tj5JlWN7O1PFpn0BdDW1UUaJA86IXox9TQsh1yKsUG4Bh26Bd5dAJZaOjp/cphaz7TVM/UrTc 74nV5MS15kUKG6luHiAVEnKSnQSYERKfyy21LWOclyqrHMqMbIV85qIY5JwuRInoL/GhPJOE9eq Jz0/XVU5G/tbzo5iJX/yKbXtjbIrBfCb95lZEramIABvyeZR5o+uGNFY0BGjEOnYMhx6DjAelFk VHsi0EUL6JW1EilAUK4BD65s9XlBRDHbs60W89DjoXtYwJBG8ZNIrXe54Zc+1L7ckVnBA2BiMKv teFfx5lqC4p2OYz8Cplq5rUIqXE7EVUPROF2X1n9DAabcYHCl6RKmJfp9YcW7GUcbJl84hSQCPn cVw6lzaRrOXkOhcTQLk4XCOFx47CBwdUfZL48ROEWZ828iRRSRnprrpE/dLiA/reny7QMt2+K7o Kzbb9Mh6UDTExLyGenOeTlm1ez2pHDHWn87hfd954ZLeM0vuHX3phjJoPQVqGb8OS8pnOllCc03 NNwovcDI8MbdOEFHXt7VH3UiaJuSNJpdfeOmJkGP5ZU5OW8qbJORGpLdbqRACI8je9AwhfsVK4n AwHIoankeZcD+Ew== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-ORIG-GUID: ww6wSA_s5OUTggthBg26_TBgIEHZaqqr X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDE0NCBTYWx0ZWRfX7V5Wqt8dn0W9 Xp3QpTVGNIMBgAmCXuxeS9vEmSHHs0qkQSd4+kk77m0qv6GAWRcVYz8HmIAgBgKvg/XvgDA5K7h PVn1a38gJKCnFtLnTgoxSQDIGqDqKu/iIab5cuGFTz2qPrRrEJEvKHQ5i/i8C/U1jzyYohjBYv9 e73Ecev6LHrAHsiGbQAs1bhuMvYfmYzIF8tgjfx0yCyLQ9WspDv+N37157GDKXdt2A0ndi+VA8t w/CoEGDq3faYCbRnkztGbKWAeYtS4OxzvSXJPTmRgVm1qRXhU5BvDcXoHdLGfeA9b39U1cZ6FHC brF3/o85nlhQMrFkFnqLwrq8kOXJ7tOfAakX9dWz7X35uNVUBPyPy7XOVOSEVXlGkBD/9gTcEsZ ImMs+17OI9tUgkIMYaBYscsWeSllH8G2xeIiPgXT/q/ukZ8nm6s4NNuWRBbn79wc0UlEaLcsvkX 9Y99lTWughITamIXIIA== X-Authority-Analysis: v=2.4 cv=YfyNIQRf c=1 sm=1 tr=0 ts=6a0f15f7 cx=c_pps a=lkkFf9KBb43tY3aOjL++dA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ii2iuPLuu9iRZ_mRmhMA:9 a=QEXdDO2ut3YA:10 a=k4UEASGLJojhI9HsvVT1:22 X-Proofpoint-GUID: ww6wSA_s5OUTggthBg26_TBgIEHZaqqr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210144 GPIO setters now return integer values and can indicate failures in lower abstraction layers. Check the return values of gpiod_set_value_cansleep() calls in nvmem core. Reviewed-by: Johan Hovold Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index 06d7f3d819084579434370cd12c6b263abff196e..bf5dde6288cfa75cab4040c6b93e3376e87fc691 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -64,16 +64,22 @@ static int __nvmem_reg_read(struct nvmem_device *nvmem, unsigned int offset, static int __nvmem_reg_write(struct nvmem_device *nvmem, unsigned int offset, void *val, size_t bytes) { - int ret; + int ret, wr_ok; if (!nvmem->reg_write) return -EOPNOTSUPP; - gpiod_set_value_cansleep(nvmem->wp_gpio, 0); - ret = nvmem->reg_write(nvmem->priv, offset, val, bytes); - gpiod_set_value_cansleep(nvmem->wp_gpio, 1); + ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 0); + if (ret) + return ret; - return ret; + wr_ok = nvmem->reg_write(nvmem->priv, offset, val, bytes); + + ret = gpiod_set_value_cansleep(nvmem->wp_gpio, 1); + if (ret) + return ret; + + return wr_ok; } static int nvmem_access_with_keepouts(struct nvmem_device *nvmem, -- 2.47.3