From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ADD13D7D66 for ; Thu, 21 May 2026 14:26:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373569; cv=none; b=EJoO3ThKNN0zvofqGySWd0C1fCBi7RfQZre9Z1Otn5yT1eGoQtn0fsNiEZny7leo4FEd0XCcq1QIJfpj11doLq+F8Zt75SbCCBN2UgMa39qVgyzQXUJjSaZ3iBPlkWGP4O6FBVrhv4iVVr1g6ZUR3MX7dCu0XaYM0IESGZLV71o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779373569; c=relaxed/simple; bh=chJcYNUNvWdVCm11FwsO0RzQtcv7xjcWc6VBYeH2TDs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AR0bvobeYbNqGPZdh1b7pbn8AXtgNqOjFXj7D4LwJi2boSakaG8hX5YXkZhw2/pKdXIajKzpBXPYmGZtMgs+X7iKPgTuzWKy2LsYjwwz98OqEC2gEQgAtyJhtB5uxYbadqqxs/zBkrPHRMaKmJPglC0FJ3qxHJL1JyEopPsf7EU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CUs9e9gu; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bEdQPOao; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CUs9e9gu"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bEdQPOao" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L99jHq3343451 for ; Thu, 21 May 2026 14:26:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EvZykmHWOkKG/QwXU8TG+tCYJqQVPqu4JMOWn5jw9rc=; b=CUs9e9guF4lQhVoo MMuN829R8bEP2XTypLAQwfjvrFVAzTxxQqLicW7nUdVQ5trdn42lFT4GUEgCeM56 0LycYeHTGeG965C6EEQ/Gkf36a6b+cAf64cL6VB5EyBgTIEdzCcBwlJjn6JGBLO2 CCQAtc+ITnyyphcltLKcJHHK6H7r+8xvfO90xDBkDIj8X8lRaPs18wmhf8gEP0Pj pxHvM29nAh6ewAJQL1evhAaa2M6wMjcZksoCia1nmmc2L6rT9HjHcxUS0zdTC36V mJ3J6FVD2bwpEjAupynXx7xaeDNWPWuEtu53IC0szUC62nL/yZZPNidu5EOrXhXg 1R7dIA== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9wahsrns-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 14:26:07 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-63146b7289bso16546841137.1 for ; Thu, 21 May 2026 07:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779373566; x=1779978366; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EvZykmHWOkKG/QwXU8TG+tCYJqQVPqu4JMOWn5jw9rc=; b=bEdQPOaorQ9WW4Lop7M5z+CRV8O6EhP26cjh4nbK1TfvrEPtxAdgICwKyPpPfVY1ZP X4hN1c1QFMIpQhyVySD07x0/ug/oF/teiIEb0YgRIUSzl232Yezl0ZTQMqjokADF7P8f 4bc4jfeaP7nAQqJ2/COqXTQrfevgGThz5hSKx6UgdNr8VLlKofH55L/SCOUr666o6TZ9 5had0Q5btt8XmFxO4/1uJfnDSjCWg4W9Rkx5N6bXc1lP4yusFz8yDKVvgIGK3n5KDv33 w7ZMGvrUmBqf7JMBC6Pf8zZ/6MUxp5Bc/J3nGGy5H0uEGlOWYEqBwr/zISphY/LYGNZi ONow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779373566; x=1779978366; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EvZykmHWOkKG/QwXU8TG+tCYJqQVPqu4JMOWn5jw9rc=; b=eRpU4Gf7ChkeSPSNgLeGjgSOUsr+kg+y7PNTkQ1GQVqQwbkNOgRCCtM8UzTzYsKhTW tXW9seWqJ7khvL+i6nfvrIPZn+6WZNAaa/y9aAisLYjTnorIyGSFiPRF6L4RewiYR7KJ xYNsXPWKxdM+N3NpQAmvO9hW3oBn596geCjr6SRF3kWKSre977s62AwJrMQZVDW9yjWl eXF2b5dDHQRzV76b+Rg/PiCvW2iS+fmwYjO/1mNRrqEh1FUB0+5e37MJkSKUzMGLUZph XfM3uxvfVJXGbwjKTYyBTOLGzb16aLEe+a9vQi9PV6NXtsD0FZx4BjmMPzH5f1FyEIuV rysQ== X-Gm-Message-State: AOJu0Yy6XphkoAMZYFtOXsGKseLRgWo6hikLDzZA8dad4vbnAIu0a0qA gqAqSUm2gmyUhhleiSQMMoSJns0Rr4fKIk6ARTVDNDvpLNJvIxKOwxelo4yPbSZF13DBN4KZw76 Ek8Oz38e5/uTxu4kJ5H6L62SYrPT0n/nrvMLS3PYtFmG7L7aRFY6Y89O92FES3DQRrRU= X-Gm-Gg: Acq92OEh8y5+97gv+ZLGMpY4dUlS55Q8PZig9nI1sC+c3PeKiSE5NZBSiwv6SEqiqZ8 u7yXMt4PMwMdOXp5dWcf9+vgIfzcXCBOAebEbUmhJZWPPYGjtq6++Mz4/cTy1D3ShzK1GNEz2EF ibBzDre4+iQwYbB1cGfhkuN4NitFJOdYaiMuH49R3r8DnVZ2KAvcez3lgKJQzTNUySVQmx3dv6X n7mCC9gengiax25LqtdYKbjcBRWN+CgXbiiJU9sUmiDxpTJt/ohYMp4BlDFuOkvyAtJ2sZIwIxi N545qTtB+zPcCfY32X9CyUXqFc/2HKPID8gx7yfb+O4jmRZrR+mRuKagocfx73i1wYke6cBpFE+ fdAq2OOUGoJeDqz6p4/r3tRnBuDWPjW4vQBs4toRXi+HCgzYs75Y= X-Received: by 2002:a05:6102:a90:b0:633:bb15:28ae with SMTP id ada2fe7eead31-673cdbe983fmr1076033137.15.1779373566142; Thu, 21 May 2026 07:26:06 -0700 (PDT) X-Received: by 2002:a05:6102:a90:b0:633:bb15:28ae with SMTP id ada2fe7eead31-673cdbe983fmr1076004137.15.1779373565754; Thu, 21 May 2026 07:26:05 -0700 (PDT) Received: from brgl-qcom.local ([2a01:cb1d:dc:7e00:bb10:ae82:b7c3:d15a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903c9abbadsm30441925e9.8.2026.05.21.07.26.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 07:26:04 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 21 May 2026 16:25:41 +0200 Subject: [PATCH v4 08/10] nvmem: simplify nvmem_sysfs_remove_compat() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260521-nvmem-unbind-v4-8-7fa136759491@oss.qualcomm.com> References: <20260521-nvmem-unbind-v4-0-7fa136759491@oss.qualcomm.com> In-Reply-To: <20260521-nvmem-unbind-v4-0-7fa136759491@oss.qualcomm.com> To: Srinivas Kandagatla , Bartosz Golaszewski , Johan Hovold , Loic Poulain Cc: linux-kernel@vger.kernel.org, brgl@kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2068; i=bartosz.golaszewski@oss.qualcomm.com; h=from:subject:message-id; bh=chJcYNUNvWdVCm11FwsO0RzQtcv7xjcWc6VBYeH2TDs=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBqDxXsYr5q2sxkxKUNNZtXNc1b7A1LCDpwAcnl7 7eDUvNS4xOJAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCag8V7AAKCRAFnS7L/zaE wyKVD/4nF/xuahKL7AzoU4y0aSepsRD+e2yz/CFNt8Zmf6hpCG55l9ioOTW8Xgyap0E+WT7cj7X LyER471eZsfFVKdRQM1PySx17ug2O7OUvZMZJW8g96WtY9Up6w6Ffm7YyeHHQp6QK9MMW6YLP0t hB1Mmr/ieZc0Zv+uYSTzDjQLgbEEMmROYiAkvNwl4nX/S559lAB75G+scEy6J0yz++0105BfRHO G1xDvTH9o6DoaRCBjW3EtQlUUOmOEkVZba/io7Qb6Un75peY1r0xgBSD0G6CFIgb2NqRUQjkIPV ejDo/59qhKawaSudYaqyX1yhPIGzkvZIjYPSUN4UAJleXtqUGabdp3CdOgHUfzQT9e8dsAmR73e ieUxNElRnVyAS8xKUgctgTICMrICRacJmzUNmXI5Rw1fSdL+jYIw4lssYtOcsfYLmg5e5NIKh9Q 12CZkEErapG/5by1ZSMGAQUV8wmYjBciTqLzv1raD4cPsetYpCnARMAWoGOtwLlXHgd1TtTMVIm kvZPmqvpQdvhdmwMTc6RBjB8E82U18w1ulNI8BO0unvNY8SY27UukKckpjnUbE2SVH1yQB3OLtP Ky5WR6aq4Mo4ozAdiBqM0eUek5xqFg5E+KRa1gPTvKPB5pcIMzzvwe9OFF3q6/skMKB/ZOUdo0c 6eIWzHxw+/FFgWg== X-Developer-Key: i=bartosz.golaszewski@oss.qualcomm.com; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDE0NCBTYWx0ZWRfX6z5lacgTd0mS 8Xmb/jqbj4Ey4WxIfuVvQms56tGglR5tLkUet+v1V2JXQ0oqh2ieZTJCPIsTMkw0YWiXbaZSwAw GTW4mcF9NOCPYPGNYvO0G06zH91/V3Zl7/xGcu/SjD5s9TZp+98Xg7D7Mrg9fTZPPgR6udEUrzO PU3DxqnmSRVq+KVBO054CNhi0wqNOE9QaHLprNJ5GXXkUQ0dX4Ntv2S1nyZIX9+VmFgmCNzwhWG z4tTXdJS6n68na3gG1L8GuW0CO0FperpXDpLMnR6MmmbW91TYnQXTFcW5pJlwHci8DpMleooWI7 zgn/NnWGETFpkiP5R6CvTeAGgHB7/xRVITUVUFNLdWZaqRhEQ700V6nh7hVy5kMw2Ghg+hJLJX9 5+ddjxEf9deZSbMNJmyrHYlAyv322rxZEyw75/Dvhvm7w6uYbZhbIonH3kGRW0zUX5q5PVMOhqu plGKzx/MoU/fj28yU/w== X-Proofpoint-ORIG-GUID: O_fjj5ho0smdNdJI4vJKir9NOC2weqJk X-Proofpoint-GUID: O_fjj5ho0smdNdJI4vJKir9NOC2weqJk X-Authority-Analysis: v=2.4 cv=H8LrBeYi c=1 sm=1 tr=0 ts=6a0f15ff cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=vscgUUECmMDzLPOjfHYA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210144 There's no need for the config argument in nvmem_sysfs_remove_compat(). Once the compat attribute is registered, that information is carried in nvmem_device::flags. Rework the code to always query that field and drop the second argument. Signed-off-by: Bartosz Golaszewski --- drivers/nvmem/core.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c index b6429aae99e0deef502b1929debc47a09986925d..c59c5f0e8a253eaedc0c6b180c7273a6c53ee1ac 100644 --- a/drivers/nvmem/core.c +++ b/drivers/nvmem/core.c @@ -460,10 +460,9 @@ static int nvmem_sysfs_setup_compat(struct nvmem_device *nvmem, return 0; } -static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem, - const struct nvmem_config *config) +static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem) { - if (config->compat) + if (nvmem->flags & FLAG_COMPAT) device_remove_bin_file(nvmem->base_dev, &nvmem->eeprom); } @@ -530,8 +529,7 @@ static int nvmem_sysfs_setup_compat(struct nvmem_device *nvmem, { return -ENOSYS; } -static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem, - const struct nvmem_config *config) +static void nvmem_sysfs_remove_compat(struct nvmem_device *nvmem) { } @@ -1052,8 +1050,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config) device_del(&nvmem->dev); err_remove_cells: nvmem_device_remove_all_cells(nvmem); - if (config->compat) - nvmem_sysfs_remove_compat(nvmem, config); + nvmem_sysfs_remove_compat(nvmem); err_put_device: put_device(&nvmem->dev); @@ -1069,8 +1066,7 @@ static void nvmem_device_release(struct kref *kref) blocking_notifier_call_chain(&nvmem_notifier, NVMEM_REMOVE, nvmem); - if (nvmem->flags & FLAG_COMPAT) - device_remove_bin_file(nvmem->base_dev, &nvmem->eeprom); + nvmem_sysfs_remove_compat(nvmem); nvmem_device_remove_all_cells(nvmem); nvmem_destroy_layout(nvmem); -- 2.47.3