From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7A830B53E for ; Thu, 21 May 2026 01:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327755; cv=none; b=MAlPTCcSwuELmulP4WtZYrsIZhsIIOIIZ39JRBSEs5bSVOD2bwAZik4K75SGUTKz/bH7XTYdoy0dexm35lR2gKBvWi7FsNsh0zdSANJooVcFP5x3d7EyVeEUYoHMqX2cwHiYke7AtGMwr1Zaram9xUhw0fqNLmauAS5WZH5rRgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327755; c=relaxed/simple; bh=6JoQIiAIGXqqZ0vwdOHhCj00rky64V9x71tQ6RgnMRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gFuAqtiKP7RAF9LAw5ryMS6Upil3T/l0AacPvjZbP2EWZFwRyCd11PUv5IDTR8xa8HkpM9smKR2kBXAZBemRdABUTTEKa9Omvaw8txXGBIznsBgYgHCESJDy4CWMXkpO2/xtsOmj9KUgo22Ok793yeSzDjvkArsZy7NE9qny1fM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ahX57yQc; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ahX57yQc" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82f8b60e485so2320088b3a.0 for ; Wed, 20 May 2026 18:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779327748; x=1779932548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FvAmAAUyg29fjUnqu9RUZPsKZgJ6HPQPiJ0VSPtg5Wk=; b=ahX57yQcW8++OL2hyFQ0cjTHmy77YVQHG6ZENvC9uk1ywVAcSkN9ifRiU2Cbn2bXKJ EspqkjzjsRVn5XwQPbmpGN+KQDTmfsr+qEkw7FG+9B6A8NG3EPIXJDGE+QBC4CfVxlf9 qRTDuUq+xM3uJipLhosx5BIqdpZGNahs4TgsMaT3Ei5qproWi7GUZILPCfAQxVfhpRh+ tyTd2iIImK23FwcimovZsbqt8aAEetNdvzKnje/BJ1NB/3VTtOMCU2rolV1gut2JriNJ cqzJHvAGwdcA+lFsjy3fqxtHJhBXcuxxNHCVYH44geGMZHqgNj15Bldjg0QeWVTndHVH 2lzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779327748; x=1779932548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FvAmAAUyg29fjUnqu9RUZPsKZgJ6HPQPiJ0VSPtg5Wk=; b=b+tePx2CCqwsS0qC5xmmMCrb0Ln7NILh/h/ZPD5jRsKFi9mOgR2c1Csvg/QewzqBWp h8NWXTXI3PvO6NMq78mEw7fHsLrzVLdOUxZSUMtvT1PPxuyo7MYYDYKVZxAXkpvLSeGH I5uFuWCwhP9FKApgWRBPdpa7qUqNIwkl1T16D6V32GAwggR4sikxwsIUnn9BNYqZC29n 649EKqhgxN4BNIMHKSZJtU3soH7qPzLX5ucAoImvHOxz45gpaIE+VWjjac+joXHQTH4R Q8TR1h6Lm4WKdetxJlw5U+UtOl1wvfhQrhOWVi7YlWwQyLjt3dEw/fqzZNKJZqI3E5hO UHHw== X-Forwarded-Encrypted: i=1; AFNElJ/AVZDezRvdku61jyhrzL3RR7cwgUhlXpQk4psMDjUoSZNZ5pwCMXf1vewnHgnB324t1gk//6WeoQ1Myls=@vger.kernel.org X-Gm-Message-State: AOJu0YxJpo6U42fg7QlhcIQ1klilBoMckW+fuGYPUqBG9FL+7gjBFVVM U90jiWcM9j6ujhVCX+FdD0qNQn0Y92WPHn2gB8NI3CsJOr9OK+9pYu0I X-Gm-Gg: Acq92OEla+/UdB+EIutiQo9Y60HcOLpo53Zm47+JiDNhiWHteej35D3+6MVUAe2tlrM qnbI5g/afMNkkPaIdGVOqvPU4UUvyFa1vSO21FeUUNzFkg/KfnTPAS/5l+5cBzSdxqcxo6Rl9ic E9grJxsDZ+eel38+z8mmEdifC83UvQFF5DrUNv+IaurNqiwzJbUCWAbLta/IGP+YXxjbVCzR77X 1U1zPhjzvx9O48xOk3A9Vc1ricdveVuuAuKbpAzbTPbPCm/SEcHyNmMna6tJuYoboix6RXdAq/P dJTy6QgP8iFceLM7n3yNTqF/SSqpqDlhXsruSBmBTPVituDqHmmETiBYqi5oAtW0lTX1hyR0WH4 O61Y8xi5QuApq5cJH/ZNnF2SfIsraaO9uVJcnmmytpQnDCigvJed9LCCWa2vTSW0YudQMgkjXMa p/VC02dD4AeqrgPq3m0qQNtUtTubT5Vnwws6abw06tPiWa9PsAxX4WTdwyh2QMzyj9bQ0ml5FAj 9T8V+jLqkU+mBxtyg3JQC4= X-Received: by 2002:a05:6a00:950b:b0:835:405a:7e72 with SMTP id d2e1a72fcca58-8414ac97e9dmr829518b3a.11.1779327748515; Wed, 20 May 2026 18:42:28 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19fa869esm26411475b3a.61.2026.05.20.18.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 18:42:28 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu , Brian Masney Subject: [PATCH v3 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation Date: Thu, 21 May 2026 09:42:18 +0800 Message-ID: <20260521014220.77955-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521014220.77955-1-a0987203069@gmail.com> References: <20260521014220.77955-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit div_u64() does not modify its argument in place; the return value must be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq() called div_u64() and discarded the result, leaving pll_freq holding the undivided product and thus returning a frequency orders of magnitude too high. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock controller") Reviewed-by: Brian Masney Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk-ma35d1-pll.c index 4620acfe47e8..bfedd45bd04b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -92,7 +92,7 @@ static unsigned long ma35d1_calc_smic_pll_freq(u32 pll0_ctl0, p = FIELD_GET(SPLL0_CTL0_OUTDIV, pll0_ctl0); outdiv = 1 << p; pll_freq = (u64)parent_rate * n; - div_u64(pll_freq, m * outdiv); + pll_freq = div_u64(pll_freq, m * outdiv); return pll_freq; } @@ -110,7 +110,7 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 *reg_ctl, unsigned long p if (mode == PLL_MODE_INT) { pll_freq = (u64)parent_rate * n; - div_u64(pll_freq, m * p); + pll_freq = div_u64(pll_freq, m * p); } else { x = FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); /* 2 decimal places floating to integer (ex. 1.23 to 123) */ -- 2.43.0