From: Rosen Penev <rosenp@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Kees Cook" <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-kernel@vger.kernel.org (open list),
linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not
covered by other areas):Keyword:b__counted_by(_le|_be|_ptr)?b)
Subject: [PATCHv2] platform/x86/intel/tpmi/plr: allocate die_info with plr
Date: Wed, 20 May 2026 18:46:08 -0700 [thread overview]
Message-ID: <20260521014608.1356671-1-rosenp@gmail.com> (raw)
Simplifies allocations slightly.
Add __counted_by for extra runtime analysis.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
v2: Rebase.
drivers/platform/x86/intel/plr_tpmi.c | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/platform/x86/intel/plr_tpmi.c b/drivers/platform/x86/intel/plr_tpmi.c
index 8faecc311038..66220fadf670 100644
--- a/drivers/platform/x86/intel/plr_tpmi.c
+++ b/drivers/platform/x86/intel/plr_tpmi.c
@@ -58,11 +58,11 @@ struct tpmi_plr_die {
struct tpmi_plr {
struct dentry *dbgfs_dir;
- struct tpmi_plr_die *die_info;
int num_dies;
struct auxiliary_device *auxdev;
struct notifier_block nb;
struct mutex lock; /* Protect access to dbgfs_dir */
+ struct tpmi_plr_die die_info[] __counted_by(num_dies);
};
static const char * const plr_coarse_reasons[] = {
@@ -305,7 +305,7 @@ static int intel_plr_probe(struct auxiliary_device *auxdev, const struct auxilia
if (!num_resources)
return -EINVAL;
- plr = devm_kzalloc(&auxdev->dev, sizeof(*plr), GFP_KERNEL);
+ plr = devm_kzalloc(&auxdev->dev, struct_size(plr, die_info, num_resources), GFP_KERNEL);
if (!plr)
return -ENOMEM;
@@ -315,13 +315,6 @@ static int intel_plr_probe(struct auxiliary_device *auxdev, const struct auxilia
intel_plr_register_notifier(&plr->nb);
- plr->die_info = devm_kcalloc(&auxdev->dev, num_resources, sizeof(*plr->die_info),
- GFP_KERNEL);
- if (!plr->die_info) {
- err = -ENOMEM;
- goto err_notify;
- }
-
plr->num_dies = num_resources;
plr->dbgfs_dir = debugfs_create_dir("plr", dentry);
plr->auxdev = auxdev;
@@ -361,7 +354,6 @@ static int intel_plr_probe(struct auxiliary_device *auxdev, const struct auxilia
err:
debugfs_remove_recursive(plr->dbgfs_dir);
-err_notify:
intel_plr_unregister_notifier(&plr->nb);
return err;
--
2.54.0
next reply other threads:[~2026-05-21 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 1:46 Rosen Penev [this message]
2026-05-21 10:33 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521014608.1356671-1-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=gustavoars@kernel.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®