From: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>
To: alex@shazbot.org
Cc: bhelgaas@google.com, jtornosm@redhat.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 2/3] PCI: Add soft reset method as last resort
Date: Thu, 21 May 2026 08:32:11 +0200 [thread overview]
Message-ID: <20260521063214.13180-1-jtornosm@redhat.com> (raw)
In-Reply-To: <20260520101338.21fe1e13@shazbot.org>
Hello Alex,
Thank you for the guidance.
OK, using pci_dev_reset_methods[] makes sense.
I'll implement device_specific reset entries for the Qualcomm devices using
pci_set_power_state(dev, D3cold), which automatically falls back to D3hot
when the platform doesn't support D3cold. This handles both scenarios
(platforms with and without _PR3).
I'll keep the general d3cold reset method (patch 1/3) as well, since it
provides value for other devices that need strict _PR3-based power cycling
without D3hot fallback. The device_specific entries are the Qualcomm-specific
workaround, while d3cold remains general infrastructure.
I'll also keep quirk_no_bus_reset as a safety net to prevent the known-broken
bus reset from being attempted. This ensures that if users override reset
methods via sysfs, they can still use d3cold (when _PR3 is available) without
accidentally falling back to the broken bus reset.
Thanks
Best regards
José Ignacio
next prev parent reply other threads:[~2026-05-21 6:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 12:48 [PATCH v4 0/3] PCI: Add d3cold/soft reset methods for devices with limited reset capability Jose Ignacio Tornos Martinez
2026-05-18 12:48 ` [PATCH v4 1/3] PCI: Add d3cold as general reset method Jose Ignacio Tornos Martinez
2026-05-18 12:48 ` [PATCH v4 2/3] PCI: Add soft reset method as last resort Jose Ignacio Tornos Martinez
2026-05-18 17:15 ` Alex Williamson
2026-05-19 5:35 ` Jose Ignacio Tornos Martinez
2026-05-20 16:13 ` Alex Williamson
2026-05-21 6:32 ` Jose Ignacio Tornos Martinez [this message]
2026-05-18 12:48 ` [PATCH v4 3/3] PCI: Disable broken bus reset on Qualcomm devices Jose Ignacio Tornos Martinez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521063214.13180-1-jtornosm@redhat.com \
--to=jtornosm@redhat.com \
--cc=alex@shazbot.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®