mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	 Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 James Clark <james.clark@linaro.org>,
	linux-kernel@vger.kernel.org,  linux-perf-users@vger.kernel.org
Subject: [PATCH v1 0/3] perf: Fix kwork memory sanitization and libunwind test builds
Date: Thu, 21 May 2026 00:24:26 -0700	[thread overview]
Message-ID: <20260521072429.1283423-1-irogers@google.com> (raw)

The combination of the libunwind refactoring and build system changes
exposed a build-test regression for the libunwind build using a cached
feature dump. Re-send kwork fixes [1] moving a definition to kwork.h
to avoid breaking no libbpf builds.

1. Build Fix for libunwind:
   "make feature-dump" runs without LIBUNWIND=1, skipping the setup of
   libunwind LDFLAGS. When Makefile.feature is included to generate the
   cached FEATURE-DUMP, the local test-libunwind.bin compiles without
   arch-specific link flags (-lunwind-x86_64) and fails, caching a false
   negative ("feature-libunwind=0"). Later builds (such as make_libunwind_O
   reusing the dump) compile the unwinder based on CONFIG_LIBUNWIND (remote)
   but disable HAVE_LIBUNWIND_SUPPORT (local), breaking compilation due to
   missing maps__e_machine declarations in maps.h. Fixed by unconditionally
   setting up libunwind feature build flags in Makefile.config.

2. kwork ASAN Double-Free & Leaks:
   - Solves double-free in the record command argument array due to
     parse_options mutation, by preserving original pointers in a calloc'ed
     to_free buffer.
   - Ensures kwork_usage string is freed on all exit paths.

3. kwork Unified Memory Lifecycle:
   - Establishes a unified memory ownership model for kwork_work by
     ensuring work names are dynamically duplicated via strdup() and
     consistently freed using work_exit() and a central perf_kwork__exit()
     teardown path.

[1] https://lore.kernel.org/linux-perf-users/20260520190538.142018-32-irogers@google.com/

Ian Rogers (3):
  perf build: Unconditionally set up libunwind feature build flags
  perf kwork: Fix address sanitizer issues
  perf kwork: Fix memory management of kwork_work

 tools/perf/Makefile.config  | 103 ++++++++++++------------
 tools/perf/builtin-kwork.c  | 151 ++++++++++++++++++++++++++++--------
 tools/perf/util/bpf_kwork.c |  14 +++-
 tools/perf/util/kwork.h     |   9 +++
 4 files changed, 188 insertions(+), 89 deletions(-)

-- 
2.54.0.746.g67dd491aae-goog


             reply	other threads:[~2026-05-21  7:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  7:24 Ian Rogers [this message]
2026-05-21  7:24 ` [PATCH v1 1/3] perf build: Unconditionally set up libunwind feature build flags Ian Rogers
2026-05-21  7:24 ` [PATCH v1 2/3] perf kwork: Fix address sanitizer issues Ian Rogers
2026-05-21  7:24 ` [PATCH v1 3/3] perf kwork: Fix memory management of kwork_work Ian Rogers
2026-05-22 21:33 ` [PATCH v1 0/3] perf: Fix kwork memory sanitization and libunwind test builds Ian Rogers
2026-05-22 23:52   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260521072429.1283423-1-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®