From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB3AD29C327; Thu, 21 May 2026 09:13:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779354795; cv=none; b=dSqU7Rk1GPz8p8iaGmUPlZxwzY4E6lQ8uy0gDT2UfM/wIDnlvlEfIQnaUp07T4dL1cKPWgIcuJAlsFKnGt7YduhqsrDdJ92mNhzg5XiBYrNoh9SbrxVMEiO3v6HB/PA41yUkb3+JX95ZNWKBhZPb23pZHowu1eKJcAjzsfcjwfU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779354795; c=relaxed/simple; bh=sDtCR/112nTH/J/4iPL+45VIxb96cevBopgsu4Ph8eo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t9E0w5iaAZXEDfU5Bk0wpf0UG8VR9FgH2Aaa+km+CnFCOO19iXTTKlVXqPeojxDinCZUZQgDLSxcBl6jt01ZOqtuFzjNOa2W6/xm/qmZGl3vcZE+4ONddDa0EIZsT+SutgETjIydtLr5i3UYbXQeVUjEvFrexEQ3r1fwVw1vhu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=qIIr3YP8; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="qIIr3YP8" Received: from killaraus.ideasonboard.com (unknown [IPv6:2a01:cb1d:8f2:800:42d6:38fa:3bdf:70df]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 301F96DF; Thu, 21 May 2026 11:12:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1779354777; bh=sDtCR/112nTH/J/4iPL+45VIxb96cevBopgsu4Ph8eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qIIr3YP8EAZW/iNOMw/M83HwuXvaiW2nt6NKTXAAeyC2iRQOxtyJLDg1gp9bNZTum clogYJTaTikdiQ/fMlCox498QlxMUMfloaJhvs2T9peZdU1RkF0OmGBnJ5BoqTPSxN bcjGvDXa+j/Vds8fTNw8+rZDtwh+h1VnEQRbvHn0= Date: Thu, 21 May 2026 11:13:10 +0200 From: Laurent Pinchart To: Himanshu Bhavani Cc: "sakari.ailus@linux.intel.com" , Hardevsinh Palaniya , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Hans Verkuil , Hans de Goede , Vladimir Zapolskiy , Mehdi Djait , Elgin Perumbilly , Xiaolei Wang , Walter Werner Schneider , Kate Hsuan , Svyatoslav Ryhel , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" Subject: Re: [PATCH 2/3] media: i2c: add imx576 image sensor driver Message-ID: <20260521091310.GB4511@killaraus.ideasonboard.com> References: <20260520115641.11729-1-himanshu.bhavani@siliconsignals.io> <20260520115641.11729-3-himanshu.bhavani@siliconsignals.io> <20260520123326.GC215344@killaraus.ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, May 21, 2026 at 05:44:09AM +0000, Himanshu Bhavani wrote: > > On Wed, May 20, 2026 at 05:26:34PM +0530, Himanshu Bhavani wrote: > >> Add a v4l2 subdevice driver for the Sony imx576 sensor. > >> > >> The Sony IMX576 image sensor with an active > >> array size of 5760 x 4312 > >> > >> The following features are supported: > >> - Manual exposure an gain control support > >> - vblank/hblank control support > >> - Supported resolution: 2880 x 2156 30fps (SRGGB10) > >> > >> Signed-off-by: Himanshu Bhavani > >> --- > >> MAINTAINERS | 1 + > >> drivers/media/i2c/Kconfig | 10 + > >> drivers/media/i2c/Makefile | 1 + > >> drivers/media/i2c/imx576.c | 1029 ++++++++++++++++++++++++++++++++++++ > >> 4 files changed, 1041 insertions(+) > >> create mode 100644 drivers/media/i2c/imx576.c [snip] > >> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile > >> index 90b276a7417a..e96c083e03d9 100644 > >> --- a/drivers/media/i2c/Makefile > >> +++ b/drivers/media/i2c/Makefile > >> @@ -61,6 +61,7 @@ obj-$(CONFIG_VIDEO_IMX335) += imx335.o > >> obj-$(CONFIG_VIDEO_IMX355) += imx355.o > >> obj-$(CONFIG_VIDEO_IMX412) += imx412.o > >> obj-$(CONFIG_VIDEO_IMX415) += imx415.o > >> +obj-$(CONFIG_VIDEO_IMX576) += imx576.o > >> obj-$(CONFIG_VIDEO_IR_I2C) += ir-kbd-i2c.o > >> obj-$(CONFIG_VIDEO_ISL7998X) += isl7998x.o > >> obj-$(CONFIG_VIDEO_KS0127) += ks0127.o > >> diff --git a/drivers/media/i2c/imx576.c b/drivers/media/i2c/imx576.c > >> new file mode 100644 > >> index 000000000000..910cbcfb6031 > >> --- /dev/null > >> +++ b/drivers/media/i2c/imx576.c [snip] > >> +static const struct imx576_mode supported_modes_10bit[] = { > >> + { > >> + .width = 2880, > >> + .height = 2156, > >> + .hts = 3165, > >> + .vts = 2172, > >> + .reg_list = { > >> + .num_of_regs = ARRAY_SIZE(mode_2880x2156_regs), > >> + .regs = mode_2880x2156_regs, > >> + }, > >> + }, > >> +}; > > > > No mode tables please. Control the analog crop and binning through the > > selection and format APIs. > > > >> + > >> +static const s64 link_freq[] = { > >> + IMX576_LINK_FREQ_600MHZ, > > > > The link frequency should be selectable from DT, with PLL parameters (if > > any) computed by the driver. > > I don't have the full datasheet, so this cannot be implemented properly. Have you tried to work with your support channel to obtain the documentation? -- Regards, Laurent Pinchart