From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92C04376A12 for ; Thu, 21 May 2026 09:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779355835; cv=none; b=AWm9oyr+9J8DClPKJD9Guzy4aFAaYrqMwUuJlMDXT0HdbQ+ZWf7guDyI7Yfw37H4BiChNwG93BgBh/PbTBpbiZ5IrzQmSC3zRbPtK6bdgB9feUmB0RNMMaFYPjTX6TdBqgCfgSDVZg+FyMVDa8bi3Kh9Y0lGA5Z/S9CKGrDQzsY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779355835; c=relaxed/simple; bh=bQTTlBwD7+CdkKk0d3aHubO2R65v5mkSsBHXF0EToOI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=a1UZRnfNdNE+uUyeID5jj4RbgUXzmThuvkNrPOHP/1dsA5ffIRXR7KPeG2/IWqKFIMY2ImRmsg2pmN164tfl3CIMzrxohehYvpZAIVGtJkBWGFrdRbRB+mEEhBK0fufgElr/ZLk375w5ebksVY3CmX5J+nw3sCm+uvH/sypdn8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dvFT4eLn; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dvFT4eLn" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-488a14c31eeso36181445e9.0 for ; Thu, 21 May 2026 02:30:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779355832; x=1779960632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=p2x948EksUL7oS2hqJXHVyG8J9H43lWRd0Q/10yG6uQ=; b=dvFT4eLnOms20mSV5lnrK2bdQqku2WaWS7ZFE3v+z/BVnsaqeGz1dT69Ru4SxzzjWn FOulLsB6ZSWRc07fYN2mJ7R349X50jXy2MGmO6yyFSNzZakpFdxv8NfT0SadqHyKF5rb lROHfQjnNWI0OELAnC8PxCSXWr8HjVJIpgSntjIr/MjVzC4Z+Emnr+pBds0fZiEAalRN bNUd56vz5Py5yItYJNlpJpOUZye0iTf/GZWTUP2vckgnLIMcYt9EyThWykixCTjXS3DW q2xasb2445hdftc3frL3nTpCvaE7Kt5BkZ6D2S4uUEVXJOxa+TYc6FJ+IGFQRxe4KSY5 yVbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779355832; x=1779960632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=p2x948EksUL7oS2hqJXHVyG8J9H43lWRd0Q/10yG6uQ=; b=oF252JwPz1MeWZEOsHN73bFI5KqMASwYYMcqF7nivkg+PXuoOkpzGbpCYJwBhGRirW 8U8whnWPn3crEnUja9IoY6Czy9xq63hezXVWK//y7Y5vtzAv3BJDitWhPUbAgW1G8GbD jrjf26tegvPIt8FMxy5sFMLwR7vVT9FYdzS3BTGLKYsdNjhLGi32HhmB6d4n/cdVPn4H gPsTyUAUV0nf9Xu1g1LCvGrybb3AZ4EFeW5eOIWZJd1TvGx9G/OvhNG1rwJeEXXDiGQT lFwphRPQ0ioWCTfrJLTCEJvRIEiCaEOVBTzJE6qO6XGaPjweR2FrVD7jSokf1VAKzlTU H11g== X-Forwarded-Encrypted: i=1; AFNElJ/rINHrTQ8+B/AbvZANEhyp4/rUh3bCCbi6jj0FRnL+9xLNpgJFX8uvntmrBBU3coQ+OLabO5kAh/Yr1lw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7wuk9xnKs26WKcf6HtbUHnJEVP8xllypeWnP7Ai9lxdFVjvRJ lCTNzzuDjNws1iPy9n86FyowrJmuj3VopoMOkrFFoiQyfPnm9RBj5BI3 X-Gm-Gg: Acq92OEOxguta8Nm5BPXgLxtnje89TwUjluFhBtSI0Kl97Z1onDkt0Try4aksWA84Hd Ov1EVtcDZdpucRByqSxydZGbEnDKX0k+rnc+cFhncY7nxetYRayodyBX566+haCuRnhCgyxX23/ ev67jKNYKl8gpxPIKM+8K0dK8OwTwMcFMWysXljLp5rv3tO/EtGjVPJ1z+IrQQGn09L6FfpIeBp LcJaDhrHeFUizpRLMQ91wDDD0ktOkahXUDdWRWmtmCwIkMJg3NpK2pWOBudG1S9au9B+Gr2Noih QJndjg2DihyWt9Z4kkI7Qj3fjY8OSW6dmvie7CAGRAP1i70xdH0UzH+sIhijmsm2Oz37dxJq/zL uRLu+2jhtJvE68ZRj+eCqfUGdWTrqcy+Wr89bZoG74z24/WQ5Jf9ZM2Ky3YMMbcFvlPclj3UtUN S5mvE44zZR6E5BTwlijPfCqQBXhsYtV4xmKbeW0ovUmiCrnzGf/6v65kvRGU0h0fvv X-Received: by 2002:a05:600c:3d96:b0:47e:e2eb:bc22 with SMTP id 5b1f17b1804b1-49036024e9fmr30007635e9.5.1779355831775; Thu, 21 May 2026 02:30:31 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903caede9fsm14126955e9.14.2026.05.21.02.30.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 02:30:31 -0700 (PDT) Date: Thu, 21 May 2026 10:30:29 +0100 From: David Laight To: Thorsten Blum Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Kees Cook , Andy Shevchenko , Yury Norov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] vdso: move offset_in_page() from linux/mm.h to vdso/page.h Message-ID: <20260521103029.561d5c02@pumpkin> In-Reply-To: <20260521090655.160282-5-thorsten.blum@linux.dev> References: <20260521090655.160282-4-thorsten.blum@linux.dev> <20260521090655.160282-5-thorsten.blum@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 May 2026 11:06:57 +0200 Thorsten Blum wrote: > Move offset_in_page() out of linux/mm.h so users that only need page > offset calculations can include the lightweight vdso/page.h header > instead of pulling in the large linux/mm.h. > > Include vdso/page.h from linux/mm.h so existing users of > offset_in_page() continue to build. > > Signed-off-by: Thorsten Blum > --- > include/linux/mm.h | 2 +- > include/vdso/page.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index 9cedc5e75aa9..d5c7f1ca80ef 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -37,6 +37,7 @@ > #include > #include > #include > +#include That is already picked up otherwise PAGE_MASK would be undefined. The whole vdso headers is a mess. I moved one of the definitions (to do with bitmasks) back into its main header. The vdso compiled fine because all the 'normal' kernel headers get included in vdso builds. -- David > > struct mempolicy; > struct anon_vma; > @@ -3023,7 +3024,6 @@ static inline void clear_page_pfmemalloc(struct page *page) > */ > extern void pagefault_out_of_memory(void); > > -#define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > #define offset_in_folio(folio, p) ((unsigned long)(p) & (folio_size(folio) - 1)) > > /* > diff --git a/include/vdso/page.h b/include/vdso/page.h > index bc47186c07fc..948b13091084 100644 > --- a/include/vdso/page.h > +++ b/include/vdso/page.h > @@ -28,4 +28,6 @@ > #define PAGE_MASK (~(PAGE_SIZE - 1)) > #endif > > +#define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > + > #endif /* __VDSO_PAGE_H */