From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79CD8378D9E for ; Thu, 21 May 2026 09:42:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779356531; cv=none; b=qM1yeXcvO77uNgxE5LKPRa5iH66UrIN2BwpM+YNbchdzpAjepzzJv5iWHno71Mf2nrDmZsxwymrTFIxUMLNt/rmZNVyjkG39ZSib9rFwwNTvMMg4yY4tlsdXaiZne08vq31MKMfasWj6dgPHzEMMwmIb2DSQG1+UZzVj4gUT61M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779356531; c=relaxed/simple; bh=diKOwBGIdUOWKoUwu34PH2Z2Vswb2r8EYNUEzSSxUEI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Zdj++QG7gr1Eh/iwJU0YKAs4h7QexKuPpm+lbfPggxw4ONnofpPQxZB5iGKMyJKkLf/19GBvcdU9ol5BgmCFD++KLaf+xjNWyyp4T4/9QGvx+6QhLlJRo/rEtcVcf1WooB7h017ee3w4+qHeRCRNUCM22BcrLeTUKTw67heP2nU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TU/yCp1i; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TU/yCp1i" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48a563e4ef7so47116215e9.0 for ; Thu, 21 May 2026 02:42:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779356529; x=1779961329; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=LuiZFKOAP2hQ7MTYXd5knANR52URvsfSk0kr76WNy7I=; b=TU/yCp1ibf+U9YTUjHqriW2VBSqnKRgi2N6xHWoQvfDhVvIZhMWGrk4YkC9QT1dfcU Gv/tsknbi8h6HkEQzjKqne+9/b0bSaYqPprsZWDTavjanS4s4mZ78YnGENaxVcfTYzfM OpeybpRUmd4hdN2EcLhTDKzPIJLcVlmrroSldqDwMtHUlobPj1fVNyUd4AOBD3nuWTNt OyR4W0JqRJQkxudmQliss4BQIwLI4T7bhoNmwvwz0vssfei+DK5hcuSYrGHmUeKLkZyD qRRfTRfR9gNPLPwM28bm/MMLiEEmrAM/FjPJih3JgXGqobv9ufPwmLR1z9qQAqAX/1RU P3Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779356529; x=1779961329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LuiZFKOAP2hQ7MTYXd5knANR52URvsfSk0kr76WNy7I=; b=dmFK05CgxV69mOltu9+vt3s3RiJjqo/kBhYXWRDFkgRLJ9Edm1ctACytW3mMkuvg/E mm/rsHYsL3o0n72wMo3B74IHXB7q3GgPBgD1CCtWmV5I3TKF2oi6/kuJF/wKgVZO6wF5 XhZLkOajYlNy70iCUmZO7dupaR4DFkUbITN/pQw5iAUZGOfg/ze3teR6LAsgurNc+1iz e9BhyCyNMVCx0KQ4NiBDnpFFu9x/hVxJ9JkfwWTEMUuqnvGK8jLbDrbdGI4ZaY/vngFE dB/RHwvd1e77KLA93Hffdq/fTwTAPN1jqSL1nq2NVcxhPX31eN7NA8YUKWzkYc+otSv9 pCKA== X-Forwarded-Encrypted: i=1; AFNElJ+G7+txw8xdyTmHsjUisQNnSOklvC/RxGJ/jQ0uQCRwXpeRRYK5Bes/3TmwaTT2FQ+HFK5dytsrRldRBd4=@vger.kernel.org X-Gm-Message-State: AOJu0YzvfOrdhs9n7yRQ3+1hrjVqMQfSZ5a99YbUUAOrtgXVDSjckupe DAfO34toIlqrLw9yoUxd50Lx57qPQhKSJh86aPqTk7g3lJh8Wzs0RcfS X-Gm-Gg: Acq92OHhKLiS+YZKh4Zl++fS/J114AIx8Sh4ickz4qfoYdUWvnEHGfD4A63r3WsxQZk A3pt9i/HqEE7Y03OE8yRyahbJimP3dT+LX2q97buJ4wURpQi6EgNiEE2D39nFywRjAnxNy0ncQv +C5HDqEb6BsHlSV/XtpA+jkbjDlwFn1GN+TOBSaJXIKgq9oSFA+KPLuF8iSysrYTv6mjaswvvHC X2FwKNVm6yu72meh9nCvyvc+LCkJmMtmhCgofXyVjW5wn+jjhxVmdGLDyUwyDXd+c9nlLlUkkm7 AH4POdZsPmy3Ta5uLiyFgzr6mrdMhVvxM8CeHbqEN9POX9U/YJmd/23h8jvGpgNAJG5lhaEtTr8 74pIjXOjdIS3G5NYcci9VZ24lPeeJPisBck3VztcXgE8cx/qazf/WSIsbiPtmZvU1SFM6a5AVNE MXHc+p42uP6ArHbxAKDJRzr+oKcHlooiVyF+vemTAnaufZQ1Ej9OQeTkFyRsKbrmnA X-Received: by 2002:a05:600c:1512:b0:490:2153:2c3d with SMTP id 5b1f17b1804b1-4903608957fmr16164075e9.20.1779356528456; Thu, 21 May 2026 02:42:08 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d8e71dsm50329955e9.9.2026.05.21.02.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 02:42:08 -0700 (PDT) Date: Thu, 21 May 2026 10:42:06 +0100 From: David Laight To: Dave Hansen Cc: Anshuman Khandual , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ryan Roberts , Mark Rutland , Lorenzo Stoakes , Andrew Morton , David Hildenbrand , Mike Rapoport , Linu Cherian , Usama Arif , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC V2 01/14] mm: Abstract printing of pxd_val() Message-ID: <20260521104206.1c7d3fe0@pumpkin> In-Reply-To: <74f66e30-ab3d-4352-89ef-1bccc7e9daeb@intel.com> References: <20260513044547.4128549-1-anshuman.khandual@arm.com> <20260513044547.4128549-2-anshuman.khandual@arm.com> <74f66e30-ab3d-4352-89ef-1bccc7e9daeb@intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 19 May 2026 07:28:17 -0700 Dave Hansen wrote: > On 5/12/26 21:45, Anshuman Khandual wrote: > > if (!p4d_present(p4d) || p4d_leaf(p4d)) { > > - pr_alert("pgd:%08llx p4d:%08llx\n", pgdv, p4dv); > > + pr_alert("pgd:%" __PRIpxx " p4d:%" __PRIpxx "\n", > > + __PRIpxx_args(pgdv), __PRIpxx_args(p4dv)); > > return; > > } > > That's not the most readable result. Could a printk() format specifier > make this nicer? Maybe use "%pT"? > > pr_alert("pgd:%pT p4d:%pT\n", &pgd, &p4d); > > I _think_ it could even get rid of the p??v variables. > Adding another %p variant that is only used in a few places just makes it all harder to read. Perhaps a local helper that lets you do: char pdgv_buf[??]: pr_alert("... %s ...", ... fmt_pdgv(pdgv_buf, pdgv) ...) might be a reasonable compromise. -- David