From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3CB437BE81 for ; Thu, 21 May 2026 10:43:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360238; cv=none; b=FsvX/3C5xWmkvPeEV40KGcgCf4bMSUi0aNiEIUNv56tl3d/EIn8wCzYFXDSoSk2cVwZLMvZ1Mx0qhngXOBuGhMBfeuUJGq/RdP1i9+dzRXtZPPGxFb5KPJt38JIJma7xnViGmYFW8aFiCuwR5ftE2rjnvnRWy8uDw8yEqz8/7s0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360238; c=relaxed/simple; bh=YHSkAZ6xRu29Cuqd3YuBLQhuidytf+VlOkmSjnPWoNo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=n3KCMgIBxNdh5Xcy86tDFd7n1Kkl2nM921rrTNLqD7GrxdqowOo+gth3ZpTEqsuLbTXYGRN5+aCK3+gCC3b3DkRT42Ys5n8UrW+6FSNjz4E3TSOxjdygTZrESMeqMb1faU3VyBreHUNfAguxWQ+HOxTBzdgWf8pUzzcR0HPkFLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EuxFeMra; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EuxFeMra" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-1357c851a48so6717240c88.1 for ; Thu, 21 May 2026 03:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779360236; x=1779965036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ywrJCfH6HqleCDiPu2u6TD1wJvM9tizyU4jB3RATzRs=; b=EuxFeMra4NtztMhJt+CXNmeNGY0H8k+MvjKdvER6mstZ2bmVDZWgvvaHL2EExP9vyu JcMNOWrdWySmfg0hteFjJ3Yma4kIF/ptz31Ssa6VfvG3ijAGlSBGtJ6CPNo0tTLjBvV5 o03g77+nVAEwEqh8W7V9UaJ0R8ARyTFr5O0EvLMz08zl8/FYLP3fm0dp2kFBzTTAagrb 9RwF/SSG8KrAAj78leM1/z8XvtkHPj3mTnKKt7fWB8AQoNwjk3snFyKSMRXuagdJZ3j2 vrfVxYOW17xMO3A5QIQ6PwfzsPql1v5WrWZ9KJ7sttKD6hZR20pxequRE5qjrG5N22AK as9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779360236; x=1779965036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ywrJCfH6HqleCDiPu2u6TD1wJvM9tizyU4jB3RATzRs=; b=LobX/nS0T4AAgnHUDVgJF/bjR6N4Ekk63Uo0GYIP0yVLi3qeIPITWYrmst18aUFmrI tw40Whe1bi8gf9Qhs2v3lsHJeBg82JFx6mzm8AScq+YW/VLVOt6AOIguxg4mJQTVMk8w oIw+c+h16Kr0j+JTqPph+IN0oHeNGz0TVr27qMjw4TPxuAgwZhuo2VBEEz94bxQF33Q0 7BIoBGLGSRlWDtX7Od2n3+TZfPvhGkhKDrC/lGiYajE+n75qflcseeqE0PRmOWFLKFVH C/kSBeNKcvHyGNP7sDrZJZVEU4t2rmx1DR5ZlIzXsjtaZhIEPKJdbx2L3zzrXE6okYBe 1qaQ== X-Forwarded-Encrypted: i=1; AFNElJ+BkD9cw3j7Bh8UDl/Wmynqg+kDI2LIgpd94XFE4fYdBxa8F6sXYdmTfXeNS+7Nne9UO0mE9QL/6dzlOMs=@vger.kernel.org X-Gm-Message-State: AOJu0Yyy9h+OtYM0HVgi6TUVYiOVlymluUBQSKMpWSK088lBAFNWtwj0 lSvMs6iShjVmddP6yBE5h3Hvgy+ee3d3Q/W9alaI2NqKafg3r035F/L3 X-Gm-Gg: Acq92OFNHdzKS5k3z85P+Sd1GJorgD3ipP/nEnbTAzwmnEtniBr5BcU+4VTtkKW/4My rE0RS5jBwP9SsZzYOhwRuEgsCmi7XXyg+I/GaG7NB9E672Fgum9PGatp/JN8LphUOltHMC1KE00 Fcj0qg/kGuRbnX7z9vY0tkgHUDNSVKzU43oqfxfPZrW4ftrupZ7aR/QIDU4FjzXxHwtlm4PFgzo G6kZjdBC7hP1SK/h7AdQR0zF8ktEgygYzx+lfZXqYQ+uc9p2+1YNHTgoCGNBoNQShHDAABzIBpk ZFWaS5LtwWPoGyWGnewqX69cmEVO3UPd8JfNnFkZunNpsVkLEFTjr5hX0Y7j1Wm7d9llqsPd/Yd VauYRXATxanlV+OkLFrhPuwIVkh41r28P/Hf7H+2gXMFAlycFCA58AFuX1GSjGZcmhJOSN5hOzp 2RzB8YOgKDqlRIvGXafRAyO9XtDfbYj7KDtzgsYnq001kFZ0IHPsRTdV0ZqUdKzVn6WQ== X-Received: by 2002:a05:7301:2a0d:b0:304:ab8:f89a with SMTP id 5a478bee46e88-3042f476e17mr1284848eec.1.1779360235907; Thu, 21 May 2026 03:43:55 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30443578ab8sm167176eec.14.2026.05.21.03.43.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 03:43:55 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 1/2] staging: rtl8723bs: simplify LPS_RF_ON_check control flow Date: Thu, 21 May 2026 10:43:15 +0000 Message-Id: <20260521104316.27739-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260521104316.27739-1-dennylin0707@gmail.com> References: <20260521104316.27739-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace err + break pattern with direct returns to simplify the control flow and improve readability. No functional change intended. Signed-off-by: Hungyu Lin --- v2: - Drop unrelated comment formatting changes drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index ca1cb58fc801..56dbe0f36d65 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -397,27 +397,21 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) { unsigned long start_time; u8 bAwake = false; - s32 err = 0; start_time = jiffies; while (1) { rtw_hal_get_hwreg(padapter, HW_VAR_FWLPS_RF_ON, &bAwake); if (bAwake) - break; + return 0; - if (padapter->bSurpriseRemoved) { - err = -2; - break; - } + if (padapter->bSurpriseRemoved) + return -2; + + if (jiffies_to_msecs(jiffies - start_time) > delay_ms) + return -1; - if (jiffies_to_msecs(jiffies - start_time) > delay_ms) { - err = -1; - break; - } msleep(1); } - - return err; } /* Description: Enter the leisure power save mode. */ -- 2.34.1