From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E6B63A71BB for ; Thu, 21 May 2026 10:43:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360238; cv=none; b=fo2SId6s6i99yt3Mvh02qo+yGZBwHu16sa7NM3wY65pyZhE+DB2YZs/v2zAmyu34wSlYXSiha+zKne14OrQEVxnpP/+rLVEjohMjCP832xFPX1Yo9c33X4La6z3aG4Z09w0kmVsu5e9h198j52JI+gr3cfJg+YZsrpD1o5ymYlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779360238; c=relaxed/simple; bh=rTf6ylnM6H6xTLT2JAhk1V4t7BfC4qfMoqviL+ivGhY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SdgVUhBekLXjMdmfopJXCkH/N1ZJZyEfm0DmFJt1VOEMsweM+84UXB9k4fQo3JhdprdQaYWwUKeItEEzv9lGtAMHbqj2TCgihoyehKSxQTVP0o4QcEsHJpkJsLl75aio1Hqk3zvNNCR757PTFLfZi+MXrE6Ixqd8wbrf+uXXlqw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a9WDeqY5; arc=none smtp.client-ip=74.125.82.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a9WDeqY5" Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-303dbfbec77so6271289eec.0 for ; Thu, 21 May 2026 03:43:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779360236; x=1779965036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8md7FvszOiQsr4bVvzySccgOHi/BXJxIGcaiVJzxv2c=; b=a9WDeqY5JxjoVQrZbTo3DphqaZ9a+p80vSxTQqIleJeHUfbXBBcOKsYHf3Fvy3WfgG 2lrOZwDL9R6cuUrb+XZ72zo6Tiwi4bKME79fr4okhC85wyFKjEw8+A93ssbBSp8ew4EQ X3oM+7+nOwlp33aVhzw/YNvD7yeI5s99bSHTWYXM3SaUSsqr/+x/QtQBO6ttsrhHN1eK yb2Xi8gZsvKeCRUmIhRHplOoWPulVMh3NPW2PlIEjU8EmDFojg9NR+se9yz/Nrt0rRkC pIua/85G5Q8O0tGCAu80tnNlk+9bkgiqv4KtcY8bsSnpnO/55aHP1E7sDroZVIS7u045 PADQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779360236; x=1779965036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8md7FvszOiQsr4bVvzySccgOHi/BXJxIGcaiVJzxv2c=; b=IbM58JSM+qAMU4wCIhMLz1h8PlZT8DAvEbCj4KSZKZ1xuq3/jfaxyYqLxb9fz4x4SJ E8gdka/QAAzqtG81AR9kTn4gpfDyNigJ3C2KQjANerotofTzT2DrjaQ3DIIYR6/ssZn4 LLkq+73hxgJng82VoIf8mRDfe2w7o6a/naN9ps31IZVSBaMh49PSHIGnRlPSjlZj3w0q xEhSONjIpmd5iJrax9571BgQuJKcH1C7yvg+0tbmG6ooTFZRBwzvT2aBxrfGw6JvoBL8 4TKZ4OKZFwGBEM9IH7+UGVS2SlwKCvuNxq7VKCIXRJxr0meHttYxwoSLQc4wZJY3eZnR k1Lw== X-Forwarded-Encrypted: i=1; AFNElJ87cp/nTTOIySShlMUtKCy+IneLX8xk14VPhq6pCr8ulIMWAlu8wZbWDtxKogrrxNQ4ltmOu3j1tIThbKQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzMNUJF7a9CBdD9eaP5h90jgM2ukeoSGCcQQ13a5CCVwHZUAzRH dYhwG9cjUxGztxaTQDwRkEgujEkYSji8wVWvb4gB5I4dkrKt4T3F1Pz+ X-Gm-Gg: Acq92OG+zZiwuI5CimOfEHO/nkoY+/WTF/XdprMl//Y8+qFYgALmWdNt4bBxOBp+yMD nZlg4jJaPH+rQzgLF9IOHjoH6bQzcGDQ8B48mlskA3uq+FnEexQshbHda+rESLxr18syZgfLXvx 8/raZI4Srf+e0nfUSW5dsHWB7ed7eh/FWtohUK1IM8ImuSM+dCNRSy/3q+8KMHg+8vrslPzFhOg Gb5j2+mrhOe5ly3yfFr49F4Cee90sQT9Jey62iAvyVVh5h+4KsJm6WnOWPyAG93y3B12aTeII5p Ue9aIZWboCsU/1ScgpF3HyBURFLky7WHhxCIG+U5igkqxqQT78I017pB/eLJ325QEj/sPbsBHoq PzZh7Pr1W01Vk0Pbg/owijeJVZ1f7COMoSN6Ss852XTrUClTTuzZh3qD00fMjzrqHJY8US7vHKQ 9BsKVQpWJecqiSpHE6xwADZN0xk2SVGzwF4A96PqSM1bVcO56A+sajRl0= X-Received: by 2002:a05:693c:2b10:b0:2dd:8ac2:9f7a with SMTP id 5a478bee46e88-3042f5c27bemr1385844eec.11.1779360236524; Thu, 21 May 2026 03:43:56 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30443578ab8sm167176eec.14.2026.05.21.03.43.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 03:43:56 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 2/2] staging: rtl8723bs: convert LPS_RF_ON_check to errno Date: Thu, 21 May 2026 10:43:16 +0000 Message-Id: <20260521104316.27739-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260521104316.27739-1-dennylin0707@gmail.com> References: <20260521104316.27739-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert LPS_RF_ON_check() to return standard kernel error codes. Replace -1 and -2 with -ETIMEDOUT and -ENODEV respectively. No functional change intended as callers currently ignore the return value. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 12 ++++++------ drivers/staging/rtl8723bs/include/rtw_pwrctrl.h | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c index 56dbe0f36d65..661d4a7eb797 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -389,11 +389,11 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, /* * Return: - *0: Leave OK - *-1: Timeout - *-2: Other error + * 0: Leave OK + * -ETIMEDOUT: Timeout + * -ENODEV: Other error */ -s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) +int LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) { unsigned long start_time; u8 bAwake = false; @@ -405,10 +405,10 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) return 0; if (padapter->bSurpriseRemoved) - return -2; + return -ENODEV; if (jiffies_to_msecs(jiffies - start_time) > delay_ms) - return -1; + return -ETIMEDOUT; msleep(1); } diff --git a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h index c27d07861b8c..7dc9c4e2dfd2 100644 --- a/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h +++ b/drivers/staging/rtl8723bs/include/rtw_pwrctrl.h @@ -233,7 +233,7 @@ int ips_leave(struct adapter *padapter); void rtw_ps_processor(struct adapter *padapter); -s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms); +int LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms); void LPS_Enter(struct adapter *padapter, const char *msg); void LPS_Leave(struct adapter *padapter, const char *msg); void traffic_check_for_leave_lps(struct adapter *padapter, u8 tx, u32 tx_packets); -- 2.34.1