From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADED63CE0A8 for ; Thu, 21 May 2026 13:00:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779368440; cv=none; b=Pfg3FnsSt/H7CmR6tfSmltMTBuM0rt98MWY6/mmF6Lkhp0VoICoa4miAR5iQYQokKdhz8A0ZkIsTk18zxxrtaT4Bak3IMXUXKZp+aQPYrlgxPtXww+T9P5zjd6z3/HWql0k2F1kIS81gqJYSFK3Eygo9275Qmh3SQKIuYGTGp6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779368440; c=relaxed/simple; bh=/DWc/21g9inXKmvGrguCVoASZnB9td6j3vz+VAB4B/M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LgXSVI6kpG8GhHZE5/GujcuVmdOCJ3yuNp6pF3gIjR3PO+vPsdSc3f/oh1nTRNq93Od3ecyMnK1+mZ/Cm6LkkTbmmgaKgRJ941uNWlpu/HT0up857vM+oxDeKrciBBMA6weiQGzOk4ASnMXKgM6NoShFjCHLCBG6oHDW5SkjBZg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TQClNk0C; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQClNk0C" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c7979304c0cso529492a12.0 for ; Thu, 21 May 2026 06:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779368439; x=1779973239; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pO6x8dH77Fth79N5r1T9JUIJlEWo1Lrxw0QlFm833hg=; b=TQClNk0CmoD1dJ3ZD+EktTNkfFCbDcSHom3n3lYSwXV72aXHPJ7HreWUFncTBYk//y 55ZgWT5KUuZq6NKl0rZGOs8OBUBu3zgsdWHNcqsnu0y8EYuDBe7O6SfiaIaJqC/oFk+7 bMmJcOz4pbGwZpJamg47dBjlBF/RDlcyfTGmy+KglmQtQOmXV9PEb5TYwXaaL2/o6Y+Y zvNvGi8IsrLSZw54NrC18e+sYTJ96w07rvxdvI7t45+wjYgYscYUfGX5Hkkff1PfXb06 je0j6oekCWz2P+pRWVL1TWlpztEfRdxfpILLpeVTAkfZj8PXiTJOOWAA3hM68hKuJpM8 RQrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779368439; x=1779973239; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pO6x8dH77Fth79N5r1T9JUIJlEWo1Lrxw0QlFm833hg=; b=Cc3mfa/0EZgXJl1RT1Z9Xapj+h3k5NZxxWKU3eDLw1xQeD07OMgI1/njxCFmewOrt8 b8zej9jJhxx7rEpuEI9jfTBjtZRmpJsfO9HStTNBh02HcTuAy0G0396QyKl4zulwvZ1I uZxeVJGjuVRlZmEchMrbyu1d7qDSpbCsfQzlK3PWDkiWm47bWqHUuWle8sq3n9sejOZO Akc1oz8ucuVuUHmydLauCqWTO1MvQZCsQaqBEqlBeYs2nSq0JPFWujZUF6Kuk1U8rgTG 19a6TAJ0FFeSf0RLed3kh8jol9BPDW194+323/Kv5lGZz8QHB29qj8JK1GE6pn7LRSFU J0bg== X-Forwarded-Encrypted: i=1; AFNElJ9QQ6bk09jG7Jpw54clLIkx10Wsf0GcD+jdv5o3P53c3J7xJQGeeviaUCz8551sjea2xP9YJDbRPyJX3Ps=@vger.kernel.org X-Gm-Message-State: AOJu0Yx86rxoI1WDnL9W3IBE3pb8vMqSXZZ0Ho32LH3v3ZdMNS6PlD7S q+yxAU/NX4YFGd+Im+WRJOtvRrAI97gTj0V0oXSwaXxijQrnORp2kb5k X-Gm-Gg: Acq92OGjrjkjMoXhICjf4f9APiWayMLPAdV+dDW0Yxmra07kEqAJnKQ6tySfJc2Xlmq HSWfazgzU9cjGAPFtVh/ruTWx0jgBr9mNM4RxOaluoDAyQMOEhAz0ZpIpY4L90pu3vX5IPewB0N pdqzfcoRB5QeiPoBaEKCs1OuE2DOIzX+Kr4CgeKAT2G4tFTNsgyvxz5pqqXYHy8KZKj1gL2SqIZ h3IbAXWzgAPnrtUr8fRJJM7NGyzeoeM3hZtoubncNEz5FBWzQ9SVwk6mfZRMT2QYZAc5IZ1HhU1 NGGyMyL+JpxZTEcsmxA3MlN7r2bBB25PP2CvWbyKUtxhRfYF+HxHHRvrqYq8y8C+XHb9lshIghy OBp5C1zrjDzysxq2QqsFRDM3pk3ICTkyqt9kIcZZgl4gCZ3bLwNgGlKrWCTVZUZ4pkEkzDgucOZ EPhFriPS3jcdegxQxv6rQyiEA7CB8= X-Received: by 2002:a05:6a20:7484:b0:3a0:b812:3a84 with SMTP id adf61e73a8af0-3b308530a6bmr1862508637.1.1779368439012; Thu, 21 May 2026 06:00:39 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c851993d8a7sm284340a12.27.2026.05.21.06.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 06:00:38 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon , Hyunchul Lee Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, DaeMyung Kang Subject: [PATCH v3 3/3] ntfs: only alias volume $UpCase to default on exact match Date: Thu, 21 May 2026 22:00:17 +0900 Message-ID: <20260521130017.713848-4-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521130017.713848-1-charsyam@gmail.com> References: <20260520170151.4115308-1-charsyam@gmail.com> <20260521130017.713848-1-charsyam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit load_and_init_upcase() currently aliases vol->upcase to the global default upcase whenever the shared prefix matches, and then truncates vol->upcase_len to that shorter prefix. The result is correct only by accident: upcase[] accesses in name collation are gated by upcase_len, so the prefix-equality alias produces the same fold output as keeping the volume's own shorter table. Still, prefix equality is not equality: the volume table is logically distinct from the default and should not be replaced by it unless they are byte-for-byte identical. Use memcmp() to compare the complete table in one expression and drop the now-redundant upcase_len rewrite. No user-visible change is expected for compliant volumes whose $UpCase has exactly default_upcase_len entries; shorter volume tables are no longer aliased to the default. Signed-off-by: DaeMyung Kang --- fs/ntfs/super.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index d2c4fb6ea0d4..876e978370ba 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c @@ -1323,7 +1323,6 @@ static bool load_and_init_upcase(struct ntfs_volume *vol) u8 *addr; pgoff_t index, max_index; unsigned int size; - int i, max; ntfs_debug("Entering."); /* Read upcase table and setup vol->upcase and vol->upcase_len. */ @@ -1374,16 +1373,11 @@ static bool load_and_init_upcase(struct ntfs_volume *vol) mutex_unlock(&ntfs_lock); return true; } - max = default_upcase_len; - if (max > vol->upcase_len) - max = vol->upcase_len; - for (i = 0; i < max; i++) - if (vol->upcase[i] != default_upcase[i]) - break; - if (i == max) { + if (default_upcase_len == vol->upcase_len && + !memcmp(vol->upcase, default_upcase, + default_upcase_len * sizeof(*default_upcase))) { kvfree(vol->upcase); vol->upcase = default_upcase; - vol->upcase_len = max; ntfs_nr_upcase_users++; mutex_unlock(&ntfs_lock); ntfs_debug("Volume specified $UpCase matches default. Using default."); -- 2.43.0