From: Maoyi Xie <maoyixie.tju@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Ahern <dsahern@kernel.org>
Cc: Kuniyuki Iwashima <kuniyu@google.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Xiao Liang <shaw.leon@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH net v4 0/2] ip6_vti: vti6_changelink and vti6_siocdevprivate netns fixes
Date: Thu, 21 May 2026 21:05:53 +0800 [thread overview]
Message-ID: <20260521130555.3421684-1-maoyixie.tju@gmail.com> (raw)
v3 -> v4
- Update Fixes tag on both patches to commit 61220ab34948
("vti6: Enable namespace changing"). Xiao noted the old tag
5e72ce3e3980 is not the introducing commit. dev_net(dev) and
t->net first diverge when 61220ab34948 dropped
NETIF_F_NETNS_LOCAL and made vti6 devices movable through
IFLA_NET_NS_FD. Same Fixes shape Jakub took for the sibling
fix 1d324c2f43f7.
- 2/2 adds ns_capable(self->net->user_ns, CAP_NET_ADMIN) inside
the non fallback SIOCCHGTUNNEL branch. The check at the top
of the case is against dev_net(dev)->user_ns only. A caller
in the migrated netns can pick params absent from self->net,
the lookup returns NULL, t becomes self, and vti6_update()
inserts the device into self->net's hash. v3 did not close
that path.
1/2 carries forward Eric Dumazet's Reviewed-by. Only the Fixes
tag changes there. 2/2 changes the Fixes tag and adds the
ns_capable hunk.
Kuniyuki Iwashima (1):
ip6: vti: Use ip6_tnl.net in vti6_changelink().
Maoyi Xie (1):
ip6: vti: Use ip6_tnl.net in vti6_siocdevprivate().
net/ipv6/ip6_vti.c | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
--
2.34.1
next reply other threads:[~2026-05-21 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 13:05 Maoyi Xie [this message]
2026-05-21 13:05 ` [PATCH net v4 1/2] ip6: vti: Use ip6_tnl.net in vti6_changelink() Maoyi Xie
2026-05-21 13:05 ` [PATCH net v4 2/2] ip6: vti: Use ip6_tnl.net in vti6_siocdevprivate() Maoyi Xie
2026-05-26 9:30 ` [PATCH net v4 0/2] ip6_vti: vti6_changelink and vti6_siocdevprivate netns fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521130555.3421684-1-maoyixie.tju@gmail.com \
--to=maoyixie.tju@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaw.leon@gmail.com \
--cc=stable@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®