From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C75324B1E for ; Thu, 21 May 2026 21:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779400380; cv=none; b=CQHF0hsvxzUCA40cyEthGudA5BnBn1hnqF41A31D012pFvmKYPsqflPNEn0L97JhhsluZ09pxq3ntyu4Qis6jus7VRFztobHBQL6pVEqQ0lNudkmGrK0VgxR/xXqzyw8kqdSJsAG45+vLm5Ey7Msw0llsNAc/bMDhMGtYwvR0Cc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779400380; c=relaxed/simple; bh=Fimrvvm6vpGGBOqP1s8zb2XI5vLC0fyHAXP+pBP0iYk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PsfZqDEmUR/rlc9SeOo5u1w1MAeDbkJhFhznF/XxXqhTi4ijJxxRbQ6Sk83+nC3B8A/9ZBAe3+fUQ4eguUihMUcVMM3WdfpMm900u0gBRd66/kGQHQ7+2t9fH3vf1eQvm5jSHzni3w5lEe7mmPBX5T8dZ6Z1/omZzCQVVcLeSWI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Do3WWVIk; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Do3WWVIk" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-45d96d21e82so3840768f8f.0 for ; Thu, 21 May 2026 14:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779400377; x=1780005177; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=FX00zXuALEFbr7xyBmRRoNDwxqBnoiY5kbgoKXwjgQ8=; b=Do3WWVIkQUz3cG5cNVmzcRgd4PsN7xhM/sL1k+Jh7/lwOp54GgOVQjambGmUMSmd9U l3bZh9dhqtQ4W57tWCKgyWmraHtlxLPgJhJ67Lo8tQuemPMp6R36HvmKaQR5W3hpEk1d R1FpU95TIA0C+7i7NW/A/3nrm42iGAVsZMpHjxQyphNFwfeHJ2qL9pGDBXUWQqbRl0Ay gydRG5199IKKDWAe370r20ECrxqayvwuzS8vJdPec4XYQrvHUxXKWFCXC4Isl78FSfDJ ZR+iF9xEWPVWzR+f9SaLCzYgKeeKUgfcnIVVz7F+hlID9saA9xHToM0XjZHODVFPlPmz 3N4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779400377; x=1780005177; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FX00zXuALEFbr7xyBmRRoNDwxqBnoiY5kbgoKXwjgQ8=; b=BRLQSkWDDYrxl5LTEip6SDbFQaiZ5Rbw+6VqK/Isz/3KT5GkGivvhSKRFQSQ3X6D6i g0dBWoXt/r9L3JXNVZqwNzwdfRcSWhN/bZTnp19oe8HGlYtq3DZKA26P2aZGS5iPIlvH d0FxwPlCunUxe2aD28s1lBZO5v5/68q/VAlYtG4mUBlBGerp9Hs0+g9Fa/L0HHcCDlLO Al8vrl76jkXqgFcv0to/UXS4A0hbehRD456EzG1ReY4DMYAf+slmRk+b8iQOIuxMq5im +HmqmEGHacGqCH+eBlGYPmr31Jiy7AKs7fi+yPG0wtlhSpOTb42aCflY+UKeuoS/rbY8 J5fw== X-Forwarded-Encrypted: i=1; AFNElJ/BCL0wWPRcdN8RMGmGa1aqSZFqRzYxlelHaUwK5n5XvX9R303s6f1Xlb5rTrENw7DGZzUTXPYjP42UIFw=@vger.kernel.org X-Gm-Message-State: AOJu0YwrN8kmNwe4YacXuFcr//bALxIGMQYVk/dfG3O/9XSXwb72J55d dcwwVU9bYBmw9o25zsTyN36iU9FslD2OSAUfFQcU+4Ng7HU1UfcJm5b9 X-Gm-Gg: Acq92OFIFTKW1fpj3PjdJXhmoL1GLxUIyOUtYj48nfHjGg2r7tA4K8Yvi4bPaFftedM Ersza3lxkFiCc6yRMnMdkQG7JlQfKGBOLLCoy6u5/l7FY5AwX8pu/qddfUFV/grb+1F/4+v0ws1 WyAsDvBvmMwjeL70HEdrmQWPKfRPHULQn4H6nZA/wS7ttaZlmvoSFwZlQPDUs3ucFoxL1jeHp68 /e2D9KcX828omAi2n92iYioKfI5fFCpcbLIBhXGD5CgXimCMLkkfeOHbNPEb6XKNyVw2dr/D1Di tmByNdy3U/odlXxEcbzANWdHK6Zkq4sgZPzDVHJLQ/u0L2Y53QfjDt6IOcRePgE6Do9UkMGunq9 GkSnZ+i2BIxFdeFe3y1gWON6VbsUNIBt8g5wfu8dtXIwmUhf1wX5ZZbmFmZfNw3acKu0VRislyu D35VJY/lXWazF7430LQZqNWHobcuTRC3NuGV+GG18cU5pE/JyMfVcZBWpg X-Received: by 2002:a05:6000:388:b0:43e:a9ba:b194 with SMTP id ffacd0b85a97d-45eb38acbc6mr584327f8f.34.1779400376890; Thu, 21 May 2026 14:52:56 -0700 (PDT) Received: from osama.. ([41.43.100.18]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb4ad03a6sm135136f8f.27.2026.05.21.14.52.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 14:52:56 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH 1/2] drm/bridge: tc358762: use devm for bridge registration and DSI attach Date: Thu, 21 May 2026 23:52:26 +0200 Message-ID: <20260521215228.188615-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace manual drm_bridge_remove()/mipi_dsi_detach() in remove with devm_drm_bridge_add() and devm_mipi_dsi_attach() in probe. Also check the return value from bridge registration. Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/bridge/tc358762.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index 3d75d9cfa45e..3a021ca895f1 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -293,25 +293,17 @@ static int tc358762_probe(struct mipi_dsi_device *dsi) ctx->bridge.of_node = dev->of_node; ctx->bridge.pre_enable_prev_first = true; - drm_bridge_add(&ctx->bridge); + ret = devm_drm_bridge_add(dev, &ctx->bridge); + if (ret < 0) + return ret; - ret = mipi_dsi_attach(dsi); - if (ret < 0) { - drm_bridge_remove(&ctx->bridge); + ret = devm_mipi_dsi_attach(dev, dsi); + if (ret < 0) dev_err(dev, "failed to attach dsi\n"); - } return ret; } -static void tc358762_remove(struct mipi_dsi_device *dsi) -{ - struct tc358762 *ctx = mipi_dsi_get_drvdata(dsi); - - mipi_dsi_detach(dsi); - drm_bridge_remove(&ctx->bridge); -} - static const struct of_device_id tc358762_of_match[] = { { .compatible = "toshiba,tc358762" }, { } @@ -320,7 +312,6 @@ MODULE_DEVICE_TABLE(of, tc358762_of_match); static struct mipi_dsi_driver tc358762_driver = { .probe = tc358762_probe, - .remove = tc358762_remove, .driver = { .name = "tc358762", .of_match_table = tc358762_of_match, -- 2.43.0