From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA2CE327BFB for ; Thu, 21 May 2026 21:53:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779400403; cv=none; b=jujSvQRAbUxTABBqx0ddvj4QymSFIx3UiqYI24EwUVv+5WVD7QP3d3urJqdRyZ4ghEe7MQcT9zemTFX84XX06Z4u5SrZPMWdwP4J4ahHcAt8QAFskBffOOnvE8QxYgrVWJ/z3L5DsYTQH0NgaJAxPoXQAmps3drLqx0pwWs5V2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779400403; c=relaxed/simple; bh=cphiktGzChkJhgCWFDY4OgrqLuWEGrNk8kMbFJ4/r0c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YgU9HYtkr8ozOPTxJnSfLPg2H1ZEMFJkh5+1w8dNu6/n17E+Je8OMGweJERfUKINZ5k8u/aMSmQaSZGk8Dk8YCFaJQrKUxXqz6AfzV8K7bqXs1AWgBTyj7ySLkVYboyZu1lkMHFtH3yf8e9RpIPiFDHtWoCThluVwlKPWGP9bEA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G8QpWht6; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G8QpWht6" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso69468025e9.3 for ; Thu, 21 May 2026 14:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779400400; x=1780005200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sgy9hoPiLGulm4GsLO/GlLiuzebvz4yl3gcJM2iXtwo=; b=G8QpWht6lwXprPhrmCrsVPoVhUCK01XDd1jAM4sNDAe7GDJWII3+iPahqtRumKhAAy fyVIyWN1ErlmxZRS0tZFdG/tpggFFiFOGm0qLrHT2JQ8L7xJc7lKkmgWfeGHd0XXCkPi 0jeI/oFaoEinegZY53SIEP2St73LWRpybBLuoh2F6scsPwVR8gebiBngeMgkLY8oWeRc 0i4aVycCtCmMXBl40Pn2mZm56igqdjyEQDUjEjM3S1q29+48hGDlRb9Gj7ZapTv+9BZG 4cFCZf34Y3HM3aKOtdE/YyVwk9k0lDAeZcC06yQVEDj2EI7pHIdkoU/iLhhFATd2JOq1 OrTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779400400; x=1780005200; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Sgy9hoPiLGulm4GsLO/GlLiuzebvz4yl3gcJM2iXtwo=; b=pXTce1peEqYQnPozsafPLlfXYqTzirlJ+kirAzOYmvcUpKHit9TbEMWVK1WjM2coJx BjXe/cSk9xeve/afRuQqobtTmPO1fyeddgS/evWu2Dgfl2NnpAq3eOhp4ImTviEy1/02 dMn4OiAVChrHDfDNbKXeljtf7TGytFWbLQVEzXp6CZErAmO1m+ihwkNPXW0SjilR5RVB cPYXBz//2LOA77L4mIpdRCAighKhD64YFwltDcn7o4J4T5U20hZ/KtKQoq8UvtZc96du HI3WgqM2mEDjRvOpAvTjPku4BpUs0+DPsG+yX0bWwXtYouk0Oy9E6Nkv4EAyZnDvGU+7 ZWeA== X-Forwarded-Encrypted: i=1; AFNElJ8u2e7HglynT4y1+TphLX9JFsve75efVvf37CDpOrwaPbq0xlKnFhJdxE5LAxQAP1ivQG4uEIr6z9oKT60=@vger.kernel.org X-Gm-Message-State: AOJu0YxpOkbNoV0cAa7ubCtBaMhRw12hJBtXdRmSUSg5fLg/lQLR6HZl KmaoQSFIehFZnh4Yp9Xq3r3Se1krXhfrSm5fJEKEKsIq/+p4bqghIMcn X-Gm-Gg: Acq92OHaq8avnynfs1hkGsGNCboQObommLSvAaB8mW3kXnLQj9s4K1j5D8JS4+CDiWr sIC1K+jtkxe3WFnpXINWXGkP5YGR6o5/G4nmNFiTO+kKqlcnqEmLcbfg2pvDOhiQn398aB+GHIL tRM315wdKSVekvHZ2O3sieH7DmVvn+xtmPoEQpd1JZnq6IqDJ+eb5dnJsZPZB9UJ3oyQoTbYuZP C3uh11iEsGkSxvc1BISfnsov0Z/De4Z82sqodRAR/BKLR4Qc15qaoUN9dZBkgsiS5j4ArnVl3Wo 5Y8X3jRDz+cuny3NzWZHx+pR0/riHoWOKyp1fSbgKDKHRX/2L3Hf1ZAtTbTmVPRFEqMBzzeOS3H qR0lVLzpR2eN8+zcMyKL/5PTDTxJTFlaQMCUTS1cTELclI0zlaXHBEiTiTQWQQYpKcd8jzCQLfB Cg0ucOo9+HKukIp+8kFnS01R2J0oTLWdBh/syaujs+GF6CvdiTZh+DYJPW X-Received: by 2002:a05:600c:4fc4:b0:488:ae6c:42c6 with SMTP id 5b1f17b1804b1-490426aa52bmr6367315e9.14.1779400400266; Thu, 21 May 2026 14:53:20 -0700 (PDT) Received: from osama.. ([41.43.100.18]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb4ad03a6sm135136f8f.27.2026.05.21.14.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 14:53:19 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH 2/2] drm/bridge: tc358764: use devm for bridge registration and DSI attach Date: Thu, 21 May 2026 23:52:27 +0200 Message-ID: <20260521215228.188615-2-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521215228.188615-1-osama.abdelkader@gmail.com> References: <20260521215228.188615-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace manual drm_bridge_remove()/mipi_dsi_detach() in remove with devm_drm_bridge_add() and devm_mipi_dsi_attach() in probe. Also check the return value from bridge registration. Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/bridge/tc358764.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c index 084e9d898e22..ae652f2eef1b 100644 --- a/drivers/gpu/drm/bridge/tc358764.c +++ b/drivers/gpu/drm/bridge/tc358764.c @@ -372,25 +372,17 @@ static int tc358764_probe(struct mipi_dsi_device *dsi) ctx->bridge.of_node = dev->of_node; ctx->bridge.pre_enable_prev_first = true; - drm_bridge_add(&ctx->bridge); + ret = devm_drm_bridge_add(dev, &ctx->bridge); + if (ret < 0) + return ret; - ret = mipi_dsi_attach(dsi); - if (ret < 0) { - drm_bridge_remove(&ctx->bridge); + ret = devm_mipi_dsi_attach(dev, dsi); + if (ret < 0) dev_err(dev, "failed to attach dsi\n"); - } return ret; } -static void tc358764_remove(struct mipi_dsi_device *dsi) -{ - struct tc358764 *ctx = mipi_dsi_get_drvdata(dsi); - - mipi_dsi_detach(dsi); - drm_bridge_remove(&ctx->bridge); -} - static const struct of_device_id tc358764_of_match[] = { { .compatible = "toshiba,tc358764" }, { } @@ -399,7 +391,6 @@ MODULE_DEVICE_TABLE(of, tc358764_of_match); static struct mipi_dsi_driver tc358764_driver = { .probe = tc358764_probe, - .remove = tc358764_remove, .driver = { .name = "tc358764", .of_match_table = tc358764_of_match, -- 2.43.0