mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: simplify LPS_RF_ON_check control flow
Date: Thu, 21 May 2026 11:15:07 +0200	[thread overview]
Message-ID: <2026052148-amaretto-aspirate-7c36@gregkh> (raw)
In-Reply-To: <20260512030445.6360-2-dennylin0707@gmail.com>

On Tue, May 12, 2026 at 03:04:44AM +0000, Hungyu Lin wrote:
> Replace err + break pattern with direct returns to simplify
> the control flow and improve readability.
> 
> No functional change intended.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 24 ++++++++------------
>  1 file changed, 9 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> index ca1cb58fc801..7f297f2d2ff4 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c
> @@ -389,35 +389,29 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode,
>  
>  /*
>   * Return:
> - *0:	Leave OK
> - *-1:	Timeout
> - *-2:	Other error
> + * 0:    Leave OK
> + * -1:   Timeout
> + * -2:   Other error
>   */

This change was not documented above, and doesn't belong in this patch
:(

      parent reply	other threads:[~2026-05-21  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  3:04 [PATCH 0/2] staging: rtl8723bs: cleanup LPS_RF_ON_check Hungyu Lin
2026-05-12  3:04 ` [PATCH 1/2] staging: rtl8723bs: simplify LPS_RF_ON_check control flow Hungyu Lin
2026-05-12  3:04   ` [PATCH 2/2] staging: rtl8723bs: convert LPS_RF_ON_check to errno Hungyu Lin
2026-05-21  9:15   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026052148-amaretto-aspirate-7c36@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=dennylin0707@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®