From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f44.google.com (mail-oa1-f44.google.com [209.85.160.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3C5331F9A3 for ; Fri, 22 May 2026 03:25:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779420303; cv=none; b=UQFaVwCHpytQn2sHXrQFnhETKk3sIUs0LB5h0bjH1NXxeOPSnfyr/B/vO1zID82Dm6Ar0XL+UKHccBhVd5D7FL8w1F+XQGJ8YAQwwwTqV0vXvZxjPlHfzn1XIkVKZu/DgpfcTntvqp5piGvn3zDN1zvokTRLFDlBdoCGwhM0jJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779420303; c=relaxed/simple; bh=L2jg9D0XFL1VvN9nyVxBY1HFgSfAg+BCJi++Ra9EGhU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kAgwu6pTgHWHxaeHpn6OjEEoqWuGEhJQCekjbMCNh2lhCJgFuHhNyyO/AzDXRWrRVJHkqaS/Y1KBBzJm+JpwCA83d9y5OfAUMZp5UtHdI7uR2CrG4DjNAlNb6qy+rHdCkh8kzociC5FIjgLri0rH5DF9jBEcXKsjk6HbADevqxo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fAPMLsrn; arc=none smtp.client-ip=209.85.160.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fAPMLsrn" Received: by mail-oa1-f44.google.com with SMTP id 586e51a60fabf-43ab7bfaa18so2561679fac.0 for ; Thu, 21 May 2026 20:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779420301; x=1780025101; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jqSX+qOoTZNsA5tItQHuM3Tq846LID2NTSA7TvluY5c=; b=fAPMLsrn4eNdMapYxDUGnyXhU4YvHsTw8rpr/scBHCY9R8u1dbfCyCyp1ZEm2Ub9xi /R8rNrprvJ4+LLwEYlOqZnATGM6LkxQ10Jp3DnBaMkeOtzvHZ0gzPYMdojsY9rrh+XsL +8UQP8IKw616RiGjWcmfRbPnTbjLIgSwSZh604Cnsm8osg06Xk++T2SF5knEVY+oE0Zb y98JS3y7tVtHaHE1m19G+s2i8GqGfO8kuz6pw/SQelj8n8ScYK27sRdCYdN50JnU1Za2 aBsE4WwpwtdCg8/Sd1VbZJWcTyqY7aRSq38FreQSg2jfn7hwtUgq8FkqkQzqOHvCeLNb CUyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779420301; x=1780025101; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jqSX+qOoTZNsA5tItQHuM3Tq846LID2NTSA7TvluY5c=; b=NwC2VstTHyB5YVtTqe/dhworgpjTobeEYaWq+r4/U2Wz7a0tEbCeWtQTH86wt9Anzl vGMOwMcZpc7tf1sD3b6aftkpNkmaCBXf/Wa78Qj2YbVniTIUz/uqmp39t6T9oblhUILJ yibcll6zNHqK8T+SjYeQh71eqfI4JSo3NZiCWdl/6186P/uJolod9FtTOouCSBkiaOKN O778GcLwnTjyG+eoot5cpMlsl8Y1B/6VFSMuMu56JF44sNaPNqGsS2UnwbJu/ErKMsd5 qmcpKQHOTHazx11uIvktEf3q61gB0vRW0kmTzPPlrejC/oWO555keDi9aV3PYPNavMMb y32w== X-Forwarded-Encrypted: i=1; AFNElJ8JfygjLmpvi/oyub675IFtGErC0ukHCSI6F2qYPzZOzTbqpi17jxT5/PsE4Tic4JM4EqCSWjsHYK+IoHc=@vger.kernel.org X-Gm-Message-State: AOJu0YwUp/dvAqJHLwLWFlt6GP/cTQ1uorI0ie2Oow7FPYUy70KGP//q yNWOWWcFtbxNit+ley62So+m26zprPOnQWuZY8w48pXD+P4Ach9YtZT6X711wkey X-Gm-Gg: Acq92OGr1ovCyU9vFi9TpLu/KCWhM1dAUvmYH0viSX2ayAv9aAFSaXrr8YUeeaEG8Ci R29RN+O1myCF1u6R7kw+TesCx95seV+vxSyVc+7x2GgKZo+MU4EU1bRWvKkK18UfMdeFn+xgAB1 8DXYpIouM9I55PVIoMjSvVcmXM2lYKPRNfoemFZO6hU+SpqhrCmMENrEfB1izl0MUdegp8DqkPx f0BXYBII5HcB/ZHnA01Vv9Yl/QPGVsFuBnv0efX0h5+uMpNQP2rhNYyi3m5DqGXIOWYNozzCVne s6uaEDj0wQrDBg4JlOzxpkqGDl28/nLPE83JhBZuI5IKwFqsWP5EmdB+ACYgeBcYoqBNuriuVWs r73QobYK3BB2QggZJ8PXbvCWlGJ93JAM97mxYEpE89gON+3jPs9pzgUUkuBG3PXpc+qJctWX0BN UIkJw+0Zxk0mg7vaRnbhm6ncjVTw== X-Received: by 2002:a4a:ee07:0:b0:69d:84c9:ae70 with SMTP id 006d021491bc7-69d84c9b556mr237926eaf.40.1779420300958; Thu, 21 May 2026 20:25:00 -0700 (PDT) Received: from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69d83a4eef1sm239063eaf.11.2026.05.21.20.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 20:24:59 -0700 (PDT) From: Minxi Hou To: netdev@vger.kernel.org Cc: Minxi Hou , donald.hunter@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, aconole@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 0/2] Add OVS packet family YNL spec and unicast notification support Date: Fri, 22 May 2026 11:24:47 +0800 Message-ID: <20260522032447.238715-1-houminxi@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260521022002.879334-1-houminxi@gmail.com> References: <20260521022002.879334-1-houminxi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sashiko flagged a few things on this series, noting my analysis here for the record. The dp-ifindex field is typed as u32 in the spec while the kernel struct uses "int". All three existing OVS specs (ovs_datapath, ovs_flow, ovs_vport) also use u32 for this field, so I kept it consistent. key/actions/egress-tun-key are typed as binary rather than nest. This is documented in the commit message and inline comments -- the nested attribute-sets belong to ovs_flow's spec, and YNL does not support cross-spec references. The execute operation does not carry uns-admin-perm in the spec. The kernel sets GENL_UNS_ADMIN_PERM on it, but none of the existing OVS specs declare admin-perm flags on any of their operations either (ovs_datapath new/del/set, ovs_flow new/del/set, ovs_vport new/del/set all have GENL_UNS_ADMIN_PERM in the kernel but omit it in the YAML). ntf_bind() will raise OSError if the socket was already bound. ntf_subscribe() has the same constraint -- both expect to be called before any operation that triggers autobind.