From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94E4C36214C for ; Fri, 22 May 2026 05:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779426432; cv=none; b=Be2FwTXwLejTifxpViqsPTm8J0j08RQYk26U+yHY4AMDkgp8x+a7ezIUVioQ5ZsRx/8U0yFwN43xkqVlpqcb9fMvmqW7n7dKt/nmhHQK88iD3tv52PWnl38CsDTV8O+J8clvFjxE36pugxx4dFgOIzze/UyUHjHNnDoJcpqYR4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779426432; c=relaxed/simple; bh=KR0AYqG8pNoH+B43HxuRCbPqD7l3WxiqDcnRoVF6Zso=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=l9aDrWSm+wX6YBqi+NJo8cEQu9BQOx1sR3Y+0QMYLJL3RRiFhojbBeejlcRBDL9oWnEotVVEb4FDrLz+ctmFZLElG6wSYSeJ/qlMP/W+/C5CcrKc90W/n+NgTOLocKY6wQPp/MU8QaLgjsQV48C8qUa259TfFh8LtaLJudZD1rM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c802803ac17so2993111a12.1 for ; Thu, 21 May 2026 22:07:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779426430; x=1780031230; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2qi4QNZE3QSAMbRWNcXu7liHx2Lp06TrOvtrVJJqyZw=; b=kN020y6Anw+eNNSPvRz0NUm1d1rwJW+rpjQyrZBXDbh2pRFB0yRsD1FhfdljLg7DKg P9zrUdgIx4nqz5hlg4ool42fqQqhv3WyFXIY/PYpZ+drB7JoD5qCTN4E9sZ5igmqtgMj e3Ui8ns066grS/AK1HPasOjGdVx5ManIB32os3YB3o+jgu1Z+ogHhw7DTh6IzODZcQTT o6Tbf11F3aKXY0Ah9LB4wUkPIkkngJsredlnoXT1+Yo5j8Hr5Sq5hfsPTUwGmjAm8Fb3 Eutxbe5/Y5ikp1RbgwvMngMHxc4jt9BQTB6TBiRPUCkolutcAFhJXbZgAEU76IbaJK7h uZhw== X-Forwarded-Encrypted: i=1; AFNElJ//hHr4AR2QS/1idm33DEFvadvyA7yuEC0my4IX3m998OvFiFpAbq6gELCuUiz7MsNdvEMjV9l/pEJbM/U=@vger.kernel.org X-Gm-Message-State: AOJu0YzlKHs2WPSdPmEXXatRM7oVGmZxPqPWZrabBp/sJegFwN/B04hm dlx7/iHH0P0SmfM28t8ZD/vLhPUoe2qtHU7JQ2k9MWsW7xDDbgTm4fZQ X-Gm-Gg: Acq92OEHw8dTIUx0WgR0ozsZvDTgUhwr051xcOHcf351fmpkBPVWjyjr5XByiT6JWyA LpCnjfiEE2416GMmcTiFMCuYdvX7cKUTo80GILJZS3SvUG1LcuKw9XihQW3WJs5plRTra4Z2L9I bqWr2vKYTRf3X+/0CHDgXuMQivbpxoycT4DlJFEFp7l1Iber/1+VLKT8D9uVX+ehdmqc4Vuwi8p awm8/v85B52aAGNLb0doRkaIi8vfynW8bPupfB0pY7Y8XiRIFAwYFHK6Apb6rIj+JlZS/S9A9Ha kirVTYHmvYHN+eCZ7L/ptkechApxjsGSvSvnRWHF6nlXvIA3Wo0tjU09tpBH7JYBnm/yNxZLJed 2w7NLNOnEApWesJT+X8TYqvLK9apWIt4uvmp9nbXiacWf2+WSLuoG+XsoajjV9kwTUkLdwXXBnI albK6hXmYZH6hpIxV8LX4QW7vEicwfMJ/8dGm/UQt9bazWxE7/02HOVe2W X-Received: by 2002:a05:6a21:15cf:b0:3aa:f9cb:d43c with SMTP id adf61e73a8af0-3b328e7457cmr1971084637.34.1779426429588; Thu, 21 May 2026 22:07:09 -0700 (PDT) Received: from fedora.lenovo.com (zz20234032476F6CA7C5.userreverse.dion.ne.jp. [111.108.167.197]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85205855dasm367615a12.31.2026.05.21.22.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 22:07:08 -0700 (PDT) From: Vishnu Sankar vishnuocv@gmail.com To: jikos@kernel.org, bentiss@kernel.org, derekjohn.clark@gmail.com, mpearson-lenovo@squebb.ca Cc: vsankar@lenovo.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Vishnu Sankar Subject: [PATCH 1/2] HID: lenovo: Add support for ThinkPad X13 Folio keyboard Date: Fri, 22 May 2026 14:06:31 +0900 Message-ID: <20260522050632.8079-1-vishnuocv@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Vishnu Sankar Add USB ID support for the ThinkPad X13 detachable keyboard. The Keyboard uses the same HID raw event protocol as the ThinkPad X12 Gen 2. The functionality stays the same with X12 Gen 2 Keyboards. Also declare KEY_PERFORMANCE capability in lenovo_input_configured() for X13 detachable, allowing userspace to discover the key via evdev capability bits. Signed-off-by: Vishnu Sankar --- drivers/hid/hid-ids.h | 1 + drivers/hid/hid-lenovo.c | 21 +++++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index 4657d96fb083..064be2333a00 100644 --- a/drivers/hid/hid-ids.h +++ b/drivers/hid/hid-ids.h @@ -874,6 +874,7 @@ #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5 #define USB_DEVICE_ID_LENOVO_X12_TAB 0x60fe #define USB_DEVICE_ID_LENOVO_X12_TAB2 0x61ae +#define USB_DEVICE_ID_LENOVO_X13_TAB 0x62af #define USB_DEVICE_ID_LENOVO_YOGABOOK9I 0x6161 #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E 0x600e #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index a6b73e03c16b..35b00619f045 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -504,6 +504,7 @@ static int lenovo_input_mapping(struct hid_device *hdev, usage, bit, max); case USB_DEVICE_ID_LENOVO_X12_TAB: case USB_DEVICE_ID_LENOVO_X12_TAB2: + case USB_DEVICE_ID_LENOVO_X13_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB2: case USB_DEVICE_ID_LENOVO_X1_TAB3: @@ -620,6 +621,7 @@ static ssize_t attr_fn_lock_store(struct device *dev, break; case USB_DEVICE_ID_LENOVO_X12_TAB: case USB_DEVICE_ID_LENOVO_X12_TAB2: + case USB_DEVICE_ID_LENOVO_X13_TAB: case USB_DEVICE_ID_LENOVO_TP10UBKBD: case USB_DEVICE_ID_LENOVO_X1_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB2: @@ -791,9 +793,10 @@ static int lenovo_raw_event(struct hid_device *hdev, * Lenovo TP X12 Tab KBD's Fn+XX is HID raw data defined. Report ID is 0x03 * e.g.: Raw data received for MIC mute is 0x00020003. */ - if (unlikely((hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB - || hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB2) - && size >= 3 && report->id == 0x03)) + if (unlikely((hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB || + hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB2 || + hdev->product == USB_DEVICE_ID_LENOVO_X13_TAB) && + size >= 3 && report->id == 0x03)) return lenovo_raw_event_TP_X12_tab(hdev, le32_to_cpu(*(__le32 *)data)); return 0; @@ -877,6 +880,7 @@ static int lenovo_event(struct hid_device *hdev, struct hid_field *field, return lenovo_event_cptkbd(hdev, field, usage, value); case USB_DEVICE_ID_LENOVO_X12_TAB: case USB_DEVICE_ID_LENOVO_X12_TAB2: + case USB_DEVICE_ID_LENOVO_X13_TAB: case USB_DEVICE_ID_LENOVO_TP10UBKBD: case USB_DEVICE_ID_LENOVO_X1_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB2: @@ -1161,6 +1165,7 @@ static int lenovo_led_brightness_set(struct led_classdev *led_cdev, break; case USB_DEVICE_ID_LENOVO_X12_TAB: case USB_DEVICE_ID_LENOVO_X12_TAB2: + case USB_DEVICE_ID_LENOVO_X13_TAB: case USB_DEVICE_ID_LENOVO_TP10UBKBD: case USB_DEVICE_ID_LENOVO_X1_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB2: @@ -1355,7 +1360,8 @@ static int lenovo_probe_tp10ubkbd(struct hid_device *hdev) */ data->fn_lock = !(hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB || - hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB2); + hdev->product == USB_DEVICE_ID_LENOVO_X12_TAB2 || + hdev->product == USB_DEVICE_ID_LENOVO_X13_TAB); lenovo_led_set_tp10ubkbd(hdev, TP10UBKBD_FN_LOCK_LED, data->fn_lock); @@ -1402,6 +1408,7 @@ static int lenovo_probe(struct hid_device *hdev, break; case USB_DEVICE_ID_LENOVO_X12_TAB: case USB_DEVICE_ID_LENOVO_X12_TAB2: + case USB_DEVICE_ID_LENOVO_X13_TAB: case USB_DEVICE_ID_LENOVO_TP10UBKBD: case USB_DEVICE_ID_LENOVO_X1_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB2: @@ -1490,6 +1497,7 @@ static void lenovo_remove(struct hid_device *hdev) break; case USB_DEVICE_ID_LENOVO_X12_TAB: case USB_DEVICE_ID_LENOVO_X12_TAB2: + case USB_DEVICE_ID_LENOVO_X13_TAB: case USB_DEVICE_ID_LENOVO_TP10UBKBD: case USB_DEVICE_ID_LENOVO_X1_TAB: case USB_DEVICE_ID_LENOVO_X1_TAB2: @@ -1517,6 +1525,9 @@ static int lenovo_input_configured(struct hid_device *hdev, hi->input->propbit); } break; + case USB_DEVICE_ID_LENOVO_X13_TAB: + input_set_capability(hi->input, EV_KEY, KEY_PERFORMANCE); + break; } return 0; @@ -1551,6 +1562,8 @@ static const struct hid_device_id lenovo_devices[] = { USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X12_TAB) }, { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X12_TAB2) }, + { HID_DEVICE(BUS_USB, HID_GROUP_GENERIC, + USB_VENDOR_ID_LENOVO, USB_DEVICE_ID_LENOVO_X13_TAB) }, { HID_DEVICE(BUS_I2C, HID_GROUP_GENERIC, USB_VENDOR_ID_ITE, I2C_DEVICE_ID_ITE_LENOVO_YOGA_SLIM_7X_KEYBOARD) }, { } -- 2.54.0