From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E421C38A710 for ; Fri, 22 May 2026 06:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779433171; cv=none; b=INS/BxWo7mJJy0qUouAaIPVP/IlWMssc3J9fPCt1tudjvQHGnXvZ51UEVcneTd3KRR1oCDp1CE2+n7gboJyMGHmQnm4+be2UACEVPGdZ2H27Umsax2WkPpHmkiiq9lDCl4kvfAe/gyYl2pshJuFeySkyKKJzcYkxFL+o02Hv6Mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779433171; c=relaxed/simple; bh=Gf4IfMGXXu1WiojEHujzD/yHQ56iA+QaHBqheuc5dCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aj8rX2GUmQ1pwrbuPasauUo/SW1iTgBlUfhIupzQeadrb2slBFrlzTJer9bIKLHv3rxVW8IYiKjhEeG2uMbtsV9sxR8D2mpBJIEzUsk7Pea6W9u9aPsOPyZHbF6JuibElptmwvvSm/Z6NwnEF1SNi2aJkfMhdxUY6G1PXgdri1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AOnv0N5n; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AOnv0N5n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BB621F000E9; Fri, 22 May 2026 06:59:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779433169; bh=LXpfIPCwR9J7BljOwsx1xfeavd9YBYzAsniQAQt/y8k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AOnv0N5nweVg5QC5b5VyS1GdSxJytzWnQ8XYj6tnqz8kHRj2FCU97cCD9vHaj/+p5 6MlwCbe5PxDQYeQVjO3+uLMJ1Yscul89MXn32qDE3+da7W1hNLuteq6UkoPIpzi9Gm 4zUUCSM5S3TwBe2+1rqeJwUmHkL234Oi8bE5IHLKdl9OXNuYdgOyY3ePpjiIUHkyHJ k1T6jdZMlEZZNs4/nt3XbAPcOxfjAmy43BdhOrFtbT4WWt55EAioJl23yNhw39GuNy Bj7EHXSQ+rjiVNeYOYkKtcJvzRF4VUnsfwO+IQ0RCkmWAnapV/HaKVqVwOs/LIQG8X AEq2M8O+KhVOA== From: Chao Yu To: jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu , wallentx Subject: [PATCH 2/2] Revert: "f2fs: check in-memory sit version bitmap" Date: Fri, 22 May 2026 14:59:12 +0800 Message-ID: <20260522065912.1756240-2-chao@kernel.org> X-Mailer: git-send-email 2.54.0.746.g67dd491aae-goog In-Reply-To: <20260522065912.1756240-1-chao@kernel.org> References: <20260522065912.1756240-1-chao@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit ae27d62e6bef ("f2fs: check in-memory sit version bitmap") added a mirror for sit version bitmap, it expects to detect in-memory corruption, however we never got any reports from the check points for almost decade, let's remove the code, it can help to save memories. Cc: wallentx Suggested-by: Jaegeuk Kim Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 6 ------ fs/f2fs/segment.h | 16 ---------------- 2 files changed, 22 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 9926ba9d77ba..993555042876 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -4882,11 +4882,6 @@ static int build_sit_info(struct f2fs_sb_info *sbi) return -ENOMEM; #ifdef CONFIG_F2FS_CHECK_FS - sit_i->sit_bitmap_mir = kmemdup(src_bitmap, - sit_bitmap_size, GFP_KERNEL); - if (!sit_i->sit_bitmap_mir) - return -ENOMEM; - sit_i->invalid_segmap = f2fs_kvzalloc(sbi, main_bitmap_size, GFP_KERNEL); if (!sit_i->invalid_segmap) @@ -5849,7 +5844,6 @@ static void destroy_sit_info(struct f2fs_sb_info *sbi) SM_I(sbi)->sit_info = NULL; kfree(sit_i->sit_bitmap); #ifdef CONFIG_F2FS_CHECK_FS - kfree(sit_i->sit_bitmap_mir); kvfree(sit_i->invalid_segmap); #endif kfree(sit_i); diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h index 38a56b8ab2cc..b0c06b3580b4 100644 --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -206,8 +206,6 @@ struct sit_info { char *bitmap; /* all bitmaps pointer */ char *sit_bitmap; /* SIT bitmap pointer */ #ifdef CONFIG_F2FS_CHECK_FS - char *sit_bitmap_mir; /* SIT bitmap mirror */ - /* bitmap of segments to be ignored by GC in case of errors */ unsigned long *invalid_segmap; #endif @@ -549,11 +547,6 @@ static inline void get_sit_bitmap(struct f2fs_sb_info *sbi, { struct sit_info *sit_i = SIT_I(sbi); -#ifdef CONFIG_F2FS_CHECK_FS - if (memcmp(sit_i->sit_bitmap, sit_i->sit_bitmap_mir, - sit_i->bitmap_size)) - f2fs_bug_on(sbi, 1); -#endif memcpy(dst_addr, sit_i->sit_bitmap, sit_i->bitmap_size); } @@ -894,12 +887,6 @@ static inline pgoff_t current_sit_addr(struct f2fs_sb_info *sbi, f2fs_bug_on(sbi, !valid_main_segno(sbi, start)); -#ifdef CONFIG_F2FS_CHECK_FS - if (f2fs_test_bit(offset, sit_i->sit_bitmap) != - f2fs_test_bit(offset, sit_i->sit_bitmap_mir)) - f2fs_bug_on(sbi, 1); -#endif - /* calculate sit block address */ if (f2fs_test_bit(offset, sit_i->sit_bitmap)) blk_addr += sit_i->sit_blocks; @@ -925,9 +912,6 @@ static inline void set_to_next_sit(struct sit_info *sit_i, unsigned int start) unsigned int block_off = SIT_BLOCK_OFFSET(start); f2fs_change_bit(block_off, sit_i->sit_bitmap); -#ifdef CONFIG_F2FS_CHECK_FS - f2fs_change_bit(block_off, sit_i->sit_bitmap_mir); -#endif } static inline unsigned long long get_mtime(struct f2fs_sb_info *sbi, -- 2.49.0